Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
7
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Open sidebar
Graphics
Okular
Commits
82590da1
Commit
82590da1
authored
Oct 28, 2020
by
Albert Astals Cid
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix wrong memory access that may cause crash
When editing the quick annotations
parent
924a5fb9
Pipeline
#38936
passed with stage
in 67 minutes and 52 seconds
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
conf/editannottooldialog.cpp
conf/editannottooldialog.cpp
+1
-1
No files found.
conf/editannottooldialog.cpp
View file @
82590da1
...
...
@@ -136,7 +136,6 @@ QDomDocument EditAnnotToolDialog::toolXml() const
engineElement
.
appendChild
(
annotationElement
);
const
QString
color
=
m_stubann
->
style
().
color
().
name
(
QColor
::
HexArgb
);
const
QString
textColor
=
static_cast
<
Okular
::
TextAnnotation
*>
(
m_stubann
)
->
textColor
().
name
();
const
QString
opacity
=
QString
::
number
(
m_stubann
->
style
().
opacity
());
const
QString
width
=
QString
::
number
(
m_stubann
->
style
().
width
());
...
...
@@ -252,6 +251,7 @@ QDomDocument EditAnnotToolDialog::toolXml() const
annotationElement
.
setAttribute
(
QStringLiteral
(
"icon"
),
sa
->
stampIconName
());
}
else
if
(
toolType
==
ToolTypewriter
)
{
Okular
::
TextAnnotation
*
ta
=
static_cast
<
Okular
::
TextAnnotation
*>
(
m_stubann
);
const
QString
textColor
=
ta
->
textColor
().
name
();
toolElement
.
setAttribute
(
QStringLiteral
(
"type"
),
QStringLiteral
(
"typewriter"
));
engineElement
.
setAttribute
(
QStringLiteral
(
"type"
),
QStringLiteral
(
"PickPoint"
));
engineElement
.
setAttribute
(
QStringLiteral
(
"block"
),
QStringLiteral
(
"true"
));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment