Commit bc85160d authored by Albert Astals Cid's avatar Albert Astals Cid

clang-tidy: Disable performance-no-automatic-move

It's just too aggressive with Qt classes that are refcounted and fine to
copy
parent d1c2eed1
Pipeline #43533 passed with stage
in 32 minutes and 21 seconds
---
Checks: 'clang-diagnostic-*,clang-analyzer-*,-*,performance-*,bugprone-*,readability-inconsistent-declaration-parameter-name,readability-string-compare,modernize-redundant-void-arg,modernize-use-bool-literals,modernize-make-unique,modernize-make-shared,modernize-use-override,modernize-use-equals-delete,modernize-use-emplace,modernize-loop-convert,modernize-use-nullptr,-bugprone-macro-parentheses,-bugprone-narrowing-conversions,-bugprone-branch-clone,-bugprone-incorrect-roundings,-bugprone-suspicious-include,-bugprone-reserved-identifier'
Checks: 'clang-diagnostic-*,clang-analyzer-*,-*,performance-*,bugprone-*,readability-inconsistent-declaration-parameter-name,readability-string-compare,modernize-redundant-void-arg,modernize-use-bool-literals,modernize-make-unique,modernize-make-shared,modernize-use-override,modernize-use-equals-delete,modernize-use-emplace,modernize-loop-convert,modernize-use-nullptr,-bugprone-macro-parentheses,-bugprone-narrowing-conversions,-bugprone-branch-clone,-bugprone-incorrect-roundings,-bugprone-suspicious-include,-bugprone-reserved-identifier,-performance-no-automatic-move'
WarningsAsErrors: '*'
HeaderFilterRegex: '.*/okular/.*'
AnalyzeTemporaryDtors: false
......
......@@ -420,7 +420,7 @@ QString dvifile::convertPDFtoPS(const QString &PDFFilename, QString *converrorms
convertedFiles[PDFFilename] = convertedFileName;
tmpfile.setAutoRemove(false);
return convertedFileName; //// NOLINT(performance-no-automatic-move) QString is cheap to copy and we prefer the const safety
return convertedFileName;
}
bool dvifile::saveAs(const QString &filename)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment