Skip to content
  • Ambareesh Balaji's avatar
    Port QML Rectangle cropper to QWidget + QPainter · 958fdc0a
    Ambareesh Balaji authored and Nate Graham's avatar Nate Graham committed
    Summary:
    1. Port QML canvas based screenshot cropper to QWidget + QPainter based cropper
    2. Fix minor bugs with cropper while porting, like system font not being set for size indicator
    3. "Include mouse pointer" setting now blends the cursor into the screenshot right away, letting the user see it while cropping, rather than blending it in after cropping
    
    Before:
    {F5830086}
    {F5830115}
    After:
    {F5830100}
    {F5830117}
    
    BUG: 394503
    BUG: 374009
    
    Test Plan: Compare with original cropper and check if I missed something
    
    Reviewers: #spectacle, broulik, ngraham, alexeymin
    
    Reviewed By: #spectacle, broulik, ngraham, alexeymin
    
    Subscribers: alexeymin, kpiwowarski, broulik, sharvey, guotao, ngraham, rkflx, #spectacle
    
    Tags: #spectacle
    
    Differential Revision: https://phabricator.kde.org/D12626
    958fdc0a