1. 06 Dec, 2019 1 commit
  2. 03 Sep, 2019 5 commits
  3. 28 Aug, 2019 2 commits
    • Antonio Prcela's avatar
      Rename mCopySaveLocationToClipboard to mCopyToClipboard · 29db5f09
      Antonio Prcela authored
      Summary:
      Reverts the renaming in 172e40bd
      Since it's used only as a flag to save the image to clipboard
      
      Reviewers: #spectacle, davidre, ngraham
      
      Reviewed By: #spectacle, davidre, ngraham
      
      Subscribers: #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D23536
      29db5f09
    • Antonio Prcela's avatar
      FIX: Close spectacle if it's started with: -b -c · 331d3cea
      Antonio Prcela authored
      Summary:
      Spectacle should close if both `-b` and `-c` are set
      
      Preparation to fix this one:
      CCBUG: 411263
      
      Test Plan:
      start spectacle:
      spectacle -b -c
      
      Expected:
      
        # Spectacle runs in background and the screenshot gets saved to clipboard
        # Spectacle closes itself after the notification disappears (or has been closed by the user)
      
      Observed:
        # Spectacle runs in background and the screenshot gets saved to clipboard
        # Spectacle never quits
      
      Reviewers: davidre
      
      Subscribers: ngraham, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D23522
      331d3cea
  4. 26 Aug, 2019 1 commit
    • Antonio Prcela's avatar
      Add autosave feature · 7f809fc9
      Antonio Prcela authored
      Summary:
      FEATURE: 390415
      Add an option to automatically save the screenshot immediately after it has been taken
      
      Test Plan:
      {F7252033}
      
        # Enable the option //Autosave the image to 'Save location' with 'Filename'//
        # Take a screenshot
        # Image gets saved ASAP
      
      If you launch Spectacle with a hotkey (for example: PrtSc), it takes the screenshot and saves the image immediately.
      
      Reviewers: #vdg, #spectacle, davidre, ngraham
      
      Reviewed By: #vdg, #spectacle, davidre, ngraham
      
      Subscribers: davidre, ngraham, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D23210
      7f809fc9
  5. 23 Aug, 2019 1 commit
  6. 21 Aug, 2019 1 commit
  7. 20 Aug, 2019 1 commit
    • David Redondo's avatar
      Don't exit when running in gui mode and notification times out · 7f30ee85
      David Redondo authored
      This was originally commited as
      https://cgit.kde.org/spectacle.git/commit/?id=c6ad1d6ae9291685b2767ab70bdeaaadb7783658,
      which due to an oversight was not merged to master like it should have
      been. Original commit message:
      
      Summary: If a screenshot is taken in DBus or background mode and the running instance is 'upgraded' to gui mode while the notification is displaying the instance would still exit after the notification timed out or was destroyed. So simply check if we are running in gui mode before exiting.
      
      Test Plan:
        # Take a screenshot via shortcut without opening Spectacle
      
        # While the notifcation displays open Spectacle for example via shortcut (don't run the binary directly)
      
        # Spectacle doesn't exit when the notifcation times out or is closed
      
      Reviewers: #spectacle, broulik, ngraham
      
      Reviewed By: #spectacle, ngraham
      
      Subscribers: ngraham, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D21052
      7f30ee85
  8. 16 Jul, 2019 1 commit
    • David Redondo's avatar
      Change the screenshot button to cancel during the timeout · da30d66c
      David Redondo authored
      Summary:
      During the timeout period Spectacle now displays an animation in the taskmanager.
      If the windows is unminized and the button clicked again (possibly multiple
      times) the window will hide and show and hide again (depending on how often you
      clicked) while all the button presses are processed.
      To avoid this situation change the button to cancel the currently running
      process. It then can also be triggered by the appropiate shortcut.
      
      Test Plan:
      - Unminimize and click the button
      - Let the screenshot finish, the button is in it's original state
      - cancel a region selection
      
      Reviewers: #spectacle, broulik, ngraham
      
      Reviewed By: #spectacle, ngraham
      
      Subscribers: ngraham
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D22234
      da30d66c
  9. 09 Jul, 2019 1 commit
  10. 23 Jun, 2019 1 commit
  11. 22 Jun, 2019 1 commit
  12. 21 Jun, 2019 2 commits
    • David Redondo's avatar
      Display delay in the taskmanager · da42ea07
      David Redondo authored
      Summary:
      Before when taking a screenshot with delay Spectacle hid itself without any
      Feedback to the user. There was no visible indication if the screenshotting
      process continued, of the remaining time or if the program was still running.
      This displays the display as progress in the taskmanager.
      
      Test Plan: {F6875730}
      
      Reviewers: #spectacle, broulik, felixernst, ngraham
      
      Reviewed By: #spectacle, broulik, felixernst, ngraham
      
      Subscribers: anthonyfieroni, ngraham, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D21638
      da42ea07
    • David Redondo's avatar
      Port to KGlobalAccel · 1d568009
      David Redondo authored
      Summary:
      Port to KGlobalAccel. This enables us to drop khotkeys and display a configuration
      dialog inside the application. The update script correctly sets the defaults and migrates
      possibly user changed shortcuts. I didn't know where to place the KActionCollection
      and put it in SpectacleConfig for the moment.
      
      FEATURE: 388592
      FIXED-IN: 19.08.0
      
      Test Plan: Shortcuts should work as before.
      
      Reviewers: #spectacle, davidedmundson, ngraham
      
      Reviewed By: #spectacle, davidedmundson, ngraham
      
      Subscribers: asturmlechner, ngraham, #spectacle
      
      Tags: #spectacle
      
      Maniphest Tasks: T10519
      
      Differential Revision: https://phabricator.kde.org/D19310
      1d568009
  13. 15 May, 2019 1 commit
    • David Redondo's avatar
      Don't exit when running in gui mode and notification times out · c6ad1d6a
      David Redondo authored
      Summary: If a screenshot is taken in DBus or background mode and the running instance is 'upgraded' to gui mode while the notification is displaying the instance would still exit after the notification timed out or was destroyed. So simply check if we are running in gui mode before exiting.
      
      Test Plan:
        # Take a screenshot via shortcut without opening Spectacle
      
        # While the notifcation displays open Spectacle for example via shortcut (don't run the binary directly)
      
        # Spectacle doesn't exit when the notifcation times out or is closed
      
      Reviewers: #spectacle, broulik, ngraham
      
      Reviewed By: #spectacle, ngraham
      
      Subscribers: ngraham, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D21052
      c6ad1d6a
  14. 05 May, 2019 4 commits
  15. 01 Apr, 2019 1 commit
  16. 26 Mar, 2019 2 commits
  17. 22 Feb, 2019 1 commit
    • David Redondo's avatar
      [WIP] Add option to configure what happens if the Print key is pressed while... · 4b52871a
      David Redondo authored
      [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running
      
      Summary:
      Adds options to configure what happens if the Print key is pressed while Spectacle is already running as discussed in T9855.
      Taking a new screenshot and opening a new Instance are working. If already two Instances are open only one new one will be created.
      Focusing the window doesn't work it only gets marked in the panel.
      Also when in a second instance the option is changed it doesn't affect the other instances altough the spectaclerc is changed.
      I also need some help with the strings as currently the description is very long and not good but I couldn't think of anything suitable:
      {F6623755}
      
      Closes T9855
      
      FEATURE: 383897
      FEATURE: 374770
      FEATURE: 399760
      FIXED-IN: 19.04.0
      
      Reviewers: #spectacle, #vdg, davidedmundson, ngraham
      
      Reviewed By: #spectacle, #vdg, ngraham
      
      Subscribers: davidedmundson, zzag, abetts, ngraham, #spectacle
      
      Tags: #spectacle
      
      Maniphest Tasks: T9855
      
      Differential Revision: https://phabricator.kde.org/D19153
      4b52871a
  18. 18 Feb, 2019 1 commit
    • David Redondo's avatar
      Add option to remember rectangular region until next restart · ce977bc0
      David Redondo authored
      Summary:
      This adds an option to rememeber the last rectangular region until the next restart. If the user previously had selected the old remember region
      checkbox the "remember across restarts will be selected" to preserve the old behavior. Also reorganised the settings page a bit. Something to
      think about is changing  the "General" settings page to one specific to rectangular region as it contains only options for it.
      Old:{F6621352} New:{F6621355}
      
      BUG: 391299
      
      Reviewers: #spectacle, #vdg, ngraham
      
      Reviewed By: #spectacle, #vdg, ngraham
      
      Subscribers: ngraham, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D19117
      ce977bc0
  19. 07 Jan, 2019 1 commit
  20. 22 Nov, 2018 1 commit
  21. 02 Nov, 2018 1 commit
  22. 11 Sep, 2018 1 commit
  23. 12 Aug, 2018 1 commit
    • __ __'s avatar
      Fix missing notification title found by -Wswitch-enum · 6eebb57e
      __ __ authored
      Summary:
      When capturing a screenshot in background mode or when
      {nav Quit after Save or Copy} is checked, Spectacle shows a notfication.
      
      Normally that notification has the capture mode set as the title, but
      for {nav Window Under Cursor} it was missing (in case
      {nav Capture the current pop-up only} was unchecked too).
      
      This was due to one missing case in a `switch` statement, found by using
      stricter compiler warnings.
      
      FIXED-IN: 18.08.1
      
      Test Plan: `spectacle -ub` should include a title in the notification again.
      
      Reviewers: #spectacle, ngraham
      
      Reviewed By: #spectacle, ngraham
      
      Differential Revision: https://phabricator.kde.org/D14716
      6eebb57e
  24. 11 Aug, 2018 1 commit
  25. 09 Aug, 2018 1 commit
    • __ __'s avatar
      Fix more warnings uncovered by -Wswitch-enum · c15d63d7
      __ __ authored
      There should be no functional changes, but the code is more explicit in
      some places and a missing icon is added (currently unused).
      
      One user-facing change has been split out to D14716.
      c15d63d7
  26. 12 Jun, 2018 1 commit
  27. 04 May, 2018 1 commit
    • Ambareesh  Balaji's avatar
      Fix memory leaks · d929ba42
      Ambareesh Balaji authored
      Summary:
      Fix a few memory leaks, and some other minor fixes
      Before:
      {F5831175}
      After:
      {F5831176}
      
      Reviewers: rkflx
      
      Reviewed By: rkflx
      
      Subscribers: anthonyfieroni, ngraham, rkflx, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D12671
      d929ba42
  28. 31 Mar, 2018 1 commit
  29. 17 Mar, 2018 1 commit
    • Scott Harvey's avatar
      Resolve compiler fallthrough warnings · 978f9ee7
      Scott Harvey authored
      Summary:
      Added "break;" and "return;" where needed to resolve fallthrough warnings
      
      - Resolve compiler fallthrough warning in Main.cpp, line 135
      Added call to `quitOnLastWindowClosed(false)` at the end of `BackgroundMode` block,
      ensuring this flag is set directly, rather than allowing it to be set via fallthrough into the
      `DBusMode` block beneath. Added `break` to properly end the `BackgroundMode` block.
      
      - Resolve compiler fallthrough warning in SpectacleCore.cpp, line 212
      Added explicit call to emit 'allDone()' signal, rather than allowing execution to fall through
      into block for DBusMode, which previously emitted the signal. This change also removes the
      emission of signal 'grabFailed()' during a BackgroundMode failure, which only happened due
      to the fallthrough into the DBus block, but signaling on the bus is not needed in `BackgroundMode`.
      
      Test Plan:
        - Compile Spectacle
        - Ensure warnings at Main.cpp:135 and SpectacleCore.cpp:212 are eliminated
      
      Reviewers: #spectacle, rkflx, ngraham
      
      Reviewed By: #spectacle, rkflx, ngraham
      
      Differential Revision: https://phabricator.kde.org/D10936
      978f9ee7
  30. 07 Mar, 2018 1 commit