1. 14 Mar, 2019 1 commit
    • David Redondo's avatar
      Make the filename placeholders clickable · 431ea89f
      David Redondo authored
      Summary:
      This allows the user to click the placeholders. First step to improve the filename template configuration. I also moved the available placeholders to the ExportManager. The SaveOptionsPage doesn't need to care about which options are present and we have to change them in only one class if we want to make changes.
      Further steps I plan to do are displaying a preview, improving the Layout (we had to increase the size already) and eventually using better placeholders.
      
      BUG: 390856
      FIXED-IN: 19.04.0
      
      Test Plan:
      - Click on placeholder
      - It appears in the LineEdit
      
      Reviewers: #spectacle, ngraham
      
      Reviewed By: #spectacle, ngraham
      
      Subscribers: ngraham
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D19755
      431ea89f
  2. 08 Mar, 2019 1 commit
  3. 07 Mar, 2019 2 commits
    • Nils Rother's avatar
      Add Compression Quality slider for lossy formats · 95616105
      Nils Rother authored
      Summary:
      FEATURE: 63151
      FIXED-IN: 19.04.0
      
      This adds a slider to set the compression quality for lossy file formats
      to the settings page, so users can set it themselves instead of having
      to just accept the (in my opinion too low) default value.
      The slider defaults to a quality level of 90.
      
      A couple of notes:
      
        -When adding the slider to the 'Save'-page layout I noticed that the
         bottom of the help text for the filename chooser got cut off because
         the window was too small. I tried to figure out how to get the settings
         page to scroll but couldn't quite get it working. Instead I resorted to
         simply increasing the default size of the settings window just enough to make it
         fit. If someone with more experience in Qt than me can get the page to scroll OR
         can suggest a better way to display the formatting help text (which I feel
         takes up too much of the page), that would be marvelous.
      
        -When saving an image at full (100) quality it still looks a bit washed out and
         fuzzy, when compared to, for example, saving the image as png and converting it
         to JPG in gimp at full quality. This might be an issue with QImageWriter unless
         this is the desired behaviour? I haven't looked into it too much, just something
         I've noticed when testing
      
      Test Plan:
      This setting can be found under
      Configure -> Save -> Compression Quality
      {F6669261}
      Set the default file type to JPG, adjust the slider and export to an image-viewer
      of your choosing (eg. feh) to see how it affects image quality.
      
      Reviewers: #vdg, #spectacle, davidre, ngraham
      
      Reviewed By: #vdg, #spectacle, davidre, ngraham
      
      Subscribers: ngraham, davidre, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D19591
      95616105
    • Yuri Chornoivan's avatar
  4. 06 Mar, 2019 1 commit
    • Nils Rother's avatar
      Add option to auto-accept box selection on mouse release · bda92cdc
      Nils Rother authored
      Summary:
      FEATURE: 404829
      Adds the option to have spectacle accept the selected region as soon
      as the mouse button is released, similar to how other screenshot tools
      allow it (eg. scrot -s).
      
      Test Plan:
      To enable the option go to
      Configure -> General -> Rectangular Region -> Accept region on mouse release
      then set the Capture mode to Rectangular Region and take a new screenshot.
      
      {F6657239}
      
      Behaviour should be the following:
        -When selecting a new region, without a previously saved region available,
         click->drag->release should immediately capture the selected region.
        -When a previously saved region is shown, the saved region can be
         manipulated further and saving this region requires manual confirmation
         (Enter/Double LMB).
        -Clicking and dragging outside of the previously saved region
         captures the newly selected region immediately.
      
      Reviewers: #vdg, #spectacle, ngraham
      
      Reviewed By: #vdg, #spectacle, ngraham
      
      Subscribers: ngraham, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D19525
      bda92cdc
  5. 04 Mar, 2019 1 commit
    • Nils Rother's avatar
      Fix recangle-selection help-text positioning · 7e747661
      Nils Rother authored
      Summary:
      BUG: 361053
      
      When taking a screenshot with the rectangle selection tool in spectacle,
      the overlaid help-text is put in the center of the entire desktop,
      instead of the center of a single display. This can cause readability
      issues when it is placed on the bezel of two physical displays.
      This patch horizontally centers the help-text overlay on the primary display.
      This affects both the "Click anywhere to start" dialogue and the hotkey help-text.
      
      Test Plan:
      Before:
      {F6656417}
      {F6656455}
      
      After:
      {F6656419}
      {F6656456}
      
      Reviewers: #spectacle, #vdg, ngraham
      
      Reviewed By: #spectacle, #vdg, ngraham
      
      Subscribers: abetts, ngraham
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D19515
      7e747661
  6. 27 Feb, 2019 1 commit
  7. 23 Feb, 2019 2 commits
  8. 22 Feb, 2019 2 commits
    • David Redondo's avatar
      [WIP] Add option to configure what happens if the Print key is pressed while... · 4b52871a
      David Redondo authored
      [WIP] Add option to configure what happens if the Print key is pressed while Spectacle is already running
      
      Summary:
      Adds options to configure what happens if the Print key is pressed while Spectacle is already running as discussed in T9855.
      Taking a new screenshot and opening a new Instance are working. If already two Instances are open only one new one will be created.
      Focusing the window doesn't work it only gets marked in the panel.
      Also when in a second instance the option is changed it doesn't affect the other instances altough the spectaclerc is changed.
      I also need some help with the strings as currently the description is very long and not good but I couldn't think of anything suitable:
      {F6623755}
      
      Closes T9855
      
      FEATURE: 383897
      FEATURE: 374770
      FEATURE: 399760
      FIXED-IN: 19.04.0
      
      Reviewers: #spectacle, #vdg, davidedmundson, ngraham
      
      Reviewed By: #spectacle, #vdg, ngraham
      
      Subscribers: davidedmundson, zzag, abetts, ngraham, #spectacle
      
      Tags: #spectacle
      
      Maniphest Tasks: T9855
      
      Differential Revision: https://phabricator.kde.org/D19153
      4b52871a
    • David Redondo's avatar
      Use qdbus for actions in desktop file · ee862d16
      David Redondo authored
      Summary:
      As noted by @davidedmundson in D19153 Spectacle uses the spectacle command for the actions it defines in it's desktop file. This changes these
      actions to use the same dbus commands as the actions defined in the khotkeys file. This opens the screenshot in the same instance of Spectacle
      if it's running. Which is more expected than opening a new window if you right click on spectacle in the task manager and give it the command
      "Take a new screenshot"
      
      Test Plan:
      - Open Spectacle
      - Right click on it in the task manager
      - No new window is opened, spectacle is now showing the new screenshot
      
      Reviewers: #spectacle, davidedmundson, ngraham
      
      Reviewed By: #spectacle, davidedmundson, ngraham
      
      Subscribers: davidedmundson, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D19225
      ee862d16
  9. 21 Feb, 2019 1 commit
  10. 18 Feb, 2019 2 commits
    • David Redondo's avatar
      Change default behavior to remembering the selected region until Spectacle is closed · 4c2cedbe
      David Redondo authored
      Summary:
      Change the default to remembering the selected region until the next restart while still preserving the old behavior if a user had previously selected "remember region" which worked across restarts.
      
      FEATURE: 391299
      FIXED-IN: 19.04.0
      
      Reviewers: #spectacle, #vdg, ngraham
      
      Reviewed By: #spectacle, #vdg, ngraham
      
      Subscribers: #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D19130
      4c2cedbe
    • David Redondo's avatar
      Add option to remember rectangular region until next restart · ce977bc0
      David Redondo authored
      Summary:
      This adds an option to rememeber the last rectangular region until the next restart. If the user previously had selected the old remember region
      checkbox the "remember across restarts will be selected" to preserve the old behavior. Also reorganised the settings page a bit. Something to
      think about is changing  the "General" settings page to one specific to rectangular region as it contains only options for it.
      Old:{F6621352} New:{F6621355}
      
      BUG: 391299
      
      Reviewers: #spectacle, #vdg, ngraham
      
      Reviewed By: #spectacle, #vdg, ngraham
      
      Subscribers: ngraham, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D19117
      ce977bc0
  11. 15 Feb, 2019 1 commit
  12. 04 Feb, 2019 1 commit
  13. 02 Feb, 2019 1 commit
  14. 29 Jan, 2019 1 commit
    • Nate Graham's avatar
      Use new toolbox icon for "Tools" dropdown menu button · 9fe51427
      Nate Graham authored
      Summary: Use the awesome new `tools` icon in the {nav Tools} dropdown menu button. Since the icon is only available in Frameworks 5.55, we use the old icon as a fallback since the minimum frameworks version is still 5.29.
      
      Test Plan: {F6557432}
      
      Reviewers: #spectacle, #vdg, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: broulik
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D18400
      9fe51427
  15. 28 Jan, 2019 1 commit
  16. 26 Jan, 2019 1 commit
  17. 24 Jan, 2019 3 commits
  18. 20 Jan, 2019 1 commit
  19. 14 Jan, 2019 1 commit
  20. 11 Jan, 2019 1 commit
  21. 07 Jan, 2019 1 commit
  22. 06 Jan, 2019 1 commit
  23. 04 Jan, 2019 2 commits
  24. 03 Jan, 2019 1 commit
  25. 02 Jan, 2019 2 commits
  26. 25 Dec, 2018 1 commit
  27. 24 Dec, 2018 2 commits
  28. 22 Dec, 2018 1 commit
    • Ambareesh  Balaji's avatar
      Fix translated text · ba58af10
      Ambareesh Balaji authored
      Summary:
      `i18n` doesn't work before QCoreApplication is created, hence statically initialized text is not translated.
      
      Related: D12626
      
      Reviewers: ngraham, #spectacle, broulik, #localization, yurchor
      
      Reviewed By: ngraham, #spectacle, yurchor
      
      Subscribers: pino, yurchor, broulik, ngraham
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D17654
      ba58af10
  29. 18 Dec, 2018 1 commit
  30. 17 Dec, 2018 2 commits
    • Ambareesh  Balaji's avatar
      Port QML Rectangle cropper to QWidget + QPainter · 958fdc0a
      Ambareesh Balaji authored
      Summary:
      1. Port QML canvas based screenshot cropper to QWidget + QPainter based cropper
      2. Fix minor bugs with cropper while porting, like system font not being set for size indicator
      3. "Include mouse pointer" setting now blends the cursor into the screenshot right away, letting the user see it while cropping, rather than blending it in after cropping
      
      Before:
      {F5830086}
      {F5830115}
      After:
      {F5830100}
      {F5830117}
      
      BUG: 394503
      BUG: 374009
      
      Test Plan: Compare with original cropper and check if I missed something
      
      Reviewers: #spectacle, broulik, ngraham, alexeymin
      
      Reviewed By: #spectacle, broulik, ngraham, alexeymin
      
      Subscribers: alexeymin, kpiwowarski, broulik, sharvey, guotao, ngraham, rkflx, #spectacle
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D12626
      958fdc0a
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · e5a22132
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      e5a22132