1. 14 Mar, 2019 1 commit
    • David Redondo's avatar
      Make the filename placeholders clickable · 431ea89f
      David Redondo authored
      This allows the user to click the placeholders. First step to improve the filename template configuration. I also moved the available placeholders to the ExportManager. The SaveOptionsPage doesn't need to care about which options are present and we have to change them in only one class if we want to make changes.
      Further steps I plan to do are displaying a preview, improving the Layout (we had to increase the size already) and eventually using better placeholders.
      BUG: 390856
      FIXED-IN: 19.04.0
      Test Plan:
      - Click on placeholder
      - It appears in the LineEdit
      Reviewers: #spectacle, ngraham
      Reviewed By: #spectacle, ngraham
      Subscribers: ngraham
      Tags: #spectacle
      Differential Revision: https://phabricator.kde.org/D19755
  2. 15 Oct, 2018 1 commit
    • Kyle Utecht's avatar
      clarify logic for openScreenshotsFolder, refactor preferences access, and clarify method names · 74a2df91
      Kyle Utecht authored
      New openScreenshotsFolder logic is to highlight recently saved file, then default save location
      (save mode) or last saved file's folder (save as mode) with failsafe as default save location.
      SpectacleConfig now stores the last saved files and can determine the last saved file location from the
      file name through separate method. Removed extraneous methods and variables from ExportManager.
      ExportManager now uses SpectacleConfig to access save location preferences.
      BUG: 394182
      Reviewers: #spectacle, ngraham
      Reviewed By: #spectacle, ngraham
      Subscribers: ngraham, #spectacle
      Tags: #spectacle
      Differential Revision: https://phabricator.kde.org/D15908
  3. 21 Sep, 2018 1 commit
  4. 11 Sep, 2018 1 commit
  5. 29 Jun, 2018 1 commit
  6. 12 Jun, 2018 1 commit
  7. 08 Jun, 2018 1 commit
  8. 06 Mar, 2018 1 commit
    • Roman Inflianskas's avatar
      Add optional window title to filename templates · d47ab66e
      Roman Inflianskas authored
      Add '%T' placeholder for filename pattern to insert window title.
      Example filenames for pattern `%Y-%M-%D %H-%m-%S. %T`:
      2018-02-21 19-11-55. romas : byobu.png
      2018-02-21 19-12-20.png
      Example filenames for pattern `%T`:
      romas : byobu.png
      Closes T8036
      FEATURE: 378463
      FIXED-IN: 18.04.0
      Test Plan:
      # Go to `Configure... -> Save`.
      # Enter to `Default Save Filename -> Filename` tempate `%Y-%M-%D %H-%m-%S. %T`.
      # Press `OK`.
      # Save screenshot.
      # Observe that screenshot filename matches pattern.
      Examples of filenames with empty window title:
      > | Input | Result |
      > | --- | --- |
      > | Screenshot_%T_ProjectX | Screenshot_ProjectX |
      > | %T_ProjectX | ProjectX |
      > | Screenshot_%T | Screenshot |
      > | %T | Screenshot |
      Reviewers: rkflx, #spectacle
      Reviewed By: rkflx, #spectacle
      Subscribers: ngraham, rkflx
      Tags: #spectacle
      Maniphest Tasks: T8036
      Differential Revision: https://phabricator.kde.org/D10709
  9. 14 Feb, 2018 1 commit
    • Henrik Fehlauer's avatar
      Add action to open screenshots folder to tools menu · 7034b50c
      Henrik Fehlauer authored
      With {nav Quit after Save or Copy} checked, there is a desktop
      notification when saving which allows to open the folder containing the
      saved screenshot. However, when the user opts to let the window stay
      open, only the title will reflect the filename of the saved screenshot.
      It's quite hard to know in which folder it was saved and not that easy
      to open that folder.
      By introducing {nav Tools > Open Screenshots Folder}, usability in that
      regard is much-improved. When no screenshot has been saved yet, it will
      open the last {nav Save As} folder or the default {nav Save} location
      depending on the button state. As soon as a screenshot is saved, the
      new action will highlight the new screenshot in the filemanager.
      BUG: 389695
      Depends on D10467
      Ref T7841
      Test Plan:
      For {nav Save} and {nav Save As} each, click on new menu entry after
      starting Spectacle as well as after saving. Also test everything with
      `fish:/` (but beware of Bug 390297).
      Reviewers: #spectacle, ngraham
      Reviewed By: #spectacle, ngraham
      Subscribers: ngraham
      Maniphest Tasks: T7841
      Differential Revision: https://phabricator.kde.org/D10470
  10. 11 Feb, 2018 1 commit
    • Nathaniel Graham's avatar
      (3/3) add option to quit after save or copy operations · 2b1c8bec
      Nathaniel Graham authored
      Part 3 of 3 for {T7841}
      FEATURE: 389773
      FIXED-IN: KDE Applications 18.04
      We add a checkbox visible on the main UI to quit Spectacle after save or copy operations. This yields the following benefits:
      - We can remove the "Save & Exit" item from the split button
      - Users gain the ability to have spectacle quit after copying the image to the clipboard
      I tried to make the feature apply to Export operations as well, but that proved to be much more complicated and I decided to abandon that for now and do it later in a subsequent patch.
      Test Plan:
      Tested in KDE Neon:
      - With "Quit after Copy or Save" unchecked:
      -- Save: image is saved
      -- Save As: file save dialog shown, image is saved
      -- Copy to Clipboard: message is shown, image is copied to clipboard
      - With "Quit after Copy or Save" checked:
      -- Save: notification shown, Spectacle quits, image is saved
      -- Save As: file save dialog shown, notification shown, Spectacle quits, image is saved
      -- Copy to Clipboard: image is copied to clipboard (if Klipper is set up to accept images), Spectacle quits
      Reviewers: #spectacle, rkflx
      Reviewed By: rkflx
      Subscribers: rkflx
      Differential Revision: https://phabricator.kde.org/D10301
  11. 18 Jan, 2018 1 commit
  12. 22 Sep, 2017 1 commit
    • Friedrich W. H. Kossebau's avatar
      Fix: use autosaveFilename format also for files exported via DnD or menu · cedfdb40
      Friedrich W. H. Kossebau authored
      When exporting the current screenshot directly to applications via a
      temporary file holding a copy of the screenshot, the very filename of the
      temporary file is then picked up in those programs, e.g. when displaying
      the file or creating a local copy. Additionally that name is also passed
      in the x-kde-suggestedfilename property on DnD.
      With the usage of QTemporaryFile this filename holds some random part, which
      makes it less useful.
      Switching to a QTemporaryDir instead for getting a non-conflicting
      namespace in the temp dirs, and using a normal file with the configured
      autosaveFilename format in that dir results in the expected naming of
      screenshot files also on export to apps via menu or DnD.
      BUG: 382718
      FIXED-IN: 17.08.02
      Reviewers: bgupta, alexeymin
      Reviewed By: alexeymin
      Subscribers: alexeymin, #kde_applications, #plasma
      Differential Revision: https://phabricator.kde.org/D7725
  13. 25 Apr, 2016 1 commit
  14. 27 Dec, 2015 1 commit
  15. 22 Dec, 2015 1 commit
  16. 13 Nov, 2015 2 commits