1. 06 Feb, 2020 1 commit
    • Nate Graham's avatar
      Find qdbus command correctly · 8822c250
      Nate Graham authored
      Summary:
      Spectacle's Desktop file assumes that `qdbus` is in $PATH. However this is not
      guaranteed; the command lives in the Qt binaries dir which is not typically in $PATH,
      and distros typically create symlinks with different names in `/usr/bin`, but not all
      create a second compatibility symlink at `/usr/bin/qdbus` that points to the version
      for the current Qt version.
      
      Therefore, we should find the command in the Qt binaries dir itself rather than relying
      on these compatibility symlinks.
      
      BUG: 413007
      FIXED-IN: 20.04.0
      
      Test Plan:
      - Delete the `/usr/bin/qdbus` symlink, if you have one
      - Compile and install Spectacle
      - Hit PrintScreen
      - See that Spectacle still opens
      
      Reviewers: davidedmundson, #spectacle, sitter
      
      Reviewed By: sitter
      
      Subscribers: sitter, #plasma, rdieter, kossebau, fvogt, davidre
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D25883
      8822c250
  2. 05 Feb, 2020 1 commit
  3. 31 Jan, 2020 1 commit
    • David Redondo's avatar
      Take screenshot with currently selected options · a9c01acf
      David Redondo authored
      Summary:
      If Spectacle is running and the user activates the shortcut to start Spectacle
      while he has the option "Take a new Screenshot" selected use the current settings
      ad configured in the window and not those of the last taken Screenshot
      
      BUG: 415688
      FIXED-IN: 20.04.0
      
      Test Plan: Open Spectacle, press print screen
      
      Reviewers: #spectacle, ngraham
      
      Reviewed By: #spectacle, ngraham
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D26929
      a9c01acf
  4. 29 Jan, 2020 4 commits
  5. 23 Jan, 2020 1 commit
  6. 14 Jan, 2020 1 commit
  7. 12 Jan, 2020 2 commits
  8. 09 Jan, 2020 1 commit
  9. 07 Jan, 2020 2 commits
  10. 06 Jan, 2020 1 commit
  11. 05 Jan, 2020 1 commit
  12. 01 Jan, 2020 1 commit
  13. 31 Dec, 2019 1 commit
    • Luigi Toscano's avatar
      Fix several user-visible messages · befcb174
      Luigi Toscano authored
      - proper case for the application name;
      - use the American spelling for consistency;
      - remove extra newline, which is reflected in the extracted string;
        maybe a parser issue, but not a bit problem removing it;
      - properly expand a label.
      befcb174
  14. 28 Dec, 2019 1 commit
  15. 27 Dec, 2019 1 commit
    • David Redondo's avatar
      Port towards KConfig XT · 9658891a
      David Redondo authored
      Summary:
      Port settings to Kconfig XT. This enables us to drop our own settings class and
      our own configuration dialog logic with it's logic. Setting the objectNames of
      the Widgets accordingly enables us to reuse them.
      The settings not managed through the Dialog (last save locations and screenshot
      options in the main window) are written now on exit but are still instant apply.
      Using this opportunity this also unifies the naming style and moves some
      settings inside the config file around: In general they are now in the same group
      as they are in the settings dialog. Additionally [Save] includes
      lastSave(As)Location, too. In [GuiConfig] are the options which are set in the
      main window and the last crop region.
      Also includes a behavioral change: "Open Screenshots Folder" will now open the
      default folder as configured. The folder with the the last saved screenshot can
      be opened from the inline message when saving.
      
      BUG: 389894
      FIXED-IN: 19.12.0
      
      Test Plan: Works as before but the dialog has now more buttons
      
      Reviewers: #spectacle, ngraham
      
      Reviewed By: #spectacle, ngraham
      
      Subscribers: guoyunhe, ervin, crossi, ngraham
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D23316
      9658891a
  16. 23 Dec, 2019 1 commit
  17. 10 Dec, 2019 1 commit
  18. 06 Dec, 2019 3 commits
  19. 05 Dec, 2019 4 commits
  20. 26 Nov, 2019 2 commits
  21. 11 Nov, 2019 3 commits
  22. 10 Nov, 2019 4 commits
  23. 22 Oct, 2019 1 commit
  24. 20 Oct, 2019 1 commit