1. 06 Feb, 2020 1 commit
    • Nate Graham's avatar
      Find qdbus command correctly · 8822c250
      Nate Graham authored
      Summary:
      Spectacle's Desktop file assumes that `qdbus` is in $PATH. However this is not
      guaranteed; the command lives in the Qt binaries dir which is not typically in $PATH,
      and distros typically create symlinks with different names in `/usr/bin`, but not all
      create a second compatibility symlink at `/usr/bin/qdbus` that points to the version
      for the current Qt version.
      
      Therefore, we should find the command in the Qt binaries dir itself rather than relying
      on these compatibility symlinks.
      
      BUG: 413007
      FIXED-IN: 20.04.0
      
      Test Plan:
      - Delete the `/usr/bin/qdbus` symlink, if you have one
      - Compile and install Spectacle
      - Hit PrintScreen
      - See that Spectacle still opens
      
      Reviewers: davidedmundson, #spectacle, sitter
      
      Reviewed By: sitter
      
      Subscribers: sitter, #plasma, rdieter, kossebau, fvogt, davidre
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D25883
      8822c250
  2. 27 Dec, 2019 1 commit
    • David Redondo's avatar
      Port towards KConfig XT · 9658891a
      David Redondo authored
      Summary:
      Port settings to Kconfig XT. This enables us to drop our own settings class and
      our own configuration dialog logic with it's logic. Setting the objectNames of
      the Widgets accordingly enables us to reuse them.
      The settings not managed through the Dialog (last save locations and screenshot
      options in the main window) are written now on exit but are still instant apply.
      Using this opportunity this also unifies the naming style and moves some
      settings inside the config file around: In general they are now in the same group
      as they are in the settings dialog. Additionally [Save] includes
      lastSave(As)Location, too. In [GuiConfig] are the options which are set in the
      main window and the last crop region.
      Also includes a behavioral change: "Open Screenshots Folder" will now open the
      default folder as configured. The folder with the the last saved screenshot can
      be opened from the inline message when saving.
      
      BUG: 389894
      FIXED-IN: 19.12.0
      
      Test Plan: Works as before but the dialog has now more buttons
      
      Reviewers: #spectacle, ngraham
      
      Reviewed By: #spectacle, ngraham
      
      Subscribers: guoyunhe, ervin, crossi, ngraham
      
      Tags: #spectacle
      
      Differential Revision: https://phabricator.kde.org/D23316
      9658891a
  3. 23 Jun, 2019 1 commit
  4. 21 Jun, 2019 1 commit
    • David Redondo's avatar
      Port to KGlobalAccel · 1d568009
      David Redondo authored
      Summary:
      Port to KGlobalAccel. This enables us to drop khotkeys and display a configuration
      dialog inside the application. The update script correctly sets the defaults and migrates
      possibly user changed shortcuts. I didn't know where to place the KActionCollection
      and put it in SpectacleConfig for the moment.
      
      FEATURE: 388592
      FIXED-IN: 19.08.0
      
      Test Plan: Shortcuts should work as before.
      
      Reviewers: #spectacle, davidedmundson, ngraham
      
      Reviewed By: #spectacle, davidedmundson, ngraham
      
      Subscribers: asturmlechner, ngraham, #spectacle
      
      Tags: #spectacle
      
      Maniphest Tasks: T10519
      
      Differential Revision: https://phabricator.kde.org/D19310
      1d568009
  5. 29 Jun, 2016 1 commit
  6. 17 Oct, 2015 1 commit
  7. 23 Sep, 2015 1 commit
  8. 15 Sep, 2015 1 commit
  9. 04 Jul, 2015 1 commit
  10. 15 Jun, 2015 1 commit
  11. 17 Apr, 2015 1 commit