GitLab

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This fixes the bug that keeps Spectacle running, happens when it's launched via either spectacle --region --background or Meta + Shift + Prt.sc.

BUG: 432006

QMap::value() failed to find existing keys in some edge cases.
Which lead to problems when translating points using a QMap.

This commit improves the operator<() to fix that.

BUG: 430942


(cherry picked from commit e1fc5c40)

kcfg_property is a magic property used by KConfigDialog to control what property is manipulated.
In this case we want to manipulate the currentText property of the QComboBox.

Strings in UI files are getting translated by default. This results in kcfg_property containing a nonexistant property for non-english locale which breaks setting the right value of the combobox.

BUG: 431557
(cherry picked from commit c1df0094)

Changed signal of Annotate button in main window from pressed to clicked in order to let annotation mode appear after button is released.

I debugged the time loss of
BUG:430173
to be inbetween when org.kde.JobViewServer.requestView is called inside
KJobWidgets and the DBus adaptor on plasmashell is notified of that.
Unfortunately our methods are implemented in a blocking way as is the call in
KUiServerJobTracker::registerJob. So a simple fix is to disable job tracking.
Furthermore if the job would take long enough to display progress, it would
display an error to the user if the file doesn't exist, which is clearly not
what we want.
FIXED-IN:20.12.1

We require KF 5.73 currently

Plus avoids using usleep, using instead select

BUG: 428636

When the drawn rectangle is on a single screen, the output image uses the screen native resolution.
When the drawn rectangle is on screens with multiple scale factor, the output image is upscaled to correspond to the screen with the hightest scale factor to keep the image undistorted.

Adds also a "scaled" full screen mode, to capture screens content downscaled to screens virtualsize allowing for undistorted content albeit loosing details.

Requires Plasma 5.19.80+

BUG: 409762
BUG: 420863
FIXED-IN: 20.12

in case the filename to save a screenshot to contains subdirectories,
the auto-increment of any %d placeholders was broken.

For a template of '%Y/%M/screen-%d' and '%Y/%M/screen-1.png' already existing
this now results in '%Y/%M/screen-2.png' being created instead of '%Y/%M/screen-1-1.png'.

Otherwise it will double its size after being processed if using 2x screen scaling

BUG:428635
FIXED-IN: 20.12.0

(cherry picked from commit 70240064)

Using KRecentDocument

BUG: 424205
FIXED-IN: 20.08.3

Check if we are running in GUI mode, if not then the mMainWindow is null and hence no need to show a screenshot.

Add a new function that gets called when an screenshot has been canceled.

BUG: 427645

Uses the same default value as the gui. Provide short flags for changing the
default behavior (-p and --nd).
BUG:425995

Qt scales coordinates relative to the upper-left corner of the screen
where the quick editor window is. This means that (0, 0) in the logical
pixels is not the same as (0, 0) in the native pixels.

Commit ccf8d522 tried to address that
issue by mapping (0, 0) from the native pixels to the logical pixels.

Unfortunately, it doesn't work reliably because setting geometry may
move a window to another screen and thus the computed window position
will be wrong.

It would be wonderful if QXcbWindowFunctions had a function that sets
the window geometry in native pixels that we could use here in Spectacle
to bypass HiDPI code path.

As a short term solution, this change makes Spectacle use XCB API
directly to position itself.

Rearrange setting so it's no more possible to have all three options activated at once: copy image to clipboard, save location to clipboard and autosave image.
Added check to avoid having all three settings at once. Updated layout with some spacers.

BUG: 420477

Separate 'if' for doCopyToClipboard() and doSave(), since one can have both active. Adjusted the corresponding notifications.

BUG: 425573
BUG: 422148

Currently when this happens, the GUI does not inform the user.