Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Spectacle Spectacle
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Graphics
  • SpectacleSpectacle
  • Merge requests
  • !132

Canceling a screenshot shall not disable buttons if previous screenshot is visible

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Antonio Prcela requested to merge aprcela/spectacle:dont_disable_buttons_if_pixmap_available into release/22.04 Apr 16, 2022
  • Overview 4
  • Commits 1
  • Pipelines 5
  • Changes 1

Problem: take screenshot, it shows up in Spectacle. Take, for example, new screenshot with rectangluar region. Cancel it, the previous screenshot is still in Spectacle, but most of the buttons are disabled.

Solution: if checking that the new Pixmap has been forwarded to setScreenshotAndShow() is empty, because the 'shot' was canceled, check if a previous screenshot is already visible in Spectacle and set mPixmapExists to true so the buttons don't get disabled. Do not check for mKSWidget->isScreenshotSet() before the 'if (mPixmapExists) {}', in case the empty pixmap will overwrite the old screenshot.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: dont_disable_buttons_if_pixmap_available