Hank Strange (7f854b31) at 27 Jun 23:01
GIT_SILENT Sync po/docbooks with svn
... and 288 more commits
Hank Strange (e66b2f5e) at 03 Jul 03:10
Should this get closed since it was decided that it should be handled on the shell level?
My SIM slot on my PPPro is broken so I can't test if this really works. The changes are essentially adding in a drivingMode
boolean to the settingsmanager.kcfg
which is then controlled by the Driving Mode
checkbox in the Settings page. That boolean is then checked when saveMessage
is called in handleIncomingMessage
. Ideally what it should be doing is seeing that driving mode is false so then it doesn't call saveMessage
and doesn't then create a notification.
I originally had the boolean in saveMessage
(see my original commit) but then notifications weren't working no matter what.
I think what would be nice is to have a notification triggered when Driving Mode is turned on so then the user doesn't forget about it. I'm not really sure how to do that though.
Any advice or guidance is welcome! P.S. This is my first time using C++ in several years so if I botched this, I apologize in advance.
Closing this since it is recommended to be part of the shell, rather than app-by-app.
That's fair. I was mostly just going off of the open issue for a Driving Mode (#22). I would love to help it get implemented into the shell but I am having a hard time understanding how notifications work in the shell and how this would even get set up there. A bit of guidance would be appreciated.
In the notifications folder, I am only seeing the notifications thumbnail as well as the notifications for the file menu (https://invent.kde.org/plasma/plasma-mobile/-/tree/master/components/mobileshell/notifications).
Shoot, I clearly overlooked that. I will try to revert back to what I had and see if I could fix why it wasn't giving any notifications at all.
You are correct, I noticed that after a bit. I noticed though that with or without driving mode on I wasn't getting any notifications though.
My SIM slot on my PPPro is broken so I can't test if this really works. The changes are essentially adding in a drivingMode
boolean to the settingsmanager.kcfg
which is then controlled by the Driving Mode
checkbox in the Settings page. That boolean is then checked when saveMessage
is called in handleIncomingMessage
. Ideally what it should be doing is seeing that driving mode is false so then it doesn't call saveMessage
and doesn't then create a notification.
I originally had the boolean in saveMessage
(see my original commit) but then notifications weren't working no matter what.
I think what would be nice is to have a notification triggered when Driving Mode is turned on so then the user doesn't forget about it. I'm not really sure how to do that though.
Any advice or guidance is welcome! P.S. This is my first time using C++ in several years so if I botched this, I apologize in advance.
Hank Strange (65600cde) at 16 Jun 18:30
update driving mode wording in settings
Hank Strange (79d5c7b8) at 16 Jun 18:29
Update driving mode wording
Hank Strange (f976538c) at 16 Jun 18:26
changed daemon logic for notifications
Fixed.
Hank Strange (6f4b1c66) at 15 Jun 15:19
Update README.md
Hank Strange (4778ec2a) at 14 Jun 20:55
adding a driving mode toggle
Hank Strange (b66bf049) at 14 Jun 17:27
Better readability and updated QCoro requirement
... and 55 more commits
Sorry that this took so long, I thought that I did this. I changed it so that the requirements are shown once and then below it are the packages belonging to that version number. Mind taking a look now?
I added QCoro5 to the required field.
Hank Strange (dc3e8b5b) at 14 Jun 17:25
Better readability and updated QCoro requirement