Commit c090e935 authored by Elvis Angelaccio's avatar Elvis Angelaccio
Browse files

Drop CliInterface::isCliBased()

The only reason why we needed to know whether an interface is CLI-based was to
check whether the executables needed by the cliplugins were available.

This check is now done in the Plugin class, so we can drop this function.
parent 848d4ec4
......@@ -65,11 +65,6 @@ bool ReadOnlyArchiveInterface::isReadOnly() const
return true;
}
bool ReadOnlyArchiveInterface::isCliBased() const
{
return false;
}
bool ReadOnlyArchiveInterface::open()
{
return true;
......
......@@ -101,8 +101,6 @@ public:
virtual bool doSuspend();
virtual bool doResume();
virtual bool isCliBased() const;
bool isHeaderEncryptionEnabled() const;
signals:
......
......@@ -89,11 +89,6 @@ CliInterface::~CliInterface()
delete m_commentTempFile;
}
bool CliInterface::isCliBased() const
{
return true;
}
void CliInterface::setListEmptyLines(bool emptyLines)
{
m_listEmptyLines = emptyLines;
......
......@@ -301,7 +301,6 @@ public:
bool doKill() Q_DECL_OVERRIDE;
bool doSuspend() Q_DECL_OVERRIDE;
bool doResume() Q_DECL_OVERRIDE;
bool isCliBased() const Q_DECL_OVERRIDE;
/**
* Returns the list of characters which are preceded by a
......
......@@ -109,7 +109,7 @@ void Job::start()
jobTimer.start();
m_isRunning = true;
if (archiveInterface()->isCliBased()) {
if (archiveInterface()->waitForFinishedSignal()) {
// CLI-based interfaces run a QProcess, no need to use threads.
QTimer::singleShot(0, this, &Job::doWork);
} else {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment