Commit ead7a07e authored by Elvis Angelaccio's avatar Elvis Angelaccio
Browse files

Drop direct connection for finished signal

The direct connection was added in commit acb455da, but since Ark 16.08 is not
necessary anymore (CliInterface runs on the main thread).

This prevents a possible race condition in our jobs
(see https://git.reviewboard.kde.org/r/128113/)

CCBUG: 193908

Differential Revision: D2225
parent e1e62711
......@@ -132,7 +132,7 @@ void Job::connectToArchiveInterfaceSignals()
connect(archiveInterface(), &ReadOnlyArchiveInterface::entryRemoved, this, &Job::onEntryRemoved);
connect(archiveInterface(), &ReadOnlyArchiveInterface::progress, this, &Job::onProgress);
connect(archiveInterface(), &ReadOnlyArchiveInterface::info, this, &Job::onInfo);
connect(archiveInterface(), &ReadOnlyArchiveInterface::finished, this, &Job::onFinished, Qt::DirectConnection);
connect(archiveInterface(), &ReadOnlyArchiveInterface::finished, this, &Job::onFinished);
connect(archiveInterface(), &ReadOnlyArchiveInterface::userQuery, this, &Job::onUserQuery);
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment