1. 10 Dec, 2014 1 commit
    • Jan Grulich's avatar
      Rename archive.h to archive_kerfuffle.h · 00821257
      Jan Grulich authored
      This fixes build of libarchiveplugin, where we need to compile against libarchive, but including <archive.h> always
      found kerfuffle/archive.h and there is no way how to force using /usr/include/archive.h instead.
      Reviewed-by: Lukáš Tinkl
  2. 14 Oct, 2014 1 commit
  3. 26 Aug, 2012 1 commit
    • Raphael Kubo da Costa's avatar
      Use a different D-Bus object path for each Ark::Part. · c79d8db2
      Raphael Kubo da Costa authored
      So far, all Ark::Part instances used the same D-Bus object path,
      "/DndExtract", to receive drag'n'drop notifications.
      This does not work correctly ever since we started supporting using Ark as
      an embedded KPart (for previewing archived inside Konqueror or Rekonq, for
      example). In this case, the object path is added to the embedder (the
      `konqueror-5654' service, for example). If one previews multiple archives in
      different tabs, multiple calls to QDBusConnection::registerObject() will be
      made and only the first one will succeed, since we are always trying to
      register the same path.
      Fixing this involves touching separate parts of the code:
       o Use a different object path for each KPart instance, just like
         KateDocument or nsplugin do. We do this by keeping a static counter that
         is incremented each time a KPart is created and is part of the path name.
       o Use other, more specific mime types for the data we send when dragging
         out of Ark. So far we used "application/x-kde-dndextract" and passed the
         D-Bus service as its value. We now pass this value in the newly-created
         "application/x-kde-ark-dndextract-service" mime type, and the object
         path, which is now passed to ArchiveModel, in
       o Also use a more specific interface name in the XML file. While here,
         generate the .cpp and .h files with CMake instead of keeping these
         auto-generated files around for no purpose.
       o ArchiveModel::mimeTypes() has been adjusted to indicate the mime types we
         actually use on drag'n'drop. The previous list was mostly bogus, as we
         only use the mime types indicated above.
      As it can be seen, applications which support drag'n'drop from Ark also need
      to be adjusted to use the new D-Bus interface. Currently, the applications
      are Dolphin, the Folderview plasmoid and a Stack Folder plasmoid in
      playground. They are all going to be updated accordingly in tandem with this
      commit to both KDE/4.9 and master. Users using SVN/git directly might
      experience some trouble if they update one part but not the other, but there
      is not much we can do in this case.
      BUG:		304860
      FIXED-IN:	4.9.1
  4. 27 Dec, 2011 1 commit
    • Raphael Kubo da Costa's avatar
      Use a QScopedPointer to keep only one Archive instance alive at a time. · 8a3e5d96
      Raphael Kubo da Costa authored
      Even though having more than one Archive instance around is harmless, it
      wastes resources with no purpose.
      We thus guard the Archive pointer in Part::openFile() with a
      QScopedPointer so that if one is trying to create an archive whose type
      is read-only for Ark (ie. .gz files) and then chooses another mimetype,
      the first created instance is deleted right away, and not when
      ArchiveModel is destroyed.
      ArchiveModel::m_archive is now also a QScopedPointer, so that we do not
      need to manually delete the current archive when
      ArchiveModel::setArchive() is called.
  5. 02 Jan, 2011 2 commits
    • Raphael Kubo da Costa's avatar
      Show the number of items directly under a subdirectory. · dc721717
      Raphael Kubo da Costa authored
      The "Size" column in the archive listing now shows the number of
      directories and files directly under a given directory. The info panel
      now shows the same information too.
      Patch by Ghislain Mary <gmary AT lunacymaze DOT org>, thanks a lot!
      FEATURE: 252923
      BUG: 252923
      FIXED-IN: 4.7.0
      svn path=/trunk/KDE/kdeutils/ark/; revision=1210921
    • Laurent Montel's avatar
      Remove not used variable · 4b4594b4
      Laurent Montel authored
      Don't check pointer before remove it
      svn path=/trunk/KDE/kdeutils/ark/; revision=1210910
  6. 31 Aug, 2010 1 commit
    • Raphael Kubo da Costa's avatar
      Fix constness of extractFile() parameters in the header file. · de71d695
      Raphael Kubo da Costa authored
      'options' is a const parameter in archivemodel.cpp, and should be so in
      the header declaration as well.
      This should fix compilation with Sun Studio.
      Patch by tropikhajma AT gmail.com, thanks!
      Forward-port of r1170166.
      CCBUG: 249552
      svn path=/trunk/KDE/kdeutils/ark/; revision=1170167
  7. 13 Apr, 2010 1 commit
    • Raphael Kubo da Costa's avatar
      Clean up Kerfuffle a little. · c24f030a
      Raphael Kubo da Costa authored
      Move BatchExtract to app, as it does not really look like
      library code, but rather application code.
      This, on its turn, made it sometimes necessary to fix some
      forward declarations and also made me optimize some others.
      svn path=/trunk/KDE/kdeutils/ark/; revision=1114210
  8. 27 Jul, 2009 3 commits
  9. 23 Jul, 2009 1 commit
  10. 12 Jun, 2009 1 commit
  11. 09 May, 2009 1 commit
  12. 11 Apr, 2009 1 commit
  13. 02 Apr, 2009 2 commits
  14. 05 Jan, 2009 1 commit
  15. 26 Dec, 2008 1 commit
  16. 18 Oct, 2008 1 commit
  17. 10 Oct, 2008 2 commits
  18. 30 Aug, 2008 1 commit
  19. 21 Aug, 2008 2 commits
  20. 16 Aug, 2008 1 commit
  21. 12 Aug, 2008 1 commit
  22. 10 Aug, 2008 1 commit
  23. 08 Aug, 2008 1 commit
  24. 23 Jul, 2008 1 commit
  25. 29 Mar, 2008 1 commit
  26. 29 Jul, 2007 1 commit
  27. 22 Jul, 2007 1 commit
  28. 21 Jul, 2007 1 commit
  29. 20 Jul, 2007 3 commits
  30. 19 Jul, 2007 2 commits
  31. 18 Jul, 2007 1 commit