1. 01 Jun, 2019 5 commits
  2. 26 May, 2019 1 commit
  3. 19 May, 2019 1 commit
  4. 12 May, 2019 3 commits
  5. 05 May, 2019 1 commit
    • Elvis Angelaccio's avatar
      AddToArchive: fix filename preset for folders · 1ef618e5
      Elvis Angelaccio authored
      We can't use detectFileName() here because we don't have the filename
      suffix yet, so the function would assume the folder filename is also the
      destination filename, appending '_1'.
      
      detectBaseName() is enough for our purpose, which is just to preset a
      filename in the dialog.
      
      BUG: 406812
      FIXED-IN: 19.04.1
      1ef618e5
  6. 04 May, 2019 2 commits
  7. 02 May, 2019 1 commit
  8. 22 Apr, 2019 2 commits
  9. 18 Apr, 2019 1 commit
  10. 17 Apr, 2019 1 commit
  11. 08 Apr, 2019 1 commit
  12. 07 Apr, 2019 1 commit
    • Ragnar Thomsen's avatar
      Handle locked RAR archives · 3a21006f
      Ragnar Thomsen authored
      RAR archives can have a "locked" property essentially making them
      readonly. Currently, Ark doesn't handle this properly and fails silently
      if the user tries to modify the archive (e.g. adding files).
      
      This diff adds a virtual method ReadOnlyArchiveInterface::isLocked()
      with a default implementation returning false. The method is overridden
      by the RAR plugin which checks if the archive is locked when listing.
      ReadWriteArchiveInterface::isReadOnly() checks isLocked() when
      determining the readonly status of the archive.
      
      BUG: 368851
      FIXED-IN: 19.04.0
      Differential Revision: D20122
      3a21006f
  13. 04 Apr, 2019 1 commit
  14. 31 Mar, 2019 1 commit
  15. 27 Mar, 2019 2 commits
    • Ragnar Thomsen's avatar
      Merge branch 'Applications/19.04' · 127224bf
      Ragnar Thomsen authored
      * Applications/19.04:
        Fix progress info for CreateJob
        Improve performance of cliplugins
        GIT_SILENT Upgrade KDE Applications version to 19.03.80.
      127224bf
    • Ragnar Thomsen's avatar
      Fix progress info for CreateJob · ce2f7f66
      Ragnar Thomsen authored
      Progress info is currently broken when creating archives using
      CreateJob. This happens e.g. when the user creates an archive
      through the KFileItemAction in Dolphin.
      This is caused by CreateJob using a nested AddJob and the percent
      signal of the AddJob was not forwarded to CreateJob.
      
      It was encessary to use QOverload since KJob has both a signal and a
      member function called percent.
      
      BUG: 382599
      FIXED-IN: 19.04.0
      Differential Revision: D19953
      ce2f7f66
  16. 20 Mar, 2019 1 commit
    • Ragnar Thomsen's avatar
      Improve performance of cliplugins · 01289d69
      Ragnar Thomsen authored
      The CliPlugins are really slow when listing and extracting archives.
      This is due to several QRegularExpressions being matched on each line of
      output.
      
      This diff removes all of the QRegularExpression matchings and uses
      string comparison instead (e.g. startsWith(), contains() and ==()). This
      necessitated moving some checks from the CliProperties class to the
      individual CliPlugins, because each plugin has different requirements
      for which string comparison methods should be used.
      
      Differential Revision: D19766
      01289d69
  17. 16 Mar, 2019 2 commits
  18. 15 Mar, 2019 1 commit
    • Ragnar Thomsen's avatar
      cli7z: Performance improvements and cleanup · 00d65824
      Ragnar Thomsen authored
      Use string comparison instead of regexp matching where possible. Use
      QLatin1String in startsWith(). Use switch-case instead of if-else.
      
      Also adds a new error pattern to readExtractLine().
      00d65824
  19. 12 Mar, 2019 1 commit
  20. 09 Mar, 2019 1 commit
    • Elvis Angelaccio's avatar
      Fix creation of tar archives · a3bcf9be
      Elvis Angelaccio authored
      Usage of QString::compare() breaks the creation of tar archives, because
      `zst` is "bigger" than `tar` which means ark would use the `zstd` filter
      even when creating a simple tar archive.
      
      BUG: 405136
      FIXED-IN: 19.03.80
      a3bcf9be
  21. 17 Feb, 2019 2 commits
  22. 16 Feb, 2019 1 commit
  23. 11 Feb, 2019 2 commits
  24. 10 Feb, 2019 3 commits
    • Alexander Kernozhitsky's avatar
      Determine isDirectory by "Folder = " field in 7z plugin · ca4667ad
      Alexander Kernozhitsky authored
      Summary:
      After looking at 7zip sources, I've found that there are two types of file attributes:
      
      * FAT/Windows (e. g. "RA", "RDA")
      * Unix (e. g. "_ -rwxr-xr-x" or "D_ drwxr-xr-x")
      
      Earlier, isDirectory property was determined by "Attributes = " field. But this is incorrect, when 7z returns strings like
      
      "Attributes = RDA"
      
      This is a directory, but the code searched for "D" in the beginning and failed. Due to that, the archive couldn't be displayed properly.
      
      I used a more canonical way to determine isDirectory: parsing "Folder = " field in 7z's output. Also reworked handling "Attributes = " field to handle both cases correctly.
      
      Test Plan: Rebuilt ark and tried on some zip archives (also on the archive that ark was unable to display properly). Everything works OK.
      
      Reviewers: elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: elvisangelaccio, kde-utils-devel, #ark
      
      Tags: #ark
      
      Differential Revision: https://phabricator.kde.org/D18562
      ca4667ad
    • Elvis Angelaccio's avatar
      Merge branch 'Applications/18.12' · 6b72fca2
      Elvis Angelaccio authored
      * Applications/18.12:
        cli7ztest: add failing test case for zip folders with RDA attributes
      6b72fca2
    • Elvis Angelaccio's avatar
      cli7ztest: add failing test case for zip folders with RDA attributes · 95bf2244
      Elvis Angelaccio authored
      The following string is currently not parsed by the cli7z plugin:
      
          Attributes = RDA
      
      See summary of https://phabricator.kde.org/D18562 for more details.
      95bf2244
  25. 03 Feb, 2019 1 commit
  26. 29 Jan, 2019 1 commit