1. 10 Jul, 2020 1 commit
  2. 03 Jul, 2020 2 commits
  3. 18 Jun, 2020 2 commits
  4. 17 Jun, 2020 2 commits
  5. 08 Jun, 2020 2 commits
  6. 02 Jun, 2020 1 commit
  7. 11 May, 2020 2 commits
  8. 04 May, 2020 1 commit
    • Ragnar Thomsen's avatar
      libarchive: Improve error-handling when loading archive · b47c5346
      Ragnar Thomsen authored
      Improves error-handling in LibarchivePlugin::list().
      
      Previously we only checked whether we could read until the end of the
      archive, and even if we couldn't there was no error shown to the user.
      Now we check the return value of both archive_read_next_header() and
      archive_read_data_skip(), and show a corrupt archive query if either
      was not successful.
      
      This partially solves bug 411074, as Ark now at least gives a warning
      when opening a corrupt archive with libarchiveplugin. We still need to
      improve error-handling when extracting, but this requires some
      refactoring first so will be done later.
      CCBUG: 411074
      Differential Revision: D29383
      b47c5346
  9. 27 Apr, 2020 1 commit
  10. 15 Apr, 2020 2 commits
  11. 12 Apr, 2020 2 commits
  12. 06 Apr, 2020 2 commits
  13. 04 Apr, 2020 1 commit
  14. 28 Mar, 2020 1 commit
  15. 16 Mar, 2020 1 commit
    • Aleksei Nikiforov's avatar
      libarchive backend: display permissions in octal format · b867a01e
      Aleksei Nikiforov authored
      Summary: Currently when libarchive backend is used to read archive, permissions are displayed in decimal format. But a lot of userspace tools show and use permissions either in text format or in octal number format for convenience, not in a decimal number format.
      
      Test Plan:
      Open an archive which ark uses libarchive for opening. For example, https://github.com/KDE/ark/archive/v19.12.3.tar.gz
      
      For directories permissions should be displayed as '40775' instead of '16893'.
      For non-executable files permissions should be displayed as '100664' instead of '33204'.
      
      Reviewers: #ark, elvisangelaccio
      
      Reviewed By: #ark, elvisangelaccio
      
      Subscribers: kde-utils-devel
      
      Tags: #ark
      
      Differential Revision: https://phabricator.kde.org/D28007
      b867a01e
  16. 15 Mar, 2020 1 commit
  17. 14 Mar, 2020 1 commit
    • Nicolas Fella's avatar
      Lazily load file entry icons · 2c684ecd
      Nicolas Fella authored
      Summary:
      Building the icons datastructure is the most significant bottleneck when opening large archives. Knowing all the icons at loading time is unnecessary since most elements won't be visible anyway.
      This patch moves the icon storing into the Entry class where it is lazily determined the first time it is accessed. This improves the initial archive loading time significantly.
      
      Test Plan: It's hard to give exact numbers, but my main test archive (the Android NDK) went from ~3 seconds to load to "pretty much instant"
      
      Reviewers: #ark, elvisangelaccio
      
      Reviewed By: #ark, elvisangelaccio
      
      Subscribers: broulik, kde-utils-devel
      
      Tags: #ark
      
      Differential Revision: https://phabricator.kde.org/D26357
      2c684ecd
  18. 09 Mar, 2020 1 commit
  19. 03 Mar, 2020 1 commit
  20. 01 Mar, 2020 1 commit
  21. 29 Feb, 2020 1 commit
  22. 27 Feb, 2020 1 commit
  23. 17 Feb, 2020 1 commit
  24. 14 Feb, 2020 1 commit
  25. 12 Feb, 2020 1 commit
  26. 04 Feb, 2020 1 commit
  27. 03 Feb, 2020 1 commit
  28. 02 Feb, 2020 1 commit
  29. 28 Jan, 2020 1 commit
  30. 17 Jan, 2020 1 commit
  31. 10 Jan, 2020 1 commit
  32. 09 Jan, 2020 1 commit