1. 25 Sep, 2020 2 commits
  2. 02 Sep, 2020 1 commit
  3. 26 Aug, 2020 2 commits
    • Ahmad Samir's avatar
      Part: more async KIO jobs · eff5cd0b
      Ahmad Samir authored
      Add comment explaining what extractSelectedFilesTo is used for.
      Slightly tweak error message.
      eff5cd0b
    • Ahmad Samir's avatar
      Part: QFileDialog asks to overwrite a file on its own · 54ba94ec
      Ahmad Samir authored
      - No need to stat the url we get from QFileDialog::getSaveFileUrl, if it
        already exists the dialog should show the "do you want to overwrite?"
        message to the user on its own; also no need to check for isValid, the
        dialog will return valid urls, AFAICS
      - KIO::file_copy will check if the src url exists ...etc, we don't have
        to do that manually; also make the job async, and re-use the custom error
        messages where possible
      54ba94ec
  4. 21 Aug, 2020 1 commit
    • Ahmad Samir's avatar
      Port KRun to OpenUrlJob and ApplicationLauncherJob · c4c765a9
      Ahmad Samir authored
      In BatchExtract, use QUrl::fromLocalFile to construct a url with the
      file:// scheme, so that the destination dir can be opened after the
      extraction is finished.
      
      Bump minimum KF version to 5.71 as that's where OpenUrlJob was introduced.
      c4c765a9
  5. 31 Jul, 2020 1 commit
  6. 18 Jun, 2020 2 commits
  7. 17 Jun, 2020 2 commits
  8. 11 May, 2020 1 commit
  9. 14 Mar, 2020 1 commit
    • Nicolas Fella's avatar
      Lazily load file entry icons · 2c684ecd
      Nicolas Fella authored
      Summary:
      Building the icons datastructure is the most significant bottleneck when opening large archives. Knowing all the icons at loading time is unnecessary since most elements won't be visible anyway.
      This patch moves the icon storing into the Entry class where it is lazily determined the first time it is accessed. This improves the initial archive loading time significantly.
      
      Test Plan: It's hard to give exact numbers, but my main test archive (the Android NDK) went from ~3 seconds to load to "pretty much instant"
      
      Reviewers: #ark, elvisangelaccio
      
      Reviewed By: #ark, elvisangelaccio
      
      Subscribers: broulik, kde-utils-devel
      
      Tags: #ark
      
      Differential Revision: https://phabricator.kde.org/D26357
      2c684ecd
  10. 03 Mar, 2020 1 commit
  11. 02 Jan, 2020 4 commits
    • Nicolas Fella's avatar
      Port away from KIconThemes · c6f81eb5
      Nicolas Fella authored
      Summary:
      IconSize is deprecated.
      
      Using the "Desktop" icon size was somewhat arbitrary. There is no QStyle pixelmetric that offers the same size and fits semantically.
      
      Test Plan: Side panel, properties dialog and extraction dialog look the same
      
      Reviewers: #ark, davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: kde-utils-devel
      
      Tags: #ark
      
      Maniphest Tasks: T11637
      
      Differential Revision: https://phabricator.kde.org/D26370
      c6f81eb5
    • Nicolas Fella's avatar
      Optimize ArchiveModel::cleanFileName · 8e436fad
      Nicolas Fella authored
      Summary: Creating the QRegularExpression is expensive and cleanFileName is called for each entry. By not re-creating the regex we gain a significant archive load time improvement
      
      Test Plan:
      {F7786657}
      
      Left is before, right is after. Note the red block on the left that isn't present on the right
      
      Reviewers: #ark, elvisangelaccio
      
      Reviewed By: #ark, elvisangelaccio
      
      Subscribers: elvisangelaccio, kde-utils-devel
      
      Tags: #ark
      
      Differential Revision: https://phabricator.kde.org/D25565
      8e436fad
    • Nicolas Fella's avatar
      Revert "Optimize ArchiveModel::cleanFileName" · 15c9cc6b
      Nicolas Fella authored
      Landed the wrong branch
      
      This reverts commit b9e0da8c.
      15c9cc6b
    • Nicolas Fella's avatar
      Optimize ArchiveModel::cleanFileName · b9e0da8c
      Nicolas Fella authored
      Summary: Creating the QRegularExpression is expensive and cleanFileName is called for each entry. By not re-creating the regex we gain a significant archive load time improvement
      
      Test Plan:
      {F7786657}
      
      Left is before, right is after. Note the red block on the left that isn't present on the right
      
      Reviewers: #ark, elvisangelaccio
      
      Reviewed By: #ark, elvisangelaccio
      
      Subscribers: elvisangelaccio, kde-utils-devel
      
      Tags: #ark
      
      Differential Revision: https://phabricator.kde.org/D25565
      b9e0da8c
  12. 15 Dec, 2019 1 commit
  13. 03 Dec, 2019 1 commit
  14. 30 Nov, 2019 1 commit
    • Ahmad Samir's avatar
      Replace KRecursiveFilterProxyModel with QSortFilterProxyModel · aee422b0
      Ahmad Samir authored
      Summary:
      KRecursiveFilterProxyModel was only needed to have recursive filtering, which
      became available upstream since Qt 5.10.  Also increate min. required Qt version
      to 5.10.
      
      Test Plan: The code builds, and recursive filtering still works
      
      Reviewers: #ark, elvisangelaccio, apol
      
      Reviewed By: apol
      
      Subscribers: apol, kde-frameworks-devel, kde-utils-devel
      
      Tags: #ark
      
      Maniphest Tasks: T12269
      
      Differential Revision: https://phabricator.kde.org/D25631
      aee422b0
  15. 23 Nov, 2019 1 commit
  16. 18 Nov, 2019 1 commit
    • Nicolas Fella's avatar
      Don't covert icons to pixmaps multiple times · 81828188
      Nicolas Fella authored
      Summary: We don't need to convert the icon which is loaded by name to a pixmap here. The conversion happens later in the DecorationRole data() call.
      
      Test Plan:
      Open archive. Icons in the file list appear and are properly sized.
      Trigger overwrite dialog. Icons appear and are properly sized.
      
      Verified performance improvement with hotspot (see highlighted entries)
      
      before:
      {F7770370}
      
      after:
      {F7770371}
      
      Reviewers: #ark, elvisangelaccio
      
      Reviewed By: #ark, elvisangelaccio
      
      Subscribers: elvisangelaccio, kde-utils-devel
      
      Tags: #ark
      
      Differential Revision: https://phabricator.kde.org/D25377
      81828188
  17. 20 Oct, 2019 3 commits
  18. 13 Oct, 2019 1 commit
  19. 30 Sep, 2019 1 commit
    • Nate Graham's avatar
      Improve consistency of settings window sidebar categories' text and icons · 2a772e69
      Nate Graham authored
      Summary:
      This is in support of the initiative to make settings' window sidebar categories
      consistent throughout KDE software by doing the following:
      - Remove the word "Settings" from the category names (this is implicit, and not done in other KDE software)
      - Use the app's own icon for the General category
      - Use all colorful icons
      
      Test Plan:
      Before: {F7449535}
      After: {F7449536}
      
      Reviewers: #vdg, #ark, elvisangelaccio
      
      Reviewed By: #ark, elvisangelaccio
      
      Subscribers: kde-utils-devel
      
      Tags: #ark
      
      Maniphest Tasks: T10165
      
      Differential Revision: https://phabricator.kde.org/D24270
      2a772e69
  20. 24 Sep, 2019 1 commit
  21. 04 Sep, 2019 1 commit
  22. 24 Aug, 2019 1 commit
  23. 28 Jul, 2019 1 commit
    • Natsumi Higa's avatar
      Display BLAKE2 file checksums for RAR files · afdf8f26
      Natsumi Higa authored
      Summary: When creating a RAR 5.0 archive, BLAKE2sp can be used instead of CRC32 for file checksums. This diff adds an entry for BLAKE2 file checksum.
      
      Test Plan:
      Attached is a RAR 5.0 archive using BLAKE2sp file checksums.
      
      {F6875541}
      
      Reviewers: #ark, elvisangelaccio
      
      Subscribers: #ark, kde-utils-devel
      
      Tags: #ark
      
      Differential Revision: https://phabricator.kde.org/D21637
      afdf8f26
  24. 16 Jul, 2019 1 commit
  25. 19 Jun, 2019 1 commit
  26. 03 Jun, 2019 1 commit
  27. 02 Jun, 2019 2 commits
  28. 01 Jun, 2019 1 commit
  29. 12 May, 2019 1 commit
    • Ragnar Thomsen's avatar
      Get columns to show from first file entry · 3ad7526b
      Ragnar Thomsen authored
      Currently, we use the first entry in an archive to determine which
      columns to show. If the first entry happens to be a directory, then all
      relevant columns might not be shown.
      
      Make sure we always check the first file entry for columns to
      show.
      
      BUG: 406135
      FIXED-IN: 19.04.2
      Differential Revision: D20683
      3ad7526b
  30. 15 Jan, 2019 1 commit
    • David Faure's avatar
      Remember part URL to delete the tempfile even if the user used save as. · d412ca62
      David Faure authored
      Summary:
      Using the part URL at closing time is really dangerous: if the user used
      "save as" (e.g. for an embedded PDF), we'll be deleting the file that
      the user just saved!!
      
      BUG: 402529
      
      Test Plan:
      launch ARK and open a ZIP file containing a PDF, click on the PDF,
      an embedded viewer appears. From there, use "Save As..." to save the PDF
      somewhere on your local disk. Close the embedded viewer, close ark.
      It doesn't delete the saved file anymore.
      
      Reviewers: elvisangelaccio, broulik
      
      Reviewed By: elvisangelaccio
      
      Subscribers: kde-utils-devel, #ark
      
      Tags: #ark
      
      Differential Revision: https://phabricator.kde.org/D18256
      d412ca62