1. 08 Aug, 2020 2 commits
  2. 06 Aug, 2020 3 commits
  3. 02 Aug, 2020 1 commit
  4. 27 Jul, 2020 2 commits
    • Johannes Zarl-Zierl's avatar
      Fix inconsistencies when changing color schemes. · b29f33a7
      Johannes Zarl-Zierl authored
      Instead of changing the palette of a widget, it is often possible to
      change the foreground and/or background role to use different colors of
      the standard palette. This way, changes in the palette can propagete to
      the widget without additional work.
      
      When this is not an option, the widget needs to react to palette changes
      explicitly and (re-)adjust the palette accordingly.
      
      UI changes: The exif grid now uses regular highlight colors instead of
      hardcoded bright red.
      
      A very big thank you to David Redondo for helping me get a better
      understanding of the palette system and for pointing out how to avoid
      breaking palette propagation!
      b29f33a7
    • Johannes Zarl-Zierl's avatar
      Fix incorrect colors after changing color schemes. · 30629fd4
      Johannes Zarl-Zierl authored
      Implementing global stylesheets (04a3d5e8) had the side-effect that font
      and style propagation of qwidgets was no longer active. Unfortunately,
      since this work was done after the work on color schemes, I did not
      catch this immediately.
      
      Thanks to David Redondo for pointing me into the right direction!
      30629fd4
  5. 26 Jul, 2020 5 commits
  6. 25 Jul, 2020 5 commits
  7. 24 Jul, 2020 3 commits
    • Johannes Zarl-Zierl's avatar
      Fix warning on launch from QCommandLineParser · c95a44a3
      Johannes Zarl-Zierl authored
      This fixes the following warnings when starting kphotoalbum:
      QCommandLineParser: already having an option named "h"
      QCommandLineParser: already having an option named "help-all"
      QCommandLineParser: already having an option named "v"
      
      These options are already added by KAboutData::setupCommandLine().
      c95a44a3
    • Johannes Zarl-Zierl's avatar
      Fix bugfix in commit ac5370fb · 717d69a6
      Johannes Zarl-Zierl authored
      Fix regression introduced by d34534b5.
      Implementing a format string conversion for "%0X" correctly and in a
      backwards compatible mode has proven to be harder than I thought.
      So I opted to replace the deprecated QString::sprintf() with
      QString::asprintf(), which is not recommended for new code but not
      deprecated either.
      
      Note: if you ever reimplement this, check the following characters for
      compatibility:
      
       " " -> "_.20"
       "%" -> "_.25"
       "&" -> "_.26"
       "ä" -> "_.FFFFFFE4"
       "ö" -> "_.FFFFFFF6"
       "ü" -> "_.FFFFFFFC"
       "⌘" -> "_.0" //note: this is incorrect behaviour
       "\uD83D" -> "_.0" //note: this is incorrect behaviour
       "\uDE03" -> "_.0" //note: this is incorrect behaviour
      
      The incorrectly escaped characters won't be a problem immediately,
      because the attribute will be correctly mapped to the right category.
      This just means that all of the last three example characters will be
      mapped to the same string, leading to possible ambiguities.
      717d69a6
    • Johannes Zarl-Zierl's avatar
      Adjust result of testcase old-index.xml/v2.2 · 6de35fc2
      Johannes Zarl-Zierl authored
      See ab47cb0b for details
      6de35fc2
  8. 22 Jul, 2020 5 commits
  9. 21 Jul, 2020 1 commit
    • Johannes Zarl-Zierl's avatar
      Start fixing test failures introduced by 185b1344 · 586fc3e5
      Johannes Zarl-Zierl authored
      When I fixed the MD5 sums in the demo database in April, I didn't pay
      attention to the consequences for the integration tests that this would
      cause.
      Mainly, the MD5 sums also need to be fixed in all test cases. This is
      done in this commit.
      Additionally, the fixup in April introduces some errors into the demo
      database: angle="x" was removed erraneously even where x != 0 (this is
      also fixed by this commit), and timestamps were changed incorrectly.
      This is also fixed.
      
      At this point, though, only 1/8 tests succeeds - more investigation is
      needed.
      586fc3e5
  10. 17 Jul, 2020 1 commit
  11. 16 Jul, 2020 2 commits
  12. 11 Jul, 2020 9 commits
  13. 10 Jul, 2020 1 commit