Skip to content
  • Dileep Sankhla's avatar
    Store all annotation color attributes as ARGB string · d61cef69
    Dileep Sankhla authored and Tobias Deiminger's avatar Tobias Deiminger committed
    Summary:
    This is mainly preparation for D15204 (typewriter), where storing RGB won't be sufficient any longer.
    Typewriter will need transparent background (alpha=0x00), which can only be expressed as ARGB string.
    
    Current code handles name format identical for all annotations. It doesn't hurt to store all annotations in ARGB format, so instead of introducing special handling for typewriter, let's store all annotation color attributes as ARGB string.
    
    Note: In case of previously existing okularpartrc, configuration will be reused without conversion. New color format will be written when new settings are saved. This has no bad effect.
    
    Test Plan:
    - when [Reviews] section in okularpartrc is initially generated, all annotation color attributes are in #AARRGGBB format
    - saving into archive stores color with alpha channel (#AARRGGBB), for all kind of annotations
    
    Reviewers: sander
    
    Reviewed By: sander
    
    Subscribers: dileepsankhla, sander, okular-devel
    
    Tags: #okular
    
    Differential Revision: https://phabricator.kde.org/D15279
    d61cef69