1. 01 Oct, 2017 4 commits
    • Albert Freeman's avatar
      Custom background color · 1f6e8a47
      Albert Freeman authored
      Summary:
      BUG: 182994
      
      Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).
      
      Reasons for this change:
      Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
      Many people want this change occording to Bugzilla and other sources.
      
      Maintenance: Nearly no additional maintenance:
      This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
      
      {F4257766}
      
      Other less important information:
      https://git.reviewboard.kde.org/r/130219/
      https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html
      
      Test Plan:
      Tested everything, it all works:
      Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).
      
      Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: aacid, ltoscano, ngraham
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D8051
      1f6e8a47
    • Luigi Toscano's avatar
      Revert "Custom background color" · d176914e
      Luigi Toscano authored
      Wrong authorship for the commit. Commit it again with the correct
      information.
      
      CCMAIL: pointedstick@zoho.com
      This reverts commit 6b5a7c9a.
      d176914e
    • Nathaniel Graham's avatar
      Custom background color · 6b5a7c9a
      Nathaniel Graham authored
      Summary:
      BUG: 182994
      
      Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).
      
      Reasons for this change:
      Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
      Many people want this change occording to Bugzilla and other sources.
      
      Maintenance: Nearly no additional maintenance:
      This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
      
      {F4257766}
      
      Other less important information:
      https://git.reviewboard.kde.org/r/130219/
      https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html
      
      Test Plan:
      Tested everything, it all works:
      Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).
      
      Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: aacid, ltoscano, ngraham
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D8051
      6b5a7c9a
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · 24b48165
      Script Kiddy authored
      24b48165
  2. 29 Sep, 2017 2 commits
  3. 27 Sep, 2017 1 commit
  4. 26 Sep, 2017 4 commits
  5. 25 Sep, 2017 2 commits
  6. 22 Sep, 2017 3 commits
  7. 21 Sep, 2017 1 commit
  8. 20 Sep, 2017 2 commits
  9. 19 Sep, 2017 1 commit
  10. 18 Sep, 2017 2 commits
  11. 17 Sep, 2017 1 commit
    • Albert Astals Cid's avatar
      Show dialog to ask when closing when more than tab open · 95a32d77
      Albert Astals Cid authored
      Summary:
      The checkbox is checked and says "Warn me on closing more than one tab",
      for that reason we can't use the default KMessageBox::questionYesNo since
      there the checkbox is always not checked and it's when checked that you enable it
      
      Inspired by code from torham zed torhamzed@yahoo.com at review request 126406
      
      Reviewers: #okular, #kde_applications
      
      Subscribers: alexeymin, ngraham, colomar, rkflx, #okular
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D7714
      95a32d77
  12. 16 Sep, 2017 3 commits
  13. 13 Sep, 2017 3 commits
  14. 12 Sep, 2017 4 commits
    • Gilbert Assaf's avatar
      99be29e5
    • Henrik Fehlauer's avatar
      Update to synctex 1.19 · bd20e48c
      Henrik Fehlauer authored
      Summary:
      This should prevent crashes when reloading some synctex-enabled pdf
      files created with newer versions of TeXLive. We also gain bugfixes,
      features and improved accuracy from the last 6 years of synctex
      development.
      
      Procedure followed:
      - svn co svn://tug.org/texlive/trunk/Build/source/texk/web2c/synctexdir
      - Check out revision 45150
      - Update files present in core/synctex/*
      - Adapt Okular code to changes
      - Review and drop or update/apply old patches using quilt
      - Create missing patches for local synctex changes
      - New patch: Omit warning message when opening non-synctex pdf
      - Two new patches to fix more compiler warnings
      - New patch: Plug multiple leaks and prevent a segfault
      
      TODO for later:
      - Move sync file detection code to Okular to never call into synctex C code for non-synctex files
      - Evaluate feasibility of upstreaming all patches for TeXLive 2018 and using synctex as a library
      
      BUG: 383915
      FIXED-IN: 17.12.0
      
      Test Plan:
      - No crash in synctex on reloading empty.pdf from bugreport anymore.
      - Shift-clicking on a word in a simple pdf opens Kate with the corresponding tex line.
      - Forward and backward search in Kile seems to work.
      - Works with synctex files from both TeXLive 2015 and 2017.
      - PartTest::testForwardPDF still passes.
      - No additional memory leaks in autotests and with basic synctex and non-synctex usage of Okular.
      
      Reviewers: #okular, sander, #kile, aacid
      
      Reviewed By: #okular, aacid
      
      Subscribers: mludwig, aacid
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D7594
      bd20e48c
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 9d406705
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      9d406705
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · 193ecf76
      Script Kiddy authored
      193ecf76
  15. 11 Sep, 2017 4 commits
  16. 07 Sep, 2017 3 commits
    • Julian Wolff's avatar
      Fix automatic reload of files saved with QSaveFile · bedc3dbe
      Julian Wolff authored
      Summary:
      Files saved with QSaveFile don't get dirty. They are deleted and replaced.
      Thus, inotify and KDirWatch don't emit a "dirty" signal (which is the correct behaviour).
      Listening for the "created" signal of KDirWatch allows us to get notified on replaced files.
      
      BUG: 384185
      
      Test Plan:
      Opened a markdown document in Okular.
      Edited and saved the document with Kate.
      The file is reloaded in Okular as expected.
      
      Reviewers: aacid
      
      Reviewed By: aacid
      
      Subscribers: sander, rkflx, #okular
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D7671
      bedc3dbe
    • Julian Wolff's avatar
      Fix automatic reload of files saved with QSaveFile · e3747ca3
      Julian Wolff authored
      Summary:
      Files saved with QSaveFile don't get dirty. They are deleted and replaced.
      Thus, inotify and KDirWatch don't emit a "dirty" signal (which is the correct behaviour).
      Listening for the "created" signal of KDirWatch allows us to get notified on replaced files.
      
      BUG: 384185
      
      Test Plan:
      Opened a markdown document in Okular.
      Edited and saved the document with Kate.
      The file is reloaded in Okular as expected.
      
      Reviewers: aacid
      
      Reviewed By: aacid
      
      Subscribers: sander, rkflx, #okular
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D7671
      e3747ca3
    • Oliver Sander's avatar
      Implement rasterized printing with QPrinter with hidden annotations · 5a716e06
      Oliver Sander authored
      Previously, rasterized printing would use the QPrinter backend whenever
      annotations were to be printed, and fall back to the convert-to-ps
      toolchain otherwise.  Effectively, this meant that printing on
      windows without showing the annotations was not possible (because
      on windows only the QPrinter can be used for printing).
      
      Starting with poppler 0.60, there is a way to disable annotation
      rendering for the renderToImage and renderToPainter methods that
      are used by QPrinter.  This patch makes use of this new option,
      making printing on windows without annotations possible.
      
      Differential Revision: https://phabricator.kde.org/D7688
      5a716e06