GitLab

BUG: 313177
FIXED-IN: 4.11.0

See patch 0006 in
http://lists.freedesktop.org/archives/poppler/2013-April/010214.html

CCBUG: 313177

Sometimes annotations created on tiles mode were not shown immediately.

What requestPixmaps do is given a PixmapRequest, change its
normalizedRect attribute so the rect is tile aligned. However
refreshPixmaps was creating a PixmapRequest with the rect already tile
aligned and then delivering the PixmapRequest to requestPixmaps, which
would trye to take the requested rectangle and change it so it is also
tile aligned. Since the PixmapRequest delivered by refreshPixmaps was
already aligned, the requested rectangle was inflated by the tile
alignment procedure. After that the generated request becomes bigger
than the defined threshold and is discarded. This patch actually
removes the tile alignment logic from refreshPixmaps and let only the
requestPixmaps handle this.

REVIEW: 109633

updateCursor changes by Albert

Albert forgot to commit it

REVIEW: 109627

Conflicts:
	core/document.cpp

BUG: 318048
FIXED-IN: 4.10.5

The issue can be reproduced by zooming a rotated document to 1600% then
back to 800%

REVIEW: 110905

Conflicts:
	VERSION
	core/version.h
	part.cpp

Additional bits of documentation proposed by Burkhard Lueck

So that next time slotDoFileDirty() is called, it will save data again, instead
of keeping data from the old reload attempt.

Because if it hasn't been saved (54b4a20e)
this results in m_model == 0, which makes us crash.

This would have caught the crash I'm going to fix in the next patch

This would have caught the issue fixed in 3dd3a000

Generators can query the font via generalSettings()->font()

Which is now useless because with the previous patch
TextDocumentGenerator no longer caches the widget.

Together with the already commited support for undo in annotations fixes 177501
BUGS: 177501
REVIEW: 110589
FIXED-IN: 4.11.0

Signed-off-by: Yuri Chornoivan <yurchor@ukr.net>

Because a cached dialog stays parented to the initial part, which might
not be the one used to open it.
This is especially visible now that we support more than one window per
okular process.

For example:
 - User initially opens a dialog from window A
      -> This dialog gets cached as child of A's PageView. This implies that
         clicking on the dialog also brings window A to foreground.
 - User re-opens the dialog from a different window B
      -> The dialog is still a child of A's PageView, therefore clicking on the
         dialog's frame brings A to the foreground, and B to the background.

Instead of listening on KConfigDialog's signals, this patch makes parts
listen on Okular::Settings::self()'s configChanged() signal.

Unlike KConfigDialogs, Okular::Settings::self() is unique and never
changes during the process lifetime, and therefore:
 - A part can connect during initialization and receive notifications,
   without depeding on KConfigDialog objects (which might be instanced
   or deleted by a different part).
 - The connection now survives deletion of the KConfigDialog.

Instead of using a hardcoded map
BUGS: 320195
FIXED-IN: 4.10.4

Instead of using a hardcoded map
BUGS: 320195
FIXED-IN: 4.10.4