1. 08 May, 2018 1 commit
  2. 06 May, 2018 1 commit
  3. 02 May, 2018 1 commit
  4. 01 May, 2018 1 commit
  5. 23 Apr, 2018 2 commits
    • Albert Astals Cid's avatar
      Use toLocal8Bit instead of toUtf8 · 991eb0ed
      Albert Astals Cid authored
      It's the most "proper" way to do it, i guess in real world scenarios it
      doesn't really matter though
      991eb0ed
    • Chinmoy Ranjan Pradhan's avatar
      Obey umask rules when saving new file · c5592689
      Chinmoy Ranjan Pradhan authored
      Summary:
      Okular saves a new file with permissions 0600 completely ignoring the umask value. This is because it
      makes use of QTemporaryFile which creates file with the said permissions and which then Okular copies
      to the new location.
      So to overcome this generate new file permissions using old mask value and change permissions of the
      new file.
      
      BUG: 392682
      
      Test Plan:
      Set umask to 0040
      Open a pdf file from the same shell and save it under a new name.
      Before patch:
      file permisions -> 0600
      After patch:
      file permisions -> 0606
      
      Reviewers: #okular, aacid
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D12049
      c5592689
  6. 22 Apr, 2018 1 commit
  7. 16 Apr, 2018 1 commit
    • Ahmad Osama's avatar
      [Okular] Bug 387282: Highlighting of search results lost when rotating page · 6a2ed4f3
      Ahmad Osama authored
      Summary:
      The highlights were removed when rotating the page, also the RotaionJob::rotationMatrix function was not rotating the Highlihgts correctly.
      I removed the deletion and modified the rotaionMatrix function by making it shorter and adding a translation after the rotatin. I tried different rotations and they are working fine.
      BUG: 387282
      
      Reviewers: #okular
      
      Subscribers: aacid, ngraham, #okular
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D11901
      6a2ed4f3
  8. 12 Apr, 2018 1 commit
  9. 11 Apr, 2018 1 commit
  10. 09 Apr, 2018 3 commits
  11. 08 Apr, 2018 2 commits
  12. 06 Apr, 2018 2 commits
    • Fabian Kosmale's avatar
      use correct filepath · c70485cd
      Fabian Kosmale authored
      Summary:
      Seems like someone forgot to consistently apply a change. Maybe the path
      construction should be factored into a reusable lambda?
      
      Test Plan:
      Open Okular, open settings > configure Okular. Without the patch, you'll get a
      "QFSFileEngine::open: No file name specified" warning, with the patch it
      disappears. Note that there is also an unrelated "Illegal icon group:  7"
      warning from KIconThemes, but I'm 99% certain that this is on KIconThemes doing
      a bogus check in KIconEffect::apply, not on Okular
      
      Reviewers: #okular, hetzenecker, aacid
      
      Reviewed By: #okular, aacid
      
      Subscribers: aacid, #okular
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D12001
      c70485cd
    • Albert Astals Cid's avatar
      Cancel request when removing an observer · d3c89a15
      Albert Astals Cid authored
      There's no need to continue generating something that won't be useful.
      Also fixes a crash if the request would report partial updates since at that stage it uses the observer and that is gone
      d3c89a15
  13. 02 Apr, 2018 3 commits
    • Albert Astals Cid's avatar
      Fix Presentation Mode VideoWidget sizing · 09109dd6
      Albert Astals Cid authored
      This fix smells a lot like a workaround for a bug in Qt but i could not
      write down a sufficiently small testcase for it to report it to Qt, and
      this is not wrong anyway since we eventually add playerPage to a
      layout for this. What I tracked down was that since playerPage had no
      parent, at some point a nativeId for it was being created and that
      broke sizing back to the default 100x30 used in Qt instead of the
      size we had given it.
      
      For some reason i needed a PDF file with more than one video to
      reproduce this problem, the first video was correctly sized but the
      second one was 100x30.
      09109dd6
    • Christoph Feck's avatar
    • Albert Astals Cid's avatar
      Fix crash when changing pages fast on presentation mode · 21f2c910
      Albert Astals Cid authored
      The crash would happen because we were setting partial updates to true on requests
      that were synchronous, because that sync request was cancelling an async one (prerender)
      so now we only set newRequest partial updates to true when cancellingm another one if it's asynchronous
      
      And a sync but with partial updates request would make stuff crash because the request
      would all be processed on the main thread but generator_pdf.cpp cakks signalPartialPixmapRequest
      with a queued connection so we that function was called the request would have already gone
      21f2c910
  14. 20 Mar, 2018 8 commits
  15. 19 Mar, 2018 1 commit
  16. 13 Mar, 2018 1 commit
  17. 03 Mar, 2018 2 commits
    • Yuri Chornoivan's avatar
    • Dileep Sankhla's avatar
      Option to exit after printing · 09b7b079
      Dileep Sankhla authored
      Summary:
      When running okular with the parameter --print to directly open the print mode, it doesn't exit after acknowledging the print dialog. Hence adding --print_and_exit option exits Okular after acknowledging the print dialog and thus is useful for the command line batch processing or a Dolphin service as the issue suggests.
      
      FEATURE: 318998
      
      Test Plan:
      1. open a file in Okular using the parameter --print. It will open Okular in print mode with the print dialog
      2. Either print the file or cancel the print dialog
      3. You will find that Okular stays open
      4. Now using this patch, see for available options with the --help parameter. You will find --print_and_exit option
      5. Now open a file in Okular using the parameter --print_and_exit. It will open Okular in print mode with the print dialog
      6. Either print the file or cancel the print dialog
      7. You will find that Okular closes after acknowledging the dialog
      
      Reviewers: aacid, #okular, ngraham
      
      Subscribers: ltoscano, ngraham, aacid, #okular
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D10249
      09b7b079
  18. 26 Feb, 2018 1 commit
  19. 25 Feb, 2018 7 commits