1. 29 Aug, 2012 1 commit
  2. 27 Aug, 2012 1 commit
  3. 22 Aug, 2012 1 commit
  4. 18 Aug, 2012 1 commit
    • Albert Astals Cid's avatar
      Close the url on shell destruction · d41f00e4
      Albert Astals Cid authored
      Otherwise we end up in a busy loop on part deletion if there are pending requests
      Should not happen but if this fixes it don't see the need to lose time investigating
      why given the number of todo things
  5. 12 Aug, 2012 1 commit
    • Albert Astals Cid's avatar
      Do not delete the Part on the Shell destructor · 4eee1f34
      Albert Astals Cid authored
      The machinery in KParts/QObject is already doing it and this way we don't get the
      KXMLGUIClient::~KXMLGUIClient: 0x15637528 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.
      I'm not sure if calling this a kdelibs bug yet or not though :D
      BUGS: 261538
      FIXED-IN: 4.9.1
  6. 08 Aug, 2012 1 commit
  7. 07 Aug, 2012 1 commit
  8. 25 Jul, 2012 2 commits
  9. 19 Jul, 2012 1 commit
  10. 17 Jul, 2012 1 commit
    • Fabio D'Urso's avatar
      Call Generator::signalPixmapRequestDone _after_ saving the calculated bounding box · edbb4ef9
      Fabio D'Urso authored
      Fixes a bug that causes the extraction of a wrong bounding box:
      If the request queue is not empty, signalPixmapRequestDone causes a new
      pixmap request to be started, thus overwriting mPixmapGenerationThread's
      mCalcBoundingBox before it is read by the if in the next line.
      Now signalPixmapRequestDone is called after the bounding box is saved,
      so that new requests are started only after all data from
      mPixmapGenerationThread have been saved.
      BUG: 257370
      REVIEW: 105600
  11. 15 Jul, 2012 1 commit
    • Luigi Toscano's avatar
      Avoid crash when the font is broken. · bd733dab
      Luigi Toscano authored
      The call to FT_New_Face takes the address of the 'face' variable, whose type is a
      typedef *something TF_Face;
      The value of TF_Face (so a pointer to the properly filled font structure) s then
      replaced inside the call of TF_New_Face; but when the latter function fails,
      the value of 'face' is not reset and this leads to a crash in the distructor of
      So properly initialize TF_Face to 0, its address is valid, and the code works.
      BUG: 303472
      FIXED-IN: 4.8.5
      (cherry picked from commit 99c4da2f)
  12. 12 Jul, 2012 4 commits
  13. 11 Jul, 2012 4 commits
  14. 09 Jul, 2012 6 commits
  15. 06 Jul, 2012 1 commit
  16. 03 Jul, 2012 1 commit
  17. 02 Jul, 2012 2 commits
  18. 27 Jun, 2012 1 commit
  19. 25 Jun, 2012 1 commit
  20. 24 Jun, 2012 5 commits
  21. 21 Jun, 2012 1 commit
  22. 19 Jun, 2012 2 commits
    • Albert Astals Cid's avatar
      Fix underflow in getFreeMemory() · 444e6b7b
      Albert Astals Cid authored
      It actually serves three purposes:
      a) Make sure all the values are there (this should be always true, but doesn't hurt making sure) because if SwapFree was there but SwapTotal was not, it'd be a mess
      b) add up things in order so we don't underflow, currently the code did process stuff as it came in the file, and it happens that SwapTotal appears before SwapFree in /proc/meminfo so it actually did  "MemFree:" + "Buffers:" + "Cached:" - "SwapTotal:" + "SwapFree:", which can underflow if "MemFree:" + "Buffers:" + "Cached:" < "SwapTotal:"
      c) Do not underflow at all, so if  "MemFree:" + "Buffers:" + "Cached:" +  "SwapFree:" < "SwapTotal:" we return 0 correctly not a zillion of free memory
      Aurélien you might want to update gwenviews copy of this code (there's a few other bugfixes we did a while ago you didn't update either)
      CCMAIL: agateau@kde.org
      BUGS: 291129
    • Albert Astals Cid's avatar
      Fix spacing · 791a4ac3
      Albert Astals Cid authored