1. 03 Jun, 2019 1 commit
  2. 02 Jun, 2019 1 commit
  3. 01 Jun, 2019 2 commits
    • Tobias Deiminger's avatar
      Add icons for line annotation arrow styles to combo box · 1b89f220
      Tobias Deiminger authored
      Summary:
      Use `LineAnnotPainter` to generate accurate icons.
      
      Looks like this:
      {F6852054}
      
      Depends on D21248
      
      Test Plan:
      - open "Edit annotation tool" for straight line and check combo box items for start and stop style
      - test on HiDPI
      
      Reviewers: #okular, sander
      
      Reviewed By: sander
      
      Subscribers: davidhurka, knambiar, ngraham, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21416
      1b89f220
    • Tobias Deiminger's avatar
      Add line annotation ending arrows for non PDF documents · d0e3a77d
      Tobias Deiminger authored
      Summary:
      This implements drawing the various line ending styles for 2 point lines in non-PDF documents.
      
      Looks like this:
      {F6833437}
      
      CCBUG: 381629
      
      Test Plan:
      - open a *.txt document
      - draw line annotations with different arrow styles: Square, Diamond, OpenArrow, ClosedArrow, ROpenArrow, RClosedArrow, Butt, Slash, Circle
      - ... as start and as end style (start needs D21238 to be configurable in GUI)
      - ... filled or not (fill color can't be configured in GUI yet)
      - ... with different leader line settings
      - ... at various angles
      - rotate and scale page
      - leader line with setting 100 gives 100 pixel line at 100% zoom (use kruler to verify)
      
      Reviewers: #okular, aacid, sander
      
      Reviewed By: sander
      
      Subscribers: ngraham, sander, knambiar, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21248
      d0e3a77d
  4. 27 May, 2019 3 commits
  5. 26 May, 2019 1 commit
    • Rajeesh K V's avatar
      Okular Annotation: add line start/end style config only for Straight Line tool · b1c30cd0
      Rajeesh K V authored
      Summary:
      “Inner Color” configuration of Polygon tool was overlapping with the line start/end styles intended for only Straight Line tool. Fix it.
      
      CCBUG: 381629
      
      Test Plan:
      1. Configure annotations
      2. Create/Edit Polygon tool
      3. Observe that no Line Start/End styles are visible
      4. Create/Edit Straight Line tool
      5. Observe that line start/end styles can be configured
      
      Reviewers: #okular, tobiasdeiminger
      
      Reviewed By: tobiasdeiminger
      
      Subscribers: tobiasdeiminger, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21332
      b1c30cd0
  6. 22 May, 2019 10 commits
  7. 21 May, 2019 1 commit
    • Kezi Olio's avatar
      Make selection scrolling go at 60 fps · e971c67c
      Kezi Olio authored
      Summary:
      When you select a square with the right mouse button, and you go past the margin of the window (but where there is still space to go), okular scrolls the document so you can select more.
      With this patch this automatic scrolling goes at 60 fps instead of 10, I made it so that the speed of the scroll is the same
      
      Reviewers: #okular, aacid, sander, ngraham
      
      Reviewed By: sander, ngraham
      
      Subscribers: sander, ngraham, aacid, ahmedbilal, okular-devel, kezik
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D20437
      e971c67c
  8. 19 May, 2019 1 commit
    • Rajeesh K V's avatar
      Okular Annotation: add support for line start style for Straight Line tool · 59a86c3f
      Rajeesh K V authored
      Summary: Similar to the line ending style, add support for line start style for the Straight Line annotation tool
      
      Test Plan:
      1. Go to Configure annotations
      2. Create (or edit existing) Straight Line tool
      3. Set the ‘Line Start’ option on Style and Apply
      4. Use the Straight Line tool to draw a line and check the line starting style.
      
      Reviewers: #okular, tobiasdeiminger
      
      Reviewed By: tobiasdeiminger
      
      Subscribers: ngraham, tobiasdeiminger, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21238
      59a86c3f
  9. 14 May, 2019 2 commits
    • Tobias Deiminger's avatar
    • Tobias Deiminger's avatar
      Fix line annotation leader line angle · a0045a97
      Tobias Deiminger authored
      Summary:
      For "Straight Line" annotations, the "Leader Lines" (if any) shall be perpendicular to the main line segment. Current code missed to consider page aspect ratio when calculating the main segment angle, which caused non-perpendicular leader lines.
      
      Note: Bug is only visible with non-PDF documents (i.e. where Okular draws line annotation, instead of generator).
      
      Before:
      {F6818453}
      
      After:
      {F6818452}
      
      Test Plan:
      - open a txt file, the generated page will have aspect ratio 3:4
      - configure a "Straight Line" annotation with long leader line
      - create a line annotation at 45 degree angle
      - check the leader line, it shall be perpendicular to the main line
      
      Reviewers: sander
      
      Reviewed By: sander
      
      Subscribers: aacid, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21136
      a0045a97
  10. 12 May, 2019 1 commit
  11. 11 May, 2019 2 commits
  12. 09 May, 2019 1 commit
  13. 08 May, 2019 1 commit
  14. 07 May, 2019 1 commit
    • Rajeesh K V's avatar
      Okular Annotation: add support for line ending style for Straight Line tool · db2dcdad
      Rajeesh K V authored
      Summary:
      Poppler and Okular already have support for specifying Line End style (`TermStyle`) for the Straight Line tool. Expose the functionality in configuration and hook up the correct slots.
      
      Configure annotations (before):
      {F6788150}
      
      Configure annotations (after):
      {F6788151}
      
      Straight Line tool with Open Arrow end in action:
      {F6788153}
      
      Test Plan:
      1. Open a PDF in Okular
      2. Enable Review
      3. Right click on Review toolbar and Configure annotations
      4. Create (or edit existing) Straight Line tool
      5. Set the ‘Line End’ option on Style and Apply
      6. Use the Straight Line tool to draw a line and check the line ending style.
      
      Reviewers: #okular, #vdg, sander, ngraham
      
      Reviewed By: #vdg, sander, ngraham
      
      Subscribers: pino, sander, davidhurka, tobiasdeiminger, ngraham, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D20760
      db2dcdad
  15. 02 May, 2019 3 commits
  16. 30 Apr, 2019 1 commit
  17. 22 Apr, 2019 2 commits
  18. 21 Apr, 2019 1 commit
    • Shubham  .'s avatar
      Add action in Edit menu to select the text on current page · f788b5a3
      Shubham . authored
      BUG: 358868
      
      Test Plan: Click on "Select All Text on Current Page" entry in Edit menu to select the entire page. The selected text can then be copied via Edit menu item "Copy"
      
      Reviewers: aacid, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel
      
      Tags: #okular, #documentation
      
      Differential Revision: https://phabricator.kde.org/D18744
      f788b5a3
  19. 20 Apr, 2019 2 commits
  20. 15 Apr, 2019 1 commit
    • Michael Weghorn's avatar
      PDF: Implement scaling options for non-rasterized printing · 748884b4
      Michael Weghorn authored
      Summary:
      This adds another 'FilePrinter::printFile' method that
      accepts an additional parameter to specify whether or not to
      do scaling and passes the 'fit-to-page' to CUPS dependent
      on what is specified.
      
      If FilePrinter is used, The PDF generator now passes this
      option depending on the scaling mode that was selected in the
      custom print options widget, which is therefore now enabled
      for non-rasterized printing as well.
      
      Test Plan:
      1) open a PDF document in Okular and open the print dialog
      2) go to the "PDF Options" tab
      3) verify that "Force rasterisation" is disabled, but the
        "Scale mode" combobox is active.
      4) test all the three options available in the "Scale mode"
         combobox do what they say
      5) Make sure the three options still work as expected for
         the "Force rasterisation" case.
      
      Reviewers: #okular, ngraham, sander
      
      Reviewed By: ngraham
      
      Subscribers: aacid, fvogt, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D18179
      748884b4
  21. 12 Apr, 2019 2 commits