Summary:
- Correct QQC2 import
- Apply search field changes from Thumbnails here as well

Test Plan:
- Open https://openboard.ch/download/Tutoriel_OpenBoard_1.5EN.pdf with okularkirigami
- open the context drawer
- switch to the "Table of Contents" tab
- the ToC should load successfully

Reviewers: #okular, bshah

Reviewed By: bshah

Subscribers: bshah, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D23066

Natsumi Higa authored Aug 10, 2019 and Albert Astals Cid committed Aug 10, 2019

Test Plan: Open a cb7 file (e.g. [[ https://bugs.kde.org/attachment.cgi?id=122002 | Attachment 122002 ]] from [[ https://bugs.kde.org/show_bug.cgi?id=410696 | Bug 410696 ]]) using Okular and see if it works.

Reviewers: #okular, aacid

Subscribers: broulik, pino, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D23037

Jan Grulich authored Aug 10, 2019 and Albert Astals Cid committed Aug 10, 2019

Reviewers: aacid

Subscribers: pino, ngraham, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D23027

Andrey Yashkin authored Aug 08, 2019 and Albert Astals Cid committed Aug 08, 2019

Summary:
Now //fontBoundaries// always has smaller width than //boundingRect// from
```
void QPainter::drawText(const QRect &rectangle, int flags, const QString &text, QRect *boundingRect = nullptr)
```
which is required to enclose the whole text. The difference is only several pixels, but sometimes it can cause visual problems. You can see the sidebar without and with this patch in Russian language with Noto Sans 10pt font on a picture below.
{F7177644}
Now the first and the last symbols are fully visible.

Reviewers: #okular

Subscribers: okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D23012

Summary: Adds a placeholder text and uses contentItem

Reviewers: #okular, #plasma:_mobile, ngraham, apol

Reviewed By: #plasma:_mobile, ngraham, apol

Subscribers: ognarb, ngraham, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D22903

Summary: Adds tootip, different icons depending on checked state and fixed functionality

Test Plan:
- Open a document
- click bookmark action
- the bookmarked page should appear in the bookmarks tab of the contextDrawer

Reviewers: #okular, #plasma:_mobile, ngraham

Reviewed By: ngraham

Subscribers: ngraham, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D22904

Oliver Sander authored Jul 04, 2019 and Albert Astals Cid committed Aug 01, 2019

... in presentation mode.

Thanks to Tobias Deiminger for his help.

Oliver Sander authored Jul 04, 2019 and Albert Astals Cid committed Aug 01, 2019

The previous code used two consecutive calls to the method
slotChangeDrawingToolEngine to reset the m_drawingEngine
member (i.e., to delete it and to create a new one from scratch).
That worked; however, as a side effect the calls to
slotChangeDrawingToolEngine also set the cursor to an arrow,
which happens every time one continuous stroke is finished.
This went unnoticed because when drawing in presentation mode
the cursor is an arrow anyway.  However, in anticipation
of future patches that change the cursor to a cross-hair
when drawing, this explicit setting of the arrow shape
needs to go.  Therefore this patch replaces the two calls
to slotChangeDrawingToolEngine by the code they contain,
minus the code to set the cursor shape. The new code is
only one line longer, and more readable too.

QRegion::rects is deprecated

Summary:
Configuration:
- Add push button to select custom stamp image
- Check if loaded image is usable as stamp or throw error
- Keep image proportions in previewer
- Move previewer below the combobox to display larger preview

Annotation tool:
- Keep stamp image proportion in annotation preview (while left mouse button is down)
- Adding the annotation with one-click (without holding the left mouse button and dragging) adds the stamp with original proportions

BUG: 370381
BUG: 383652
CCBUG: 383651
FIXED-IN: 1.9.0

Closes T8074

TODO:
- [ ] Check if filters in file chooser make sense / propose better alternative
- [x] Update doc ( @yurchor will do it after we merge this)

Test Plan:
From stamp annotation configuration dialog:
- Show a warning regarding limitations of the feature's current implementation
- Click push button next to combo box opens a file selector
- Selecting a corrupted image file should throw an error
- Selecting a good image file shows the preview of the image
- Select a horizontal image shows a large clear preview
- Select a vertical image file shows a smaller preview without messing up the visual of the config dialog
- Input a valid icon name in the combobox and the preview of the icon is shown

From page view, select the stamp annotation with horizontal image file (not squared):
- Click and hold. The preview maintains proportions
- Single click. The stamp image in the pdf maintains proportions and has the same size of the click and hold preview.
- Add an annotation of the Okular custom stamps (internal SVG so treated slightly differently) do not create problems

Reviewers: #okular, ngraham

Reviewed By: ngraham

Subscribers: pino, aacid, yurchor, ngraham, okular-devel

Tags: #okular

Maniphest Tasks: T8074

Differential Revision: https://phabricator.kde.org/D22064

It blocks on rendering, which makes scrolling noticeably slow on systems
with high resolution scrolling.

Reviewed by Albert Astals

David Hurka authored Jul 21, 2019 and Albert Astals Cid committed Jul 21, 2019

Summary:
This shall improve the documentation of several area classes,
including NormalizedPoint, NormalizedRect, RegularArea, RegularAreaRect.

This shall also clarify when absolute coordinates and when normalized
coordinates are used.

Describes the normalized coordinate system in NormalizedPoint, with a new term “reference area” do describe mapping.

TODO:
Page view rotation.
This is not done consistently in Okular, but can be changed later. I think this documentation will help (me) with that then.

Test Plan: Run doxygen

Reviewers: #okular, aacid

Reviewed By: #okular, aacid

Subscribers: aacid, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D21266

David Hurka authored Jul 21, 2019 and Albert Astals Cid committed Jul 21, 2019

Summary:
This adds some important documentation on TextEntity and other classes, and improves some of the existing documentation.

This includes changing parameter names from ‘rect’ to ‘area’, because I found ‘rect’ misleading.

Test Plan: Run doxygen

Reviewers: #okular, aacid

Reviewed By: #okular, aacid

Subscribers: aacid, yurchor, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D21271

Joao Oliveira authored Jun 28, 2019 and Albert Astals Cid committed Jul 20, 2019

Moved executeScript to document private and support to display options for JavaScript

Joao Oliveira authored Jun 06, 2019 and Albert Astals Cid committed Jul 20, 2019

Added support for the setIcon/getIcon defined in Poppler > 0_78

Joao Oliveira authored May 31, 2019 and Albert Astals Cid committed Jul 20, 2019

Implemented more unit tests to cover the OCGs

Joao Oliveira authored May 23, 2019 and Albert Astals Cid committed Jul 20, 2019

When refreshing, widgets must check if they should be visible

Implemented unit tests to the JavaScript functions.

Seems to make tests more stable