GitLab

I have a JIRA bug report with a PDF attached, and mid-clicking the PDF
in konqueror leads to opening an okularpart with mimetype="application/x-octet-stream"
(the x- in there is very unusual, and unknown to shared-mime-info).
Fixed with null pointer checks.

REVIEW: 122074

BUGS: 342492
FIXED-IN: 14.12.1

On 45dc1990 i made the wrong assumption that if you were in
slotRequestVisiblePixmaps with the mid mouse button pressed
it meant that you were mid mouse button zooming, but this is not
true if you mid mouse click on the scrollbar.

So the solution to ignore pixmap request on mid mouse button zooming
is actually use blockPixmapsRequest

BUGS: 341583
FIXED-IN: 14.12.1

Keep a local MouseMode setting, and don't rely on the value returned by Settings::mouseMode().
BUGS: 334251
REVIEW: 120660
FIXED-IN: 14.12.0

REVIEW: 120685

Conflicts:
	VERSION
	core/version.h

Only take Okular::SettingsCore::slidesAdvanceTime into consideration if the user actually has autoAdvance checked

Fixes the case in which the page has duration, and Okular::SettingsCore::slidesAdvanceTime is smaller than the page duration but autoAdvance is disabled

BUGS: 340035

Based on patches by Yuri Chornoivan and Jörg Schuck

BUGS: 340323
FIXED-IN: 4.14.3

Conflicts:
	VERSION
	core/version.h

Somehow i ended up commiting a partial patch and not what was in reviewboard, this amends the previous commit to be what i really wanted to commit

Sorry for the mess :/

This way dvi and any other potential user gets it for free

The diff is huge, but the synctex files are just moves.

And the code in core/ is also mostly just a move from the generator_pdf.cpp code

Acked by Luigi

REVIEW: 120311

Shell's CTOR will fail if Okular component isn't found, leading
to i never being incremented.

BUGS: 314251
REVIEW: 120307
FIXED-IN: 4.14.2

We need
  disconnect(textEdit, SIGNAL(cursorPositionChanged()), this,SLOT(slotsaveWindowText()));
and it's counterpart, otherwise when inserting the image, the cursor pos changes, slotsaveWindowText is called, the content is passed by a toPlainText and set again and kaboom the content is lost

Also a few extra const

BUGS: 335476
FIXED-IN: 4.14.2

If the fonts are mapped for some reason to X bitmap fonts,
the call to drawText() in the non-GUI thread will produce a crash.
Ensure that the rendering of the text is performed only if
the threaded font rendering is available - a rare event nowadays,
but still possible.

CCBUG: 248852

distance being in sqr pixels and s_minDistance being a normalized value was not a good idea to compare them ^_^

BUGS: 326605
REVIEW: 120308

    Do not end up with the sidebar hidden when opening some files and you had it open

    For example with http://www.abax.se/content/download/137/862/file/example.pdf