1. 08 Aug, 2019 2 commits
  2. 07 Aug, 2019 4 commits
  3. 05 Aug, 2019 1 commit
    • Jonah Brüchert's avatar
      Improve search field · 230ae9af
      Jonah Brüchert authored
      Summary: Adds a placeholder text and uses contentItem
      
      Reviewers: #okular, #plasma:_mobile, ngraham, apol
      
      Reviewed By: #plasma:_mobile, ngraham, apol
      
      Subscribers: ognarb, ngraham, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D22903
      230ae9af
  4. 03 Aug, 2019 1 commit
    • Jonah Brüchert's avatar
      Fix bookmark action · cff01c10
      Jonah Brüchert authored
      Summary: Adds tootip, different icons depending on checked state and fixed functionality
      
      Test Plan:
      - Open a document
      - click bookmark action
      - the bookmarked page should appear in the bookmarks tab of the contextDrawer
      
      Reviewers: #okular, #plasma:_mobile, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D22904
      cff01c10
  5. 01 Aug, 2019 4 commits
  6. 31 Jul, 2019 2 commits
  7. 29 Jul, 2019 1 commit
  8. 27 Jul, 2019 2 commits
  9. 26 Jul, 2019 1 commit
  10. 25 Jul, 2019 1 commit
    • Simone Gaiarin's avatar
      General improvements to stamp annotation · f15e8568
      Simone Gaiarin authored
      Summary:
      Configuration:
      - Add push button to select custom stamp image
      - Check if loaded image is usable as stamp or throw error
      - Keep image proportions in previewer
      - Move previewer below the combobox to display larger preview
      
      Annotation tool:
      - Keep stamp image proportion in annotation preview (while left mouse button is down)
      - Adding the annotation with one-click (without holding the left mouse button and dragging) adds the stamp with original proportions
      
      BUG: 370381
      BUG: 383652
      CCBUG: 383651
      FIXED-IN: 1.9.0
      
      Closes T8074
      
      TODO:
      - [ ] Check if filters in file chooser make sense / propose better alternative
      - [x] Update doc ( @yurchor will do it after we merge this)
      
      Test Plan:
      From stamp annotation configuration dialog:
      - Show a warning regarding limitations of the feature's current implementation
      - Click push button next to combo box opens a file selector
      - Selecting a corrupted image file should throw an error
      - Selecting a good image file shows the preview of the image
      - Select a horizontal image shows a large clear preview
      - Select a vertical image file shows a smaller preview without messing up the visual of the config dialog
      - Input a valid icon name in the combobox and the preview of the icon is shown
      
      From page view, select the stamp annotation with horizontal image file (not squared):
      - Click and hold. The preview maintains proportions
      - Single click. The stamp image in the pdf maintains proportions and has the same size of the click and hold preview.
      - Add an annotation of the Okular custom stamps (internal SVG so treated slightly differently) do not create problems
      
      Reviewers: #okular, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: pino, aacid, yurchor, ngraham, okular-devel
      
      Tags: #okular
      
      Maniphest Tasks: T8074
      
      Differential Revision: https://phabricator.kde.org/D22064
      f15e8568
  11. 22 Jul, 2019 1 commit
  12. 21 Jul, 2019 2 commits
    • David Hurka's avatar
      Improve documentation of area classes · 0602576c
      David Hurka authored
      Summary:
      This shall improve the documentation of several area classes,
      including NormalizedPoint, NormalizedRect, RegularArea, RegularAreaRect.
      
      This shall also clarify when absolute coordinates and when normalized
      coordinates are used.
      
      Describes the normalized coordinate system in NormalizedPoint, with a new term “reference area” do describe mapping.
      
      TODO:
      Page view rotation.
      This is not done consistently in Okular, but can be changed later. I think this documentation will help (me) with that then.
      
      Test Plan: Run doxygen
      
      Reviewers: #okular, aacid
      
      Reviewed By: #okular, aacid
      
      Subscribers: aacid, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21266
      0602576c
    • David Hurka's avatar
      Improve documentation of TextEntity stuff · c61a9587
      David Hurka authored
      Summary:
      This adds some important documentation on TextEntity and other classes, and improves some of the existing documentation.
      
      This includes changing parameter names from ‘rect’ to ‘area’, because I found ‘rect’ misleading.
      
      Test Plan: Run doxygen
      
      Reviewers: #okular, aacid
      
      Reviewed By: #okular, aacid
      
      Subscribers: aacid, yurchor, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21271
      c61a9587
  13. 20 Jul, 2019 7 commits
  14. 17 Jul, 2019 11 commits