1. 24 Jun, 2019 1 commit
  2. 03 Jun, 2019 1 commit
  3. 19 May, 2019 1 commit
    • Rajeesh K V's avatar
      Okular Annotation: add support for line start style for Straight Line tool · 59a86c3f
      Rajeesh K V authored
      Summary: Similar to the line ending style, add support for line start style for the Straight Line annotation tool
      
      Test Plan:
      1. Go to Configure annotations
      2. Create (or edit existing) Straight Line tool
      3. Set the ‘Line Start’ option on Style and Apply
      4. Use the Straight Line tool to draw a line and check the line starting style.
      
      Reviewers: #okular, tobiasdeiminger
      
      Reviewed By: tobiasdeiminger
      
      Subscribers: ngraham, tobiasdeiminger, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21238
      59a86c3f
  4. 07 May, 2019 1 commit
    • Rajeesh K V's avatar
      Okular Annotation: add support for line ending style for Straight Line tool · db2dcdad
      Rajeesh K V authored
      Summary:
      Poppler and Okular already have support for specifying Line End style (`TermStyle`) for the Straight Line tool. Expose the functionality in configuration and hook up the correct slots.
      
      Configure annotations (before):
      {F6788150}
      
      Configure annotations (after):
      {F6788151}
      
      Straight Line tool with Open Arrow end in action:
      {F6788153}
      
      Test Plan:
      1. Open a PDF in Okular
      2. Enable Review
      3. Right click on Review toolbar and Configure annotations
      4. Create (or edit existing) Straight Line tool
      5. Set the ‘Line End’ option on Style and Apply
      6. Use the Straight Line tool to draw a line and check the line ending style.
      
      Reviewers: #okular, #vdg, sander, ngraham
      
      Reviewed By: #vdg, sander, ngraham
      
      Subscribers: pino, sander, davidhurka, tobiasdeiminger, ngraham, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D20760
      db2dcdad
  5. 30 Apr, 2019 1 commit
  6. 11 Mar, 2019 1 commit
    • Oliver Sander's avatar
      Presentation: optionally go to prev. page when touching left half of the page · 50bfd9fe
      Oliver Sander authored
      This patch makes switching presentation slides using touch screen taps
      more flexible.  It introduces a new configuration option
      'Touch navigation' with three possible values:
      * 'Tap left/right side to go back/forward':
         Tapping on the left(right) half of the screen
        makes the presentation go to the previous(next) slide.
      * 'Tap anywhere to go forward':
        Tapping on the screen makes the presentation go to the
        next slide, no matter where the screen is being tapped
      * 'Disabled':
        Screen tapping doesn't do anything.
      
      Previously, only 'Tap anywhere...' was implemented.
      
      This patch does not change the behavior of mouse clicks.
      
      Differential Revision: https://phabricator.kde.org/D18118
      50bfd9fe
  7. 24 Feb, 2019 1 commit
    • Yuri Chornoivan's avatar
      Add TeXstudio support · 2b6e75e4
      Yuri Chornoivan authored
      Summary:
      Some people need it because it is now the default TeX editor in distributions.
      
      BUG: 404120
      
      Test Plan: "Settings -> Configure Okular... -> Editor -> TeXstudio". Should work for the reverse search if the tex file is compiled with \usepackage[active]{srcltx}
      
      Reviewers: #okular, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, okular-devel, kde-doc-english
      
      Tags: #okular, #documentation
      
      Differential Revision: https://phabricator.kde.org/D19272
      2b6e75e4
  8. 23 Feb, 2019 1 commit
    • Volker Krause's avatar
      Remove dependency on okularpart from the mobile components · bc4c19eb
      Volker Krause authored
      Summary:
      This only depended on okularpart due to the export header used in the
      kcfgc file, so use a dedicated one for the mobile components that doesn't
      export anything.
      
      This enables disabling the part build for mobile-only builds such as
      Android, and thus removing the need for some difficult dependencies
      like KParts.
      
      Reviewers: aacid
      
      Reviewed By: aacid
      
      Subscribers: aacid, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D19037
      bc4c19eb
  9. 21 Nov, 2018 1 commit
    • Laurent Montel's avatar
      Fix mem leak found by asan · 6cbbc7f7
      Laurent Montel authored
      Indirect leak of 48 byte(s) in 1 object(s) allocated from:
          #0 0x7f4fa41e3900 in operator new(unsigned long)
      (/usr/lib64/libasan.so.5+0xed900)
          #1 0x7f4f96a455b2 in Okular::Annotation::Window::Window()
      /compile/kde5/framework/kde/kdegraphics/okular/core/annotations.cpp:341
          #2 0x7f4f96a46207 in Okular::AnnotationPrivate::AnnotationPrivate()
      /compile/kde5/framework/kde/kdegraphics/okular/core/annotations.cpp:493
          #3 0x7f4f96a7f605 in
      Okular::TextAnnotationPrivate::TextAnnotationPrivate()
      (libOkular5Core.so.9+0xb9605)
          #4 0x7f4f96a57ceb in Okular::TextAnnotation::TextAnnotation()
      /compile/kde5/framework/kde/kdegraphics/okular/core/annotations.cpp:1042
          #5 0x7f4f96e3e04f in EditAnnotToolDialog::createStubAnnotation()
      /compile/kde5/framework/kde/kdegraphics/okular/conf/editannottooldialog.cpp:300
          #6 0x7f4f96e2aa8b in
      EditAnnotToolDialog::EditAnnotToolDialog(QWidget*, QDomElement const&)
      /compile/kde5/framework/kde/kdegraphics/okular/conf/editannottooldialog.cpp:97
          #7 0x7f4f96e52bbb in WidgetAnnotTools::slotAdd()
      /compile/kde5/framework/kde/kdegraphics/okular/conf/widgetannottools.cpp:151
          #8 0x7f4f96e5799c in
      QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>,
      void, void (WidgetConfigurationToolsBase::*)()>::call(void
      (WidgetConfigurationToolsBase::*)(),
      6cbbc7f7
  10. 04 Oct, 2018 1 commit
    • Dileep Sankhla's avatar
      Support setting text color for typewriter annotations · e44ff387
      Dileep Sankhla authored
      Summary:
      Changing typewriter text color can be done in the typewriter properties dialog, or programmatically via new okular API methods TextAnnotation::textColor and TextAnnotation::setTextColor.
      
      poppler >= 0.69 is required to store text color natively inside PDF documents. For other document types, text color is stored as metadata inside the document archive.
      
      This work was done during GSoC 2018. See https://community.kde.org/GSoC/2018/StatusReports/DileepSankhla for details.
      
      Test Plan:
      - properties dialog of typewriter annotation has "Font Color" picker
      - saving to PDF results in <r> <g> <b> rg operation in /DA
      - saving to archive results in fontColor="rrggbb" attribute in metadata.xml
      
      Reviewers: sander
      
      Reviewed By: sander
      
      Subscribers: kde-doc-english, sander, okular-devel
      
      Tags: #okular, #documentation
      
      Differential Revision: https://phabricator.kde.org/D15205
      e44ff387
  11. 25 Sep, 2018 1 commit
    • Dileep Sankhla's avatar
      Add typewriter annotation tool · 6dd7cf66
      Dileep Sankhla authored
      Summary:
      Typewriter is originally specified by the PDF reference as special FreeText annotation, where Intent=FreeTextTypewriter. It features opaque letters on transparent background, so that users can fill non interactive forms. Herewith typewriter is implemented natively for PDF, and there's also an Okular specific implementation for other document types. The added tool reuses the inline note UI.
      
      This work was done during GSoC 2018. See https://community.kde.org/GSoC/2018/StatusReports/DileepSankhla for details.
      
      FEATURE: 353401
      
      Test Plan:
      - okularpartrc is generated (if not yet existing) with typewriter as 10th tool
      - typewriter tool is also available in Annotation Tools -> Add, Typ "Typewriter"
      - selecting the tool and left click into document opens inline note input dialog
      - finishing creates an annotation similar to inline note, but with transparent background
      - saving into PDF results in /Subtype FreeText /IT /FreeTextTypeWriter
      - saving typewriter into archive stores color with alpha channel = 0x00
      - opening annotated archive works, if archive was created with old Okular, and opened in patched Okular
      - opening annotated archive works, if archive was created with patched Okular, and opened in old Okular
      
      Reviewers: sander
      
      Reviewed By: sander
      
      Subscribers: ngraham, sander, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D15204
      6dd7cf66
  12. 07 Sep, 2018 1 commit
    • Dileep Sankhla's avatar
      Store all annotation color attributes as ARGB string · d61cef69
      Dileep Sankhla authored
      Summary:
      This is mainly preparation for D15204 (typewriter), where storing RGB won't be sufficient any longer.
      Typewriter will need transparent background (alpha=0x00), which can only be expressed as ARGB string.
      
      Current code handles name format identical for all annotations. It doesn't hurt to store all annotations in ARGB format, so instead of introducing special handling for typewriter, let's store all annotation color attributes as ARGB string.
      
      Note: In case of previously existing okularpartrc, configuration will be reused without conversion. New color format will be written when new settings are saved. This has no bad effect.
      
      Test Plan:
      - when [Reviews] section in okularpartrc is initially generated, all annotation color attributes are in #AARRGGBB format
      - saving into archive stores color with alpha channel (#AARRGGBB), for all kind of annotations
      
      Reviewers: sander
      
      Reviewed By: sander
      
      Subscribers: dileepsankhla, sander, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D15279
      d61cef69
  13. 01 Sep, 2018 1 commit
  14. 31 Aug, 2018 1 commit
  15. 17 Aug, 2018 1 commit
  16. 14 Oct, 2017 1 commit
    • Lukas Hetzenecker's avatar
      HiDPI Support for Okular · ecc1141e
      Lukas Hetzenecker authored
      Summary:
      This patch enables HiDPI throughout the application
      
      Every pixmap is multiplied by the devicePixelRatioF
      QPainter code is ajusted to take the DPR value into account
      
      All pixmaps get cached with the highest DPR of all screens. When moving the application to another screen, the cache doesn't have to be invalidated.
      
      BUGS: 362856 383589
      REVIEW: D6268
      ecc1141e
  17. 01 Oct, 2017 3 commits
    • Albert Freeman's avatar
      Custom background color · 1f6e8a47
      Albert Freeman authored
      Summary:
      BUG: 182994
      
      Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).
      
      Reasons for this change:
      Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
      Many people want this change occording to Bugzilla and other sources.
      
      Maintenance: Nearly no additional maintenance:
      This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
      
      {F4257766}
      
      Other less important information:
      https://git.reviewboard.kde.org/r/130219/
      https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html
      
      Test Plan:
      Tested everything, it all works:
      Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).
      
      Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: aacid, ltoscano, ngraham
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D8051
      1f6e8a47
    • Luigi Toscano's avatar
      Revert "Custom background color" · d176914e
      Luigi Toscano authored
      Wrong authorship for the commit. Commit it again with the correct
      information.
      
      CCMAIL: pointedstick@zoho.com
      This reverts commit 6b5a7c9a.
      d176914e
    • Nathaniel Graham's avatar
      Custom background color · 6b5a7c9a
      Nathaniel Graham authored
      Summary:
      BUG: 182994
      
      Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).
      
      Reasons for this change:
      Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
      Many people want this change occording to Bugzilla and other sources.
      
      Maintenance: Nearly no additional maintenance:
      This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
      
      {F4257766}
      
      Other less important information:
      https://git.reviewboard.kde.org/r/130219/
      https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html
      
      Test Plan:
      Tested everything, it all works:
      Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).
      
      Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: aacid, ltoscano, ngraham
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D8051
      6b5a7c9a
  18. 05 Sep, 2017 1 commit
  19. 02 Jun, 2017 1 commit
  20. 13 Mar, 2017 1 commit
  21. 02 Mar, 2017 2 commits
  22. 08 Dec, 2016 1 commit
  23. 29 Oct, 2016 1 commit
  24. 18 Aug, 2016 1 commit
  25. 25 Jul, 2016 1 commit
  26. 24 Jul, 2016 1 commit
  27. 17 Jul, 2016 1 commit
  28. 16 Jul, 2016 2 commits
  29. 11 Jul, 2016 2 commits
  30. 07 Feb, 2016 1 commit
  31. 27 Nov, 2015 1 commit
    • Oliver Sander's avatar
      Set objectName for 'm_name' · e5383ea2
      Oliver Sander authored
      The unit test 'editdrawingtooldialogtest' on the frameworks branch aborts at run-time.  Reason: it expects the dialog to have a KLineEdit member with object name 'name'.  That KLineEdit does exist in the dialog, but no object name is set for it at all.  This patch explicitly sets the object name to 'name', which makes the editdrawingtooldialogtest pass again.
      
      REVIEW: 126158
      e5383ea2
  32. 24 Nov, 2015 1 commit
  33. 29 Oct, 2015 1 commit
  34. 13 Sep, 2015 1 commit
  35. 27 Aug, 2015 1 commit
    • Jake Linder's avatar
      Add "Trim To Selection" feature · 172d78c6
      Jake Linder authored
      Changes
      
      C1. Added submenu, moved "Trim margins" (TM mode) to it and added  "Trim To Selection" (TS mode).
      C2. Activating "Trim To selection" enters a new mousemode, similar to RectSelect for defining a viewport.
      C3. Once a viewport has been defined, it serves as a viewport for all pages in the document.
      C4. Left/Right pages are not treated differently.
      
      Manual Testing
      
      T1. Switching between modes enforces at most one active.
      T2. Can deactivate a mode by selecting it again from the menu.
      T3. When draggin bbox selection, clicking outside page does not crash.
      T4. When in "Facing Pages" mode, mouse release must be over any page (or is ignored).
      T5. Normalized bbox coords are computed relative to page indicated by point of mouse release.
      T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection.
      T7. TM mode persisted across app restarts (existing behavior).
      T8. TS mode forgotten across app restarts (as desired).
      T9. Exiting and reselectin "Trim To Selection" prompts for new bbox.
      T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as
      it does in TM mode, because of the "scale big and crop down" implementation, to avoid huge pixmaps.
      TS mode minimum set at 20% (vs. TM mode's 50%).
      
      REVIEW: 124716
      BUGS: 351156
      172d78c6