1. 04 Oct, 2017 1 commit
  2. 01 Oct, 2017 1 commit
    • Michael Pyne's avatar
      Remove Kdelibs4Support. · 1e3b90b8
      Michael Pyne authored
      This required a wide assortment of fixes, including deleting
      needless #include <koldfoo.h> headers, some minor additional porting
      tasks, and adding in includes that were previously only implicitly
  3. 27 Aug, 2017 3 commits
    • Kacper Kasper's avatar
      Fix upcoming playlist crashes. · 2790a724
      Kacper Kasper authored
      Also ensures items added to the upcoming playlist are ordered correctly
      and fixes the "Add to Play Queue" GUI action.
      Differential Revision: https://phabricator.kde.org/D7553
    • Michael Pyne's avatar
      Cleanup AdvancedSearchPlaylist. · 647e8ce5
      Michael Pyne authored
      - Port away from K[HV]Box
      - Port away from KDialog
      - It's been 10 years since you could make a SearchPlaylist from the
      track search widget, remove the dead code.
      SearchPlaylist still doesn't work but at least there are fewer warnings
      and you can at least make it to the AdvancedSearchDialog again.
    • Michael Pyne's avatar
      More QAction streamlining. · 2889fd1f
      Michael Pyne authored
      - Use KActionCollection::setDefaultShortcut to reduce warnings
      - Use QKeySequence instead of deprecated KShortcut
  4. 26 Aug, 2017 5 commits
  5. 25 Aug, 2017 1 commit
  6. 27 Jul, 2017 1 commit
  7. 26 Jul, 2017 2 commits
  8. 24 May, 2015 1 commit
  9. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
  10. 29 Jun, 2013 1 commit
    • Michael Pyne's avatar
      mpris2: Move DBus adapter creation until after GUI setup. · fa657b97
      Michael Pyne authored
      This helps a little bit with JuK freezing Plasma due to DBus deadlocks
      from synchronous calls being made between KStatusNotifierItem, its
      Plasma notification area counterpart, and the MPRIS2 adapter and its
      Plasma counterpart(s).
      Proper fix is async everywhere as far as I can tell.
  11. 26 Jun, 2013 1 commit
    • Michael Pyne's avatar
      startup: Async-ify cached item loading on startup, add timers. · bf4df116
      Michael Pyne authored
      In an attempt to get rid of processEvents() (related to several existing
      crash bugs) I am trying to port the startup code towards more
      async-friendly schemes.
      There's no threading but we at least get back to the event loop much
      more frequently while loading files.
      Additionally I have added debug output with instrumentation to show how
      long it takes to advance through each step of the startup (I think this
      might be the first time anyone has understood JuK startup sequence in
      This leaves some essentially dead code with Cache (which no longer
      acts as a container), which I will try to cleanup in later commits.
  12. 17 Jun, 2013 1 commit
    • Michael Pyne's avatar
      Fix GUI flaws on startup. · 74124a0d
      Michael Pyne authored
      Kind of embarassing it took so long to track down why multiple
      seemingly-random PlaylistBox::Items were selected.
  13. 15 Jun, 2013 1 commit
  14. 09 Mar, 2013 1 commit
  15. 15 Sep, 2012 1 commit
  16. 04 Jul, 2012 2 commits
  17. 31 Jul, 2011 1 commit
  18. 09 May, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: save & restore playlist and tag editor sizes. · 0a9a71c9
      Giorgos Kylafas authored
      editorSplitter is turned to a member variable (m_editorSplitter) whose
      sizes are stored and retrieved the same way as PlaylistSplitter's.
      If no sizes were saved, use default sizes for the playlist and the
      editor. The values are just hints for the actual size, m_editorSplitter
      will distribute the space according to their relative weight.
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1231059
  19. 30 Apr, 2011 1 commit
    • Michael Pyne's avatar
      Correctly write TagEditor config on shutdown. · 5eb7b75b
      Michael Pyne authored
      Another JuK fix from Giorgos Kylafas, this time to ensure that the tag editor
      pane always correctly writes out its configuration at shutdown.
      Without forcing the tag editor to be destroyed, it is possible that the KAction
      the TagEditor class reads when writing its configuration would have a reset
      checked state. There's probably similar bugs still extant (e.g. sometimes JuK
      opens with a very wide "playlist box").
      Unfortunately this comes too late to backport to 4.6.3, but I'll try for 4.6.4
      once the tagging process is confirmed completed for the 4.6.3 release
      (reminders always appreciated though ;)
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1229816
  20. 22 Sep, 2010 1 commit
  21. 11 Jun, 2010 1 commit
    • Michael Pyne's avatar
      Make the history playlist work again. · faf5e09f
      Michael Pyne authored
      In the great PlayerManager de-singletonizing of KDE 4.1 I managed to not port over the
      Qt signal for the playlist splitter that was emitted on track change, which meant the
      history playlist wouldn't receive it. I've reattached the signal to the history playlist
      which means it works[1] again.
      [1] It's still as broken as it was in KDE 4.0, which means that the "Date" column doesn't
      show up, and all the other columns are shifted over by one to compensate.
      BUG: 168998
      FIXED-IN: 4.5
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1136884
  22. 26 Nov, 2009 1 commit
    • Michael Pyne's avatar
      Decouple PlayerManager from JuK so that it isn't a singleton. · c0204770
      Michael Pyne authored
      The major reason for this change is to allow for a saner destruct sequence
      (instead of the unordered global static destruct sequence) which will hopefully
      help reduce crash-on-shutdown bugs.
      This will not be in the upcoming KDE 4.4 beta but will be in the 4.4 release (assuming no
      bugs are found in it ;)
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1054429
  23. 04 Feb, 2009 1 commit
    • Michael Pyne's avatar
      Two bugfixes: · 5f913836
      Michael Pyne authored
      1. Don't allow JuK to shutdown until Phonon has definitely returned to StoppedState to prevent some backends
      from crashing on shutdown.
      2. Delay system tray creation until after the collection list has been loaded from the cache.  If we're
      trying to create the system tray before this process then half the time we end up freezing all of Plasma
      until the cache finally loads, which is especially noticable on initial KDE startup.
      I will give this a few days of testing in /trunk and will then probably backport both.
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=921339
  24. 29 Jan, 2009 1 commit
  25. 20 Jan, 2009 1 commit
  26. 22 Nov, 2008 1 commit
  27. 20 Nov, 2008 1 commit
  28. 01 Sep, 2008 1 commit
    • Michael Pyne's avatar
      Fun thing to do with JuK: · 7ff5a548
      Michael Pyne authored
      Pause playback.
      Type in something into the search widget
      Press enter to play the first matched song.
      A song will play alright, but the playingFile will be thought to be null for some reason.  I've
      tracked down that this is probably due to there being no selected item in the visible results
      when enter is pressed, so I've made the search widget's returnPressed() signal manually play
      the first listed match instead of relying on Playlist's returnPressed() signal to work.
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=855548
  29. 27 Aug, 2008 1 commit
  30. 24 Aug, 2008 1 commit
    • Michael Pyne's avatar
      JuK optimizapalooza! · c8f53250
      Michael Pyne authored
      * Add whatever X-DBUS-foo line KUniqueApplication says we need.
      * Restructure the startup sequence to postpone all the hard work until after the GUI is setup
        as much as possible to allow passing our reply over DBUS ASAP.
      * Don't call hasCover from PlaylistItem like, ever.  I made CoverInfo::hasCover() take longer
        when I added support for APIC frames but didn't catch all unnecessary instances of their use
        last time.  Luckily this is the big win and is backportable.
      * Also, don't force CoverInfo::coverId() to call hasCover() for no reason.
      Hopefully this should remove the egregrious Plasma freeze-ups while starting but even after
      returning from KUniqueApplication::newInstance() quickly it seems to take a while for the reply
      to go over the D-BUS...
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=851610
  31. 16 Jun, 2008 2 commits