• Michael Pyne's avatar
    Fix crash with threaded file loading. · 24b0edd1
    Michael Pyne authored
    Although Qt protects access to functions in the GUI thread (where I was
    seeing crashes in the new threaded file loading code in some
    situations), as long as you use signals/slots, Qt Concurrent doesn't do
    anything to keep your non-GUI threaded code from trampling on each
    other.
    
    Which is obvious enough, in retrospect, but that seems to have been the
    reason for the crashes I was sometimes seeing (TagLib and/or FileHandle
    not being thread-safe).
    
    The immediate bugfix is to serialize access into FileHandle/TagLib file
    reading code in DirectoryLoader, though I also did some cleanups in the
    process of debugging that I think are worth keeping.
    24b0edd1
playlist.h 23.3 KB