Commit 0704806f authored by Michael Pyne's avatar Michael Pyne

BUG:We should report the track title of failed tag edits, not the track number.

Use errorList() now in some places.  If you haven't updated kdelibs in awhile you may have to do so before recompiling juk.

svn path=/trunk/kdemultimedia/juk/; revision=360294
parent a2c35b91
......@@ -733,7 +733,7 @@ void FileRenamer::rename(const PlaylistItemList &items)
KApplication::restoreOverrideCursor();
if(!errorFiles.isEmpty())
KMessageBox::error(0, i18n("The following rename operations failed:\n") + errorFiles.join("\n"));
KMessageBox::errorList(0, i18n("The following rename operations failed:\n"), errorFiles);
}
bool FileRenamer::moveFile(const QString &src, const QString &dest)
......
......@@ -182,10 +182,10 @@ bool TagTransactionManager::processChangeList(bool undo)
}
else {
Tag *errorTag = item->file().tag();
QString str = errorTag->artist() + " - " + errorTag->track();
QString str = errorTag->artist() + " - " + errorTag->title();
if(errorTag->artist().isEmpty())
str = errorTag->track();
str = errorTag->title();
errorItems.append(str);
}
......@@ -200,7 +200,7 @@ bool TagTransactionManager::processChangeList(bool undo)
action("edit_undo")->setEnabled(false);
if(!errorItems.isEmpty())
KMessageBox::informationList(static_cast<QWidget *>(parent()),
KMessageBox::errorList(static_cast<QWidget *>(parent()),
i18n("The following files were unable to be changed."),
errorItems,
i18n("Error"));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment