Commit 28fb30f1 authored by Michael Pyne's avatar Michael Pyne

Fix bug 88847 (Previous track doesn't work anymore in Play Queue mode). This...

Fix bug 88847 (Previous track doesn't work anymore in Play Queue mode).  This was actually by design, as items in the upcoming playlist are so ephemeral that keeping track of them would later crash JuK.  However, instead the associate collection list item is stored instead, which I feel is a better alternative.

BTW to the reporter, JuK doesn't actually use the history playlist for this. ;-)

CCMAIL:88847-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=344076
parent ca9676e6
......@@ -1241,8 +1241,12 @@ void Playlist::setPlaying(PlaylistItem *item, bool addToHistory)
m_playingItem->setPixmap(m_leftColumn, QPixmap(0, 0));
m_playingItem->setPlaying(false);
if(addToHistory && m_playingItem->playlist() != m_upcomingPlaylist)
m_history.append(m_playingItem);
if(addToHistory) {
if(m_playingItem->playlist() == m_upcomingPlaylist)
m_history.append(m_playingItem->collectionItem());
else
m_history.append(m_playingItem);
}
m_playingItem = 0;
}
......
......@@ -160,7 +160,7 @@ void UpcomingPlaylist::UpcomingSequenceIterator::advance()
if(loop)
m_playlist->addNewItem();
m_playlist->setPlaying(0, false);
m_playlist->setPlaying(0);
m_playlist->clearItem(item);
}
else
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment