Commit 56358be7 authored by Yuri Chornoivan's avatar Yuri Chornoivan

Fix minor EBN issues

parent 94473a25
......@@ -33,7 +33,7 @@ class AdvancedSearchDialog : public QDialog
Q_OBJECT
public:
AdvancedSearchDialog(
explicit AdvancedSearchDialog(
const QString& defaultName,
const PlaylistSearch& defaultSearch = PlaylistSearch(),
QWidget* parent = nullptr);
......
......@@ -18,9 +18,9 @@
#ifndef JUK_CACHE_H
#define JUK_CACHE_H
#include <QtCore/QDataStream>
#include <QtCore/QFile>
#include <QtCore/QBuffer>
#include <QDataStream>
#include <QFile>
#include <QBuffer>
class Playlist;
class PlaylistCollection;
......
......@@ -52,7 +52,7 @@ typedef QVector<TagCountDict *> TagCountDicts;
* It is being implemented as a "semi-singleton" because I need universal access
* to just one instance. However, because the collection needs initialization
* parameters (that will not always be available when an instance is needed).
* Hence there will be the familiar singleton "instance()" method allong with an
* Hence there will be the familiar singleton "instance()" method along with an
* "initialize()" method.
*/
......
......@@ -28,7 +28,7 @@ class CoverDialog : public QWidget, public Ui::CoverDialogBase
{
Q_OBJECT
public:
CoverDialog(QWidget *parent);
explicit CoverDialog(QWidget *parent);
~CoverDialog();
virtual void show();
......
......@@ -32,7 +32,7 @@ class CoverInfo
public:
enum CoverSize { FullSize, Thumbnail };
CoverInfo(const FileHandle &file);
explicit CoverInfo(const FileHandle &file);
bool hasCover() const;
......
......@@ -44,7 +44,7 @@ class CoverSaveHelper : public QObject
Q_OBJECT
public:
CoverSaveHelper(QObject *parent);
explicit CoverSaveHelper(QObject *parent);
void saveCovers();
private slots:
......@@ -94,7 +94,7 @@ class CoverDrag : public QMimeData
Q_OBJECT
public:
CoverDrag(coverKey id);
explicit CoverDrag(coverKey id);
static const char* mimetype();
......
......@@ -17,7 +17,7 @@
#ifndef JUK_COVERPROXY_H
#define JUK_COVERPROXY_H
#include <QtCore/QObject>
#include <QObject>
class KJob;
......@@ -30,7 +30,7 @@ class CoverProxy : public QObject
Q_OBJECT
public:
CoverProxy(QObject *parent = 0);
explicit CoverProxy(QObject *parent = 0);
private slots:
void handleResult(KJob *);
......
......@@ -36,7 +36,7 @@ class DeleteWidget : public QWidget
Q_OBJECT
public:
DeleteWidget(QWidget *parent);
explicit DeleteWidget(QWidget *parent);
void setFiles(const QStringList &files);
bool shouldDelete() const;
......@@ -59,7 +59,7 @@ class DeleteDialog : public QDialog
Q_OBJECT
public:
DeleteDialog(QWidget* parent);
explicit DeleteDialog(QWidget* parent);
bool confirmDeleteList(const QStringList &condemnedFiles);
void setFiles(const QStringList &files);
......
......@@ -48,7 +48,7 @@ public:
bool addPlaylists;
};
DirectoryList(
explicit DirectoryList(
const QStringList &directories,
const QStringList &excludeDirectories,
bool importPlaylists,
......
......@@ -28,7 +28,7 @@ class ExampleOptions : public QWidget, public Ui::ExampleOptionsBase
{
Q_OBJECT
public:
ExampleOptions(QWidget *parent);
explicit ExampleOptions(QWidget *parent);
protected slots:
void exampleSelectionChanged();
......@@ -44,7 +44,7 @@ class ExampleOptionsDialog : public QDialog
{
Q_OBJECT
public:
ExampleOptionsDialog(QWidget *parent);
explicit ExampleOptionsDialog(QWidget *parent);
const ExampleOptions *widget() const { return m_options; }
......
......@@ -145,7 +145,7 @@ class FileRenamerWidget : public QWidget, public CategoryReaderInterface
Q_OBJECT
public:
FileRenamerWidget(QWidget *parent);
explicit FileRenamerWidget(QWidget *parent);
~FileRenamerWidget();
/// Maximum number of total categories the widget will allow.
......@@ -452,7 +452,7 @@ private slots:
virtual void exampleDialogShown();
/**
* This slot should be called whever the example input dialog is hidden.
* This slot should be called whenever the example input dialog is hidden.
*/
virtual void exampleDialogHidden();
......
......@@ -26,7 +26,7 @@ class FileRenamerConfigDlg : public QDialog
{
Q_OBJECT
public:
FileRenamerConfigDlg(QWidget *parent);
explicit FileRenamerConfigDlg(QWidget *parent);
protected slots:
virtual void accept();
......
......@@ -39,7 +39,7 @@ class HistoryPlaylist : public Playlist
Q_OBJECT
public:
HistoryPlaylist(PlaylistCollection *collection);
explicit HistoryPlaylist(PlaylistCollection *collection);
virtual ~HistoryPlaylist();
virtual HistoryPlaylistItem *createItem(const FileHandle &file, QTreeWidgetItem *after = nullptr);
......
......@@ -37,7 +37,7 @@ class JuK : public KXmlGuiWindow
Q_OBJECT
public:
JuK(const QStringList &filesToOpen, QWidget* parent = 0);
explicit JuK(const QStringList &filesToOpen, QWidget* parent = 0);
virtual ~JuK();
static JuK* JuKInstance();
......
......@@ -142,14 +142,14 @@ public:
/**
* This method is called when the puid was already generated. It will then do
* the lookup with MusicBrainz's server. This may be reimplemented to provide
* specific behavion for the lookup.
* specific behavior for the lookup.
*/
virtual void puidGenerated();
/**
* This method is called if the track was recognized by the TRM server.
* results() will return just one value. This may be reimplemented to
* provide specific behavion in the case of the track being recognized.
* provide specific behavior in the case of the track being recognized.
*
* \note The base class call should happen at the beginning of the subclass
* reimplementation; it populates the values of results().
......@@ -159,7 +159,7 @@ public:
/**
* This method is called if the track was not recognized by the TRM server.
* results() will return an empty set. This may be reimplemented to provide
* specific behavion in the case of the track not being recognized.
* specific behavior in the case of the track not being recognized.
*/
virtual void unrecognized();
......@@ -167,7 +167,7 @@ public:
* This method is called if there are multiple potential matches for the TRM
* value. results() will return a list of the potential matches, sorted by
* liklihood. This may be reimplemented to provide
* specific behavion in the case of the track not being recognized.
* specific behavior in the case of the track not being recognized.
*
* \note The base class call should happen at the beginning of the subclass
* reimplementation; it populates the values of results().
......@@ -177,7 +177,7 @@ public:
/**
* This method is called if the track was not recognized by the TRM server.
* results() will return an empty set. This may be reimplemented to provide
* specific behavion in the case of the track not being recognized.
* specific behavior in the case of the track not being recognized.
*/
virtual void error();
......
......@@ -14,6 +14,8 @@
* this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "lyricswidget.h"
#include <QDomDocument>
#include <QNetworkAccessManager>
#include <QNetworkReply>
......@@ -27,7 +29,6 @@
#include <KConfigGroup>
#include <KSharedConfig>
#include "lyricswidget.h"
#include "tag.h"
#include "actioncollection.h"
#include "juk_debug.h"
......
......@@ -29,7 +29,7 @@
#include <QApplication>
#include "juk.h"
#include "config-juk.h"
#include <config-juk.h>
static const char description[] = I18N_NOOP("Jukebox and music manager by the KDE community");
static const char scott[] = I18N_NOOP("Author, chief dork and keeper of the funk");
......
......@@ -38,7 +38,7 @@
#include <oggflacfile.h>
#include <mpcfile.h>
#include "config-juk.h"
#include <config-juk.h>
#if TAGLIB_HAS_OPUSFILE
# include <opusfile.h>
#endif
......
......@@ -18,8 +18,8 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
***********************************************************************/
#ifndef JUK_MEDIAPLAYRER2PLAYER_H
#define JUK_MEDIAPLAYRER2PLAYER_H
#ifndef JUK_MEDIAPLAYER2PLAYER_H
#define JUK_MEDIAPLAYER2PLAYER_H
#include <QDBusAbstractAdaptor>
#include <QDBusObjectPath>
......
......@@ -27,7 +27,7 @@
class MusicBrainzLookup : public KTRMLookup
{
public:
MusicBrainzLookup(const FileHandle &file);
explicit MusicBrainzLookup(const FileHandle &file);
virtual void recognized();
virtual void unrecognized();
virtual void collision();
......
......@@ -98,7 +98,7 @@ private:
class CoverItem : public QLabel, public NowPlayingItem
{
public:
CoverItem(NowPlaying *parent);
explicit CoverItem(NowPlaying *parent);
virtual void update(const FileHandle &file);
virtual void mouseReleaseEvent(QMouseEvent *event);
......@@ -125,7 +125,7 @@ class TrackItem : public QWidget, public NowPlayingItem
Q_OBJECT
public:
TrackItem(NowPlaying *parent);
explicit TrackItem(NowPlaying *parent);
virtual void update(const FileHandle &file);
private slots:
......
......@@ -1823,7 +1823,7 @@ void Playlist::slotUpdateColumnWidths()
int usedWidth = 0;
// Now set the actual column widths. If the weighted widths are all greater
// than the minimum widths, just use those, otherwise use the "reajusted
// than the minimum widths, just use those, otherwise use the "readjusted
// weighted width".
foreach(int column, visibleColumns) {
......
......@@ -206,7 +206,7 @@ public:
/**
* Hides column \a c. If \a updateSearch is true then a signal that the
* visible columns have changed will be emitted and things like the search
* will be udated.
* will be updated.
*/
void hideColumn(int c, bool updateSearch = true);
......@@ -265,7 +265,7 @@ public:
PlaylistSearch search() const { return m_search; }
/**
* Set the search associtated with this playlist.
* Set the search associated with this playlist.
*/
void setSearch(const PlaylistSearch &s);
......
......@@ -151,7 +151,7 @@ public:
PlaylistItem *itemAbove() { return static_cast<PlaylistItem *>(treeWidget()->itemAbove(this)); }
/**
* Returns a reference to the list of the currnetly playing items, with the
* Returns a reference to the list of the currently playing items, with the
* first being the "master" item (i.e. the item from which the next track is
* chosen).
*/
......@@ -166,7 +166,7 @@ protected:
PlaylistItem(CollectionListItem *item, Playlist *parent, QTreeWidgetItem *after);
/**
* This is the constructor that shold be used by subclasses.
* This is the constructor that should be used by subclasses.
*/
PlaylistItem(CollectionList *parent);
......
......@@ -80,7 +80,7 @@ private:
};
/**
* A search is built from several search components. These corespond to to lines
* A search is built from several search components. These correspond to to lines
* in the search bar.
*/
......@@ -96,7 +96,7 @@ public:
Component();
/**
* Create a query component. This defaults to searching all visible coulumns.
* Create a query component. This defaults to searching all visible columns.
*/
Component(const QString &query,
bool caseSensitive = false,
......
......@@ -15,8 +15,8 @@
* this program. If not, see <http://www.gnu.org/licenses/>.
*/
#ifndef JUK_SCROBBLESETTINGS_H
#define JUK_SCROBBLESETTINGS_H
#ifndef JUK_SCROBBLECONFIGDLG_H
#define JUK_SCROBBLECONFIGDLG_H
#include <QDialog>
#include <KWallet>
......@@ -54,4 +54,4 @@ private:
std::unique_ptr<Wallet> m_wallet;
};
#endif //JUK_SCROBBLESETTINGS_H
#endif //JUK_SCROBBLECONFIGDLG_H
......@@ -106,7 +106,7 @@ class TimeSlider : public Slider
Q_OBJECT
public:
TimeSlider( QWidget *parent );
explicit TimeSlider( QWidget *parent );
void setSliderValue( int value );
protected:
......
......@@ -27,7 +27,7 @@ template <class T> class Hash : public QSet<T>
public:
/**
* To combine two operations into one (that takes the same amount as each
* independantly) this inserts an item and returns true if the item was
* independently) this inserts an item and returns true if the item was
* already in the set or false if it did not.
*/
inline bool insert(const T &value)
......
......@@ -19,7 +19,7 @@
#include <KLocalizedString>
#include <QtCore/QFile>
#include <QFile>
#include <taglib/tag.h>
#include <tfile.h>
......
......@@ -43,7 +43,7 @@ class TagEditor : public QWidget, public Ui::TagEditor
Q_OBJECT
public:
TagEditor(QWidget *parent = 0);
explicit TagEditor(QWidget *parent = 0);
virtual ~TagEditor();
PlaylistItemList items() const { return m_items; }
void setupObservers();
......
......@@ -27,7 +27,7 @@ class FileNameScheme
typedef QList<FileNameScheme> List;
FileNameScheme() { }
FileNameScheme(const QString &s);
explicit FileNameScheme(const QString &s);
bool matches(const QString &s) const;
......@@ -58,7 +58,7 @@ class TagGuesser
static void setSchemeStrings(const QStringList &schemes);
TagGuesser();
TagGuesser(const QString &absFileName);
explicit TagGuesser(const QString &absFileName);
void guess(const QString &absFileName);
......
......@@ -17,7 +17,7 @@
#ifndef TAGRENAMEROPTIONS_H
#define TAGRENAMEROPTIONS_H
#include <QtCore/QString>
#include <QString>
// Insert all new tag types before NumTypes, that way NumTypes will always be
// the count of valid tag types.
......
......@@ -14,13 +14,13 @@
* this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "tracksequencemanager.h"
#include <KLocalizedString>
#include <kconfig.h>
#include <QAction>
#include "actioncollection.h"
#include "tracksequencemanager.h"
#include "playlist.h"
#include "playlistitem.h"
#include "tracksequenceiterator.h"
......
......@@ -33,7 +33,7 @@ class ViewMode : public QObject
Q_OBJECT
public:
ViewMode(PlaylistBox *b);
explicit ViewMode(PlaylistBox *b);
virtual ~ViewMode();
virtual QString name() const;
......@@ -100,7 +100,7 @@ private:
class CompactViewMode : public ViewMode
{
public:
CompactViewMode(PlaylistBox *b);
explicit CompactViewMode(PlaylistBox *b);
virtual ~CompactViewMode();
virtual QString name() const;
......@@ -125,7 +125,7 @@ class TreeViewMode : public CompactViewMode
Q_OBJECT
public:
TreeViewMode(PlaylistBox *l);
explicit TreeViewMode(PlaylistBox *l);
virtual ~TreeViewMode();
virtual QString name() const;
......
......@@ -34,7 +34,7 @@ class VolumePopupButton : public QToolButton
Q_OBJECT
public:
VolumePopupButton( QWidget * parent );
explicit VolumePopupButton( QWidget * parent );
void refresh();
protected:
......
......@@ -29,7 +29,7 @@ class WebImageFetcher : public QObject
Q_OBJECT
public:
WebImageFetcher(QObject *parent);
explicit WebImageFetcher(QObject *parent);
~WebImageFetcher();
void setFile(const FileHandle &file);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment