1. 26 Aug, 2017 1 commit
  2. 09 Aug, 2017 1 commit
  3. 27 Jul, 2017 2 commits
  4. 26 Jul, 2017 2 commits
  5. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  6. 06 Jan, 2013 1 commit
    • Michael Pyne's avatar
      tunepimp: Fix -Wundef warning with HAVE_TUNEPIMP. · aefb6fb7
      Michael Pyne authored
      Caused by using "feature presence defines config symbol" in some parts
      of the source and using "feature presence makes config symbol true" in
      others.
      
      We standardize on always defining the symbol and using its boolean value
      to indicate feature presence (needs cmakedefine01).
      aefb6fb7
  7. 06 Oct, 2012 1 commit
    • Michael Pyne's avatar
      Fix sorting by full-path column. · 2d583d4c
      Michael Pyne authored
      Reported by Matthew Woehlke, debugged by myself, fix identified by Piotr
      Figiel.
      
      In essence, Q3ListItemView uses an int id to identify each column. JuK
      supports some playlists having additional columns, which is why you see
      references to "offset" scattered throughout the playlist-column-handling
      code.
      
      In this case, our "maximum column id" value is itself a valid column ID,
      so Piotr is entirely correct in fixing the check here. I have recompiled
      and retested and sorting by the Full Path playlist column now works
      properly. Thanks to everyone involved in getting this ancient bug
      stamped out.
      
      BUG:307649
      FIXED-IN:4.9.3
      2d583d4c
  8. 21 Apr, 2012 1 commit
  9. 05 May, 2011 1 commit
    • Michael Pyne's avatar
      Use proper bounds check in comparison function. · f705becf
      Michael Pyne authored
      Fixes an off-by-one comparison check. The check itself is a backup to logic
      errors which don't appear to happen in practice, so no reason to backport, this
      just makes me feel better about its proper functioning.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1230439
      f705becf
  10. 16 Feb, 2009 1 commit
    • Michael Pyne's avatar
      Last crasher bug I fixed was due to not using Playlist::clearItem() to remove... · 2e865464
      Michael Pyne authored
      Last crasher bug I fixed was due to not using Playlist::clearItem() to remove a PlaylistItem.  I think it
      should always be possible to call delete on a PlaylistItem pointer and the Right Thing happens, so do a
      bit of refactoring to ensure that what happens in clearItem() is performed from the PlaylistItem dtor instead
      of running the PlaylistItem dtor from clearItem.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=926748
      2e865464
  11. 09 Feb, 2009 1 commit
    • Michael Pyne's avatar
      local8Bit encodings scare me, so save the QString in the shared... · c052b2d9
      Michael Pyne authored
      local8Bit encodings scare me, so save the QString in the shared PlaylistItem/CollectionListItem metadata
      instead of converting to QByteArray (I don't really think utf-8 would help much since QStrings can buy us
      localeAwareCompare as well).
      
      Also use a standard Qt collection for our StringShare instead of a constant sized hash table.  Probably a
      better way to do this would be a simple cache that tracks how much each string is put in, not sure how much
      that would help though.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=923583
      c052b2d9
  12. 15 Dec, 2008 1 commit
  13. 22 Nov, 2008 1 commit
    • Sebastian Sauer's avatar
      fix crash · 3a1d71df
      Sebastian Sauer authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=887486
      3a1d71df
  14. 24 Aug, 2008 1 commit
    • Michael Pyne's avatar
      JuK optimizapalooza! · c8f53250
      Michael Pyne authored
      * Add whatever X-DBUS-foo line KUniqueApplication says we need.
      * Restructure the startup sequence to postpone all the hard work until after the GUI is setup
        as much as possible to allow passing our reply over DBUS ASAP.
      * Don't call hasCover from PlaylistItem like, ever.  I made CoverInfo::hasCover() take longer
        when I added support for APIC frames but didn't catch all unnecessary instances of their use
        last time.  Luckily this is the big win and is backportable.
      * Also, don't force CoverInfo::coverId() to call hasCover() for no reason.
      
      Hopefully this should remove the egregrious Plasma freeze-ups while starting but even after
      returning from KUniqueApplication::newInstance() quickly it seems to take a while for the reply
      to go over the D-BUS...
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=851610
      c8f53250
  15. 20 May, 2008 1 commit
  16. 13 May, 2008 1 commit
  17. 21 Dec, 2007 1 commit
    • Laurent Montel's avatar
      Fix include · 7d774e73
      Laurent Montel authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=751215
      7d774e73
  18. 17 Aug, 2007 2 commits
  19. 24 May, 2007 1 commit
    • Michael Pyne's avatar
      Fairly large overhaul of the JuK codebase to beat out a lot of the Qt 3 stuff. · 2c297413
      Michael Pyne authored
      Still a lot of Qt 3 code to go but at this point Q3ValueList, Q3Vector, Q3PtrDict and
      Q3Dict should all be gone.
      
      In addition many loops have been foreach()'ed, which really does make it more readable.
      
      There is a crash fix as well, now the polish() function in Playlist has been replaced
      with an initialization slot which is singleShot'ed since the timing of the polish event
      is apparently different than it was in Qt 3, which was making new Playlists crash when
      they were first shown.
      
      Also I went through almost every header and pared it down to the minimum reasonably
      achievable, which required some additional headers in a few .cpp files but overall
      compilation time should be down and you won't have to rebuild all of JuK just because
      a header file got touched.
      
      I haven't seen any regressions yet but then again I still can't play music either.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=667815
      2c297413
  20. 19 May, 2007 1 commit
  21. 14 Oct, 2006 1 commit
  22. 25 Sep, 2006 1 commit
  23. 23 Sep, 2006 2 commits
  24. 15 Sep, 2006 1 commit
    • Dirk Mueller's avatar
      qt3support-- · 3f8260c7
      Dirk Mueller authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=584892
      3f8260c7
  25. 02 May, 2006 1 commit
    • Stephan Kulow's avatar
      deprecated · 64081847
      Stephan Kulow authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=536733
      64081847
  26. 30 Apr, 2006 1 commit
  27. 27 Apr, 2006 1 commit
  28. 13 Mar, 2006 1 commit
  29. 01 Mar, 2006 1 commit
  30. 28 Feb, 2006 1 commit
  31. 26 Feb, 2006 2 commits
  32. 01 Sep, 2005 2 commits
  33. 20 Apr, 2005 1 commit
  34. 22 Feb, 2005 1 commit