1. 18 May, 2019 2 commits
    • Michael Pyne's avatar
      Remove more compiler warnings for deprecated functions/uses. · 44d6bb2d
      Michael Pyne authored
      Still need to get rid of QSignalMapper using lambdas but that will need
      more thought.
      44d6bb2d
    • Michael Pyne's avatar
      Add 'override' decl to fix compiler warnings, fix drag-and-drop. · dc2d9c8e
      Michael Pyne authored
      This should shave off some 1,000+ warnings over the course of a build
      with GCC 9.1.
      
      This only addresses class declarations native to JuK, but Taglib and to
      a lesser extent Qt5 moc still have (or generate) code that can result in
      compiler warnings about suggested override declarations.
      
      In the process I noticed that an existing drag-and-drop support function
      (Playlist::decode) is no longer overriding Qt virtual functions, so it
      has been turned into an auxiliary function to fix existing drag-and-drop
      bugs from the KF5 port (tested by dropping files from Dolphin into a
      playlist view).
      
      Drag-and-drop from a playlist to another playlist (by dropping on the
      playlist name) still remains broken for now.
      
      CCBUG:392705
      FIXED-IN:19.04.2
      dc2d9c8e
  2. 19 Feb, 2019 1 commit
  3. 20 Dec, 2018 1 commit
  4. 11 Nov, 2018 1 commit
    • Michael Pyne's avatar
      hidpi: Mark cover art as being at native display resolution. · c31920fa
      Michael Pyne authored
      This lets Hi-DPI displays to show cover art (when clicking the cover in
      the "Now Playing" bar) at its native resolution even when using screen
      scaling.
      
      This is probably suboptimal for smaller covers but most embedded cover
      art I find in the recent few years is already more than large enough to
      show up fine this way.
      
      CHANGELOG: Show embedded music cover art at native display resolution.
      c31920fa
  5. 01 Oct, 2017 1 commit
    • Michael Pyne's avatar
      Remove Kdelibs4Support. · 1e3b90b8
      Michael Pyne authored
      This required a wide assortment of fixes, including deleting
      needless #include <koldfoo.h> headers, some minor additional porting
      tasks, and adding in includes that were previously only implicitly
      included.
      1e3b90b8
  6. 26 Aug, 2017 3 commits
  7. 25 Aug, 2017 1 commit
  8. 26 Jul, 2017 1 commit
  9. 05 Jul, 2015 1 commit
  10. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  11. 14 Jul, 2013 1 commit
    • Michael Pyne's avatar
      coverinfo: Do not crash if an MP3 file has no ID3 tag. · 0318fb35
      Michael Pyne authored
      This rarely happens since taglib will simply create an ID3 tag if one
      didn't exist before... but taglib can't do this if it can't find the
      file, which now seems to occur for files with a non-UTF8 filename
      encoding.
      
      You see this as a 'Couldn't resolve the mime type of <<foo>> -- this
      shouldn't happen' message on the console. In this situation JuK is able
      to resolve the file to an appropriate TagLib::File subclass, but the
      TagLib object is in an invalid state.
      
      CoverInfo wasn't checking for this (it was assuming any TagLib::File*
      that it was given was valid).
      
      I took a look through the reported JuK crasher bugs and didn't see
      anything relevant.
      
      I'm not sure whether this will end up in the KDE SC 4.11 or 4.11.1.
      0318fb35
  12. 08 May, 2013 1 commit
    • Aaron Seigo's avatar
      unlike mpeg files, MP4::File can return null from tag · b38da7b2
      Aaron Seigo authored
      this is due to taglib implementing it differently for the different
      classes: in MPEG::File, d->tag is allocated on the stack and returned by
      address; in MP4::File d->tag is a pointer that is initialized to null
      and only allocated if everything goes well.
      b38da7b2
  13. 24 Jun, 2012 1 commit
  14. 21 Apr, 2012 1 commit
  15. 19 Apr, 2012 1 commit
  16. 16 Feb, 2009 1 commit
  17. 24 Aug, 2008 1 commit
    • Michael Pyne's avatar
      JuK optimizapalooza! · c8f53250
      Michael Pyne authored
      * Add whatever X-DBUS-foo line KUniqueApplication says we need.
      * Restructure the startup sequence to postpone all the hard work until after the GUI is setup
        as much as possible to allow passing our reply over DBUS ASAP.
      * Don't call hasCover from PlaylistItem like, ever.  I made CoverInfo::hasCover() take longer
        when I added support for APIC frames but didn't catch all unnecessary instances of their use
        last time.  Luckily this is the big win and is backportable.
      * Also, don't force CoverInfo::coverId() to call hasCover() for no reason.
      
      Hopefully this should remove the egregrious Plasma freeze-ups while starting but even after
      returning from KUniqueApplication::newInstance() quickly it seems to take a while for the reply
      to go over the D-BUS...
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=851610
      c8f53250
  18. 14 Jul, 2008 2 commits
    • Michael Pyne's avatar
      dammit: · 251aec92
      Michael Pyne authored
      -    QPixmap returnValue = QPixmap::fromImage(attachedImage);
           return QPixmap::fromImage(attachedImage);
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=832073
      251aec92
    • Michael Pyne's avatar
      More --qt3support: · 114c230a
      Michael Pyne authored
      * Remove support for the cover system used in KDE 3.3.
      * Cover dragging uses "pure" Qt4 now.  Unfortunately the cover manager is
        still Qt 3 so drag-and-drop from there is temporarily disabled.
      * Add a coverId() function that ensures the m_coverId for a CoverInfo is
        properly set before use.
      
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=832069
      114c230a
  19. 13 Jul, 2008 1 commit
    • Michael Pyne's avatar
      Be more careful in the event of a encrypted APIC frame (or compressed with no zlib in TagLib). · 96c26c7f
      Michael Pyne authored
      Code was put in to check for this earlier but was incomplete as although the pointer was correct
      it was still blindly dereferenced.
      
      In addition add QImage header to coverinfo.h (was included indirectly before).
      
      Neither of these need backported based on the rarity of encrypted/uncompressed picture frames but
      I'll probably backport the potential crash fix just in case.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=831705
      96c26c7f
  20. 30 May, 2008 1 commit
    • Pau Garcia i Quiles's avatar
      Make MSVC happy: · 455034ff
      Pau Garcia i Quiles authored
      * Add the taglib directory for includes
      * There is no "libm" in MSVC
      * "typedef unsigned int uint" in two different namespaces and MSVC will think they are two different things. How stupid can it be?
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=814529
      455034ff
  21. 21 May, 2008 1 commit
  22. 13 May, 2008 1 commit
  23. 21 Dec, 2007 1 commit
    • Laurent Montel's avatar
      Fix include · 7d774e73
      Laurent Montel authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=751215
      7d774e73
  24. 03 Aug, 2007 1 commit
  25. 19 May, 2007 1 commit
  26. 10 Apr, 2007 1 commit
    • Laurent Montel's avatar
      Q3Frame-- · d152834f
      Laurent Montel authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=652376
      d152834f
  27. 15 Sep, 2006 1 commit
    • Dirk Mueller's avatar
      qt3support-- · 3f8260c7
      Dirk Mueller authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=584892
      3f8260c7
  28. 09 May, 2006 1 commit
  29. 27 Apr, 2006 1 commit
  30. 26 Feb, 2006 7 commits