1. 31 Jan, 2018 2 commits
    • Michael Pyne's avatar
      Remove the 'emitChanged' hack in Playlist::createItem<> · 894e87d6
      Michael Pyne authored
      Whichever code is creating these items is in the best spot to know
      whether there will be one or many of these items and when the best time
      is to permit the playlist to sync up afterwards.  This permits the
      createItem functions to focus more on just that function.
      894e87d6
    • Michael Pyne's avatar
      Remove FileHandle::null concept and manual memory mgmt. · 3bca3e32
      Michael Pyne authored
      On second thought the whole FileHandle::null thing seems silly now.  It
      made sense as an optimization when it was introduced but the extra
      conceptual baggage is hard to maintain and far less important now.
      3bca3e32
  2. 01 Oct, 2017 1 commit
    • Michael Pyne's avatar
      Remove Kdelibs4Support. · 1e3b90b8
      Michael Pyne authored
      This required a wide assortment of fixes, including deleting
      needless #include <koldfoo.h> headers, some minor additional porting
      tasks, and adding in includes that were previously only implicitly
      included.
      1e3b90b8
  3. 30 Sep, 2017 1 commit
  4. 29 Sep, 2017 1 commit
  5. 26 Aug, 2017 1 commit
  6. 25 Aug, 2017 1 commit
  7. 27 Jul, 2017 1 commit
  8. 26 Jul, 2017 1 commit
  9. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  10. 11 Jun, 2010 1 commit
    • Michael Pyne's avatar
      Finally get the "Time" column to show up in the history playlist. · e225bf7e
      Michael Pyne authored
      Between Qt 3 and Qt 4 the behavior of QWidget::polish() changed. What used to happen is
      that HistoryPlaylist created the first column (column 0) during construction by putting its
      addColumn call in HistoryPlaylist::polish(), which somehow got called before the Playlist
      class added its columns.
      
      In Qt 4 the polish method seems to have gone away, so we have to take different measures to
      ensure that the HistoryPlaylist gets first dibs on making columns. We do this by altering
      the ctor in Playlist to add placeholder columns for subclasses to control later.
      
      This fixes a long-standing JuK bug (since KDE 4.0) that doesn't seem to actually have been
      opened in b.k.o.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1136889
      e225bf7e
  11. 26 Nov, 2009 1 commit
    • Michael Pyne's avatar
      Decouple PlayerManager from JuK so that it isn't a singleton. · c0204770
      Michael Pyne authored
      The major reason for this change is to allow for a saner destruct sequence
      (instead of the unordered global static destruct sequence) which will hopefully
      help reduce crash-on-shutdown bugs.
      
      This will not be in the upcoming KDE 4.4 beta but will be in the 4.4 release (assuming no
      bugs are found in it ;)
      
      CCMAIL:nlecureuil@mandriva.com
      
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1054429
      c0204770
  12. 13 Jan, 2009 2 commits
  13. 11 Nov, 2008 1 commit
  14. 26 Aug, 2008 1 commit
    • Michael Pyne's avatar
      Move much of the createItems<> templated method implementation to a helper function in playlist.cpp · 40c114dd
      Michael Pyne authored
      While doing so I managed to remove the need to have extraneous template types to avoid
      recursive includes so the code is a bit neater now as well.
      
      One functionality change is that items belonging to files that don't exist anymore are not
      created anymore.  Hopefully this will eliminate crashes on startup due to files in the collection
      being deleted between JuK startups.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=852974
      40c114dd
  15. 09 Jan, 2008 1 commit
  16. 29 Sep, 2007 1 commit
  17. 24 May, 2007 1 commit
    • Michael Pyne's avatar
      Fairly large overhaul of the JuK codebase to beat out a lot of the Qt 3 stuff. · 2c297413
      Michael Pyne authored
      Still a lot of Qt 3 code to go but at this point Q3ValueList, Q3Vector, Q3PtrDict and
      Q3Dict should all be gone.
      
      In addition many loops have been foreach()'ed, which really does make it more readable.
      
      There is a crash fix as well, now the polish() function in Playlist has been replaced
      with an initialization slot which is singleShot'ed since the timing of the polish event
      is apparently different than it was in Qt 3, which was making new Playlists crash when
      they were first shown.
      
      Also I went through almost every header and pared it down to the minimum reasonably
      achievable, which required some additional headers in a few .cpp files but overall
      compilation time should be down and you won't have to rebuild all of JuK just because
      a header file got touched.
      
      I haven't seen any regressions yet but then again I still can't play music either.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=667815
      2c297413
  18. 19 May, 2007 1 commit
  19. 11 Apr, 2007 1 commit
  20. 14 Oct, 2006 1 commit
  21. 26 Feb, 2006 1 commit
  22. 01 Sep, 2005 1 commit
  23. 19 Feb, 2005 1 commit
  24. 29 Aug, 2004 1 commit
  25. 26 Jun, 2004 1 commit
    • Scott Wheeler's avatar
      This wasn't really accurate -- don't check to see if the history playlist · 7f1e334f
      Scott Wheeler authored
      is the currently *playing* playlist; we have this wonderful method around
      to see if it's the one playing.  ;-)
      
      This makes it such that if you have the history visible but are playing
      another playlist that pushing forward will continue to add those items to
      the history.
      
      svn path=/trunk/kdemultimedia/juk/; revision=323715
      7f1e334f
  26. 23 Jun, 2004 2 commits
  27. 19 Jun, 2004 1 commit
  28. 03 Jun, 2004 2 commits
    • Scott Wheeler's avatar
      It's 2004 now. Update copyrights. · a624ebbe
      Scott Wheeler authored
      svn path=/trunk/kdemultimedia/juk/; revision=317484
      a624ebbe
    • Scott Wheeler's avatar
      Make the status bar work again by adding a PlaylistObserver class / pattern · 7c48ba7a
      Scott Wheeler authored
      to the playlistinterface.h file that can be subclassed by things that want
      to track playlist changes using the generic API.
      
      This also allowed removing a fair bit of cruft that was being thrown around
      by signals in the Playlist class hierarchy.
      
      This should be split up into two types of updates -- one for track changes
      and another for data changes, but it was convenient in the first go to
      roll them into one.  Splitting them up should be pretty trivial.
      
      svn path=/trunk/kdemultimedia/juk/; revision=317251
      7c48ba7a
  29. 01 Jun, 2004 1 commit
    • Scott Wheeler's avatar
      Ok, big cleanups essentially implimenting the stuff that has been in the · 08f5d033
      Scott Wheeler authored
      TODO for a while:
      
      *) Ditch the PlaylistSplitter class mostly in favor of the PlaylistCollection
      *) Move to a more linear class interaction path rather than having PlaylistSplitter
         as an ugly thing trying to mediate between a bunch of unrelated classes
      *) Rely more heavily on the global action collection and try to instantiate actions
         in the classes that they're related to
      *) Remove a few dozen dirty hacks
      *) Got rid of about 250 lines of code in the process
      
      There are still a couple of outstanding issues but since my home internet connection
      has decided that it doesn't like me at the moment and people are waiting on these
      changes for further work I'm committing.  Stuff that still needs to be done (I'll
      likely finish this tonight and commit it at work tomorrow):
      
      *) Create the Artist / Album / Genre playlists in the Tree View Mode.  This is
         essentially easy, it just requires sticking a new constructor in and making sure
         that it works.
      *) Make it so that the HistoryPlaylist is properly instantiated and shown when its
         asked for
      *) Make sure that the status bar is updated with the current playlist information
      *) Create dynamic playlists on multiple select
      
      While that sounds like quite a bit that's really just a little bit of work, but
      managing such a huge patch set off-line is getting rather tedious and most stuff
      works now.  I should have a patch for the rest tomorrow.
      
      svn path=/trunk/kdemultimedia/juk/; revision=316735
      08f5d033
  30. 12 Apr, 2004 2 commits
  31. 03 Mar, 2004 1 commit
  32. 15 Feb, 2004 1 commit
  33. 09 Nov, 2003 1 commit
  34. 18 Aug, 2003 1 commit
    • Scott Wheeler's avatar
      Ok, the last step in adding "history playlist" support. I implemented · 60d0fbbb
      Scott Wheeler authored
      streaming operators for the new playlist type to save the date that the
      items were played on and integrated this into the rewritten playlist
      caching code.
      
      So basically history works, including restoration.
      
      CCMAIL:61294-done@bugs.kde.org
      
      svn path=/trunk/kdemultimedia/juk/; revision=243375
      60d0fbbb
  35. 10 Aug, 2003 1 commit