1. 20 Dec, 2018 1 commit
  2. 04 Oct, 2017 1 commit
  3. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  4. 04 Jul, 2012 1 commit
  5. 09 May, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: save & restore playlist and tag editor sizes. · 0a9a71c9
      Giorgos Kylafas authored
      editorSplitter is turned to a member variable (m_editorSplitter) whose
      sizes are stored and retrieved the same way as PlaylistSplitter's.
      
      If no sizes were saved, use default sizes for the playlist and the
      editor. The values are just hints for the actual size, m_editorSplitter
      will distribute the space according to their relative weight.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1231059
      0a9a71c9
  6. 11 Jun, 2010 1 commit
    • Michael Pyne's avatar
      Make the history playlist work again. · faf5e09f
      Michael Pyne authored
      In the great PlayerManager de-singletonizing of KDE 4.1 I managed to not port over the
      Qt signal for the playlist splitter that was emitted on track change, which meant the
      history playlist wouldn't receive it. I've reattached the signal to the history playlist
      which means it works[1] again.
      
      [1] It's still as broken as it was in KDE 4.0, which means that the "Date" column doesn't
      show up, and all the other columns are shifted over by one to compensate.
      
      BUG: 168998
      FIXED-IN: 4.5
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1136884
      faf5e09f
  7. 26 Nov, 2009 1 commit
    • Michael Pyne's avatar
      Decouple PlayerManager from JuK so that it isn't a singleton. · c0204770
      Michael Pyne authored
      The major reason for this change is to allow for a saner destruct sequence
      (instead of the unordered global static destruct sequence) which will hopefully
      help reduce crash-on-shutdown bugs.
      
      This will not be in the upcoming KDE 4.4 beta but will be in the 4.4 release (assuming no
      bugs are found in it ;)
      
      CCMAIL:nlecureuil@mandriva.com
      
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1054429
      c0204770
  8. 04 Feb, 2009 1 commit
    • Michael Pyne's avatar
      Two bugfixes: · 5f913836
      Michael Pyne authored
      1. Don't allow JuK to shutdown until Phonon has definitely returned to StoppedState to prevent some backends
      from crashing on shutdown.
      
      2. Delay system tray creation until after the collection list has been loaded from the cache.  If we're
      trying to create the system tray before this process then half the time we end up freezing all of Plasma
      until the cache finally loads, which is especially noticable on initial KDE startup.
      
      I will give this a few days of testing in /trunk and will then probably backport both.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=921339
      5f913836
  9. 29 Jan, 2009 1 commit
  10. 20 Jan, 2009 1 commit
  11. 24 Aug, 2008 1 commit
    • Michael Pyne's avatar
      JuK optimizapalooza! · c8f53250
      Michael Pyne authored
      * Add whatever X-DBUS-foo line KUniqueApplication says we need.
      * Restructure the startup sequence to postpone all the hard work until after the GUI is setup
        as much as possible to allow passing our reply over DBUS ASAP.
      * Don't call hasCover from PlaylistItem like, ever.  I made CoverInfo::hasCover() take longer
        when I added support for APIC frames but didn't catch all unnecessary instances of their use
        last time.  Luckily this is the big win and is backportable.
      * Also, don't force CoverInfo::coverId() to call hasCover() for no reason.
      
      Hopefully this should remove the egregrious Plasma freeze-ups while starting but even after
      returning from KUniqueApplication::newInstance() quickly it seems to take a while for the reply
      to go over the D-BUS...
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=851610
      c8f53250
  12. 04 Jun, 2007 1 commit
  13. 24 May, 2007 1 commit
    • Michael Pyne's avatar
      Fairly large overhaul of the JuK codebase to beat out a lot of the Qt 3 stuff. · 2c297413
      Michael Pyne authored
      Still a lot of Qt 3 code to go but at this point Q3ValueList, Q3Vector, Q3PtrDict and
      Q3Dict should all be gone.
      
      In addition many loops have been foreach()'ed, which really does make it more readable.
      
      There is a crash fix as well, now the polish() function in Playlist has been replaced
      with an initialization slot which is singleShot'ed since the timing of the polish event
      is apparently different than it was in Qt 3, which was making new Playlists crash when
      they were first shown.
      
      Also I went through almost every header and pared it down to the minimum reasonably
      achievable, which required some additional headers in a few .cpp files but overall
      compilation time should be down and you won't have to rebuild all of JuK just because
      a header file got touched.
      
      I haven't seen any regressions yet but then again I still can't play music either.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=667815
      2c297413
  14. 18 May, 2007 1 commit
  15. 27 Feb, 2006 1 commit
  16. 26 Feb, 2006 1 commit
  17. 01 Sep, 2005 1 commit
  18. 13 Jun, 2005 1 commit
  19. 04 Jun, 2005 1 commit
    • Scott Wheeler's avatar
      My most hated JuK bug in 3.4 (so this will be backported shortly) -- when · a266e338
      Scott Wheeler authored
      switching playlists the setSearch() call was being called before visiblePlaylist()
      reported the new playlist, so it was basically clearing the search term for the
      playlist that was about to go to the background.  This meant that when you switch
      back to it your search is cleared.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=422080
      a266e338
  20. 17 May, 2005 1 commit
  21. 15 Jan, 2005 1 commit
  22. 09 Nov, 2004 1 commit
  23. 08 Nov, 2004 1 commit
  24. 29 Oct, 2004 1 commit
  25. 30 Sep, 2004 1 commit
  26. 28 Sep, 2004 1 commit
  27. 22 Jul, 2004 1 commit
  28. 04 Jun, 2004 1 commit
    • Scott Wheeler's avatar
      fixincludes · 0660bead
      Scott Wheeler authored
      svn path=/trunk/kdemultimedia/juk/; revision=317624
      0660bead
  29. 03 Jun, 2004 1 commit
  30. 01 Jun, 2004 1 commit
    • Scott Wheeler's avatar
      Ok, big cleanups essentially implimenting the stuff that has been in the · 08f5d033
      Scott Wheeler authored
      TODO for a while:
      
      *) Ditch the PlaylistSplitter class mostly in favor of the PlaylistCollection
      *) Move to a more linear class interaction path rather than having PlaylistSplitter
         as an ugly thing trying to mediate between a bunch of unrelated classes
      *) Rely more heavily on the global action collection and try to instantiate actions
         in the classes that they're related to
      *) Remove a few dozen dirty hacks
      *) Got rid of about 250 lines of code in the process
      
      There are still a couple of outstanding issues but since my home internet connection
      has decided that it doesn't like me at the moment and people are waiting on these
      changes for further work I'm committing.  Stuff that still needs to be done (I'll
      likely finish this tonight and commit it at work tomorrow):
      
      *) Create the Artist / Album / Genre playlists in the Tree View Mode.  This is
         essentially easy, it just requires sticking a new constructor in and making sure
         that it works.
      *) Make it so that the HistoryPlaylist is properly instantiated and shown when its
         asked for
      *) Make sure that the status bar is updated with the current playlist information
      *) Create dynamic playlists on multiple select
      
      While that sounds like quite a bit that's really just a little bit of work, but
      managing such a huge patch set off-line is getting rather tedious and most stuff
      works now.  I should have a patch for the rest tomorrow.
      
      svn path=/trunk/kdemultimedia/juk/; revision=316735
      08f5d033
  31. 13 May, 2004 2 commits
  32. 19 Apr, 2004 1 commit
  33. 15 Apr, 2004 1 commit
  34. 14 Apr, 2004 2 commits
    • Scott Wheeler's avatar
      Do The Right Thing (tm) when one of the tree view categories is selected · 07fb12bf
      Scott Wheeler authored
      rather than a real playlist -- mark disabled the appropriate context menu
      items.
      
      This code was moved directly into the PlaylistBox class rather than trying
      to push the information up through the PlaylistSplitter class in to the JuK
      API.  This allowed several PlaylistSplitter methods to be removed.
      
      Sadly this change is too invasive (and based too heavily on other changes)
      and the bug too obscure to bother spent the time trying to backport it (it
      would have to be a completely different fix), but this will be fixed in 3.3.
      
      CCMAIL:73972-done@bugs.kde.org
      
      svn path=/trunk/kdemultimedia/juk/; revision=303817
      07fb12bf
    • Scott Wheeler's avatar
      Make it possible to rescan the collection by clicking on reload in the RMB · 83fc299b
      Scott Wheeler authored
      or file menu.
      
      CCMAIL:65805-done@bugs.kde.org
      
      svn path=/trunk/kdemultimedia/juk/; revision=303503
      83fc299b
  35. 12 Apr, 2004 2 commits
  36. 10 Apr, 2004 1 commit
  37. 09 Apr, 2004 1 commit