1. 21 Feb, 2018 2 commits
  2. 13 Feb, 2018 2 commits
  3. 11 Feb, 2018 1 commit
  4. 10 Feb, 2018 5 commits
    • Michael Pyne's avatar
      Extract Playlist::SharedSettings into a separate file. · 90a6b862
      Michael Pyne authored
      This helps declutter playlist.cpp and even makes it seem a bit easier to
      read through, I think.
      
      I also tried to fix a couple of outstanding bugs along the way, for
      instance reordering columns should work now, although there's still a
      lot of improvements that need to be made here.
      90a6b862
    • Michael Pyne's avatar
      Stop playback before taking shutdown actions. · 18eed01d
      Michael Pyne authored
      This seems to prevent a gstreamer deadlock I sometimes get when trying
      to quit, though it's only a guess as to whether this is the cause or
      not.
      18eed01d
    • Michael Pyne's avatar
      More column-handling bugfixes in Playlist. · 2ea8a84d
      Michael Pyne authored
      - The showColumn/hideColumn functions work on visual indices, not
      logical indices, so converting a visual index to a logical one is both
      wrong and extra work.
      - The "Show Columns" menu was just flatly checking every column, even
      the ones that weren't shown.
      2ea8a84d
    • Kacper Kasper's avatar
      Fix columns sorting. · cd8e9200
      Kacper Kasper authored
      Summary:
      QTreeWidgetItem in Qt5 requires overloading < operator to implement
      custom sorting. Use existing compare methods to do that.
      
      Additionally, natural sorting was implemented for strings.
      This allows to sort by filenames like file_<number>.
      
      BUG:389130
      
      Test Plan:
      Click on columns to sort them.
      Columns are sorted by artist, album and track number.
      
      Reviewers: mpyne
      
      Differential Revision: https://phabricator.kde.org/D10130
      cd8e9200
    • Michael Pyne's avatar
      Avoid crash on tree view mode by disabling tree view mode :( · 5982cede
      Michael Pyne authored
      I can't decipher the brokenness here in a way that will lead to a quick
      fix, so disable the broken feature for now to avoid causing needless
      crashes for a feature that currently doesn't work at all.
      
      BUG:389937
      FIXED-IN:17.12.3
      5982cede
  5. 03 Feb, 2018 2 commits
    • Michael Pyne's avatar
      GIT_SILENT modernize some comments. · a5dcba16
      Michael Pyne authored
      a5dcba16
    • Michael Pyne's avatar
      Bring back a visual indication of the playing item. · 0dd849ec
      Michael Pyne authored
      Turned out to be surprisingly more difficult than I thought, so
      hopefully no additional bugs.
      
      In particular some Phonon backends seem to insert a trip to a
      StoppedState when changing the MediaObject's current source, so I had to
      find a way around that to be able to call Playlist::stop() from
      PlaylistCollection (which is what actually clears the visual indication
      when playback stops).
      0dd849ec
  6. 02 Feb, 2018 2 commits
  7. 01 Feb, 2018 5 commits
  8. 31 Jan, 2018 5 commits
  9. 28 Jan, 2018 1 commit
    • Kacper Kasper's avatar
      Fix columns sorting. · 81c0dcc2
      Kacper Kasper authored
      Summary:
      QTreeWidgetItem in Qt5 requires overloading < operator to implement
      custom sorting. Use existing compare methods to do that.
      
      Additionally, natural sorting was implemented for strings.
      This allows to sort by filenames like file_<number>.
      
      BUG:389130
      
      Test Plan:
      Click on columns to sort them.
      Columns are sorted by artist, album and track number.
      
      Reviewers: mpyne
      
      Differential Revision: https://phabricator.kde.org/D10130
      81c0dcc2
  10. 19 Jan, 2018 3 commits
  11. 11 Jan, 2018 1 commit
  12. 04 Jan, 2018 1 commit
  13. 11 Dec, 2017 2 commits
  14. 04 Dec, 2017 1 commit
  15. 03 Dec, 2017 1 commit
    • Michael Pyne's avatar
      Remove FindTunePimp CMake module. · 3df63ba0
      Michael Pyne authored
      Leaving the references to libtunepimp in CMakeLists.txt and JuK source
      code in for now as a prompt to get the functionality migrated.
      3df63ba0
  16. 02 Dec, 2017 2 commits
  17. 30 Nov, 2017 1 commit
  18. 29 Nov, 2017 1 commit
  19. 13 Nov, 2017 2 commits