1. 01 Oct, 2017 1 commit
    • Michael Pyne's avatar
      Remove Kdelibs4Support. · 1e3b90b8
      Michael Pyne authored
      This required a wide assortment of fixes, including deleting
      needless #include <koldfoo.h> headers, some minor additional porting
      tasks, and adding in includes that were previously only implicitly
      included.
      1e3b90b8
  2. 26 Aug, 2017 3 commits
  3. 25 Aug, 2017 1 commit
  4. 26 Jul, 2017 1 commit
  5. 05 Jul, 2015 1 commit
  6. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  7. 14 Jul, 2013 1 commit
    • Michael Pyne's avatar
      coverinfo: Do not crash if an MP3 file has no ID3 tag. · 0318fb35
      Michael Pyne authored
      This rarely happens since taglib will simply create an ID3 tag if one
      didn't exist before... but taglib can't do this if it can't find the
      file, which now seems to occur for files with a non-UTF8 filename
      encoding.
      
      You see this as a 'Couldn't resolve the mime type of <<foo>> -- this
      shouldn't happen' message on the console. In this situation JuK is able
      to resolve the file to an appropriate TagLib::File subclass, but the
      TagLib object is in an invalid state.
      
      CoverInfo wasn't checking for this (it was assuming any TagLib::File*
      that it was given was valid).
      
      I took a look through the reported JuK crasher bugs and didn't see
      anything relevant.
      
      I'm not sure whether this will end up in the KDE SC 4.11 or 4.11.1.
      0318fb35
  8. 08 May, 2013 1 commit
    • Aaron Seigo's avatar
      unlike mpeg files, MP4::File can return null from tag · b38da7b2
      Aaron Seigo authored
      this is due to taglib implementing it differently for the different
      classes: in MPEG::File, d->tag is allocated on the stack and returned by
      address; in MP4::File d->tag is a pointer that is initialized to null
      and only allocated if everything goes well.
      b38da7b2
  9. 24 Jun, 2012 1 commit
  10. 21 Apr, 2012 1 commit
  11. 19 Apr, 2012 1 commit
  12. 16 Feb, 2009 1 commit
  13. 24 Aug, 2008 1 commit
    • Michael Pyne's avatar
      JuK optimizapalooza! · c8f53250
      Michael Pyne authored
      * Add whatever X-DBUS-foo line KUniqueApplication says we need.
      * Restructure the startup sequence to postpone all the hard work until after the GUI is setup
        as much as possible to allow passing our reply over DBUS ASAP.
      * Don't call hasCover from PlaylistItem like, ever.  I made CoverInfo::hasCover() take longer
        when I added support for APIC frames but didn't catch all unnecessary instances of their use
        last time.  Luckily this is the big win and is backportable.
      * Also, don't force CoverInfo::coverId() to call hasCover() for no reason.
      
      Hopefully this should remove the egregrious Plasma freeze-ups while starting but even after
      returning from KUniqueApplication::newInstance() quickly it seems to take a while for the reply
      to go over the D-BUS...
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=851610
      c8f53250
  14. 14 Jul, 2008 2 commits
    • Michael Pyne's avatar
      dammit: · 251aec92
      Michael Pyne authored
      -    QPixmap returnValue = QPixmap::fromImage(attachedImage);
           return QPixmap::fromImage(attachedImage);
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=832073
      251aec92
    • Michael Pyne's avatar
      More --qt3support: · 114c230a
      Michael Pyne authored
      * Remove support for the cover system used in KDE 3.3.
      * Cover dragging uses "pure" Qt4 now.  Unfortunately the cover manager is
        still Qt 3 so drag-and-drop from there is temporarily disabled.
      * Add a coverId() function that ensures the m_coverId for a CoverInfo is
        properly set before use.
      
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=832069
      114c230a
  15. 13 Jul, 2008 1 commit
    • Michael Pyne's avatar
      Be more careful in the event of a encrypted APIC frame (or compressed with no zlib in TagLib). · 96c26c7f
      Michael Pyne authored
      Code was put in to check for this earlier but was incomplete as although the pointer was correct
      it was still blindly dereferenced.
      
      In addition add QImage header to coverinfo.h (was included indirectly before).
      
      Neither of these need backported based on the rarity of encrypted/uncompressed picture frames but
      I'll probably backport the potential crash fix just in case.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=831705
      96c26c7f
  16. 30 May, 2008 1 commit
    • Pau Garcia i Quiles's avatar
      Make MSVC happy: · 455034ff
      Pau Garcia i Quiles authored
      * Add the taglib directory for includes
      * There is no "libm" in MSVC
      * "typedef unsigned int uint" in two different namespaces and MSVC will think they are two different things. How stupid can it be?
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=814529
      455034ff
  17. 21 May, 2008 1 commit
  18. 13 May, 2008 1 commit
  19. 21 Dec, 2007 1 commit
    • Laurent Montel's avatar
      Fix include · 7d774e73
      Laurent Montel authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=751215
      7d774e73
  20. 03 Aug, 2007 1 commit
  21. 19 May, 2007 1 commit
  22. 10 Apr, 2007 1 commit
    • Laurent Montel's avatar
      Q3Frame-- · d152834f
      Laurent Montel authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=652376
      d152834f
  23. 15 Sep, 2006 1 commit
    • Dirk Mueller's avatar
      qt3support-- · 3f8260c7
      Dirk Mueller authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=584892
      3f8260c7
  24. 09 May, 2006 1 commit
  25. 27 Apr, 2006 1 commit
  26. 26 Feb, 2006 7 commits
  27. 07 Feb, 2006 1 commit
  28. 01 Sep, 2005 1 commit
  29. 11 Jul, 2005 1 commit
    • Michael Pyne's avatar
      Big huge update. · 9d9cda29
      Michael Pyne authored
      Make random play work better.  Before only the old style unused random list was
      being updated when a playlist changed.  In addition, there are a lot of
      improvements to the new cover support.
      * You can drag-and-drop covers onto playlist items.  Right now only selected
        items are altered even if you drag onto a
        different item, so I'll have to change that.
      * Clearing a cover from a track no longer removes it from every track using
        that cover.
      * Replacing a track's cover works again as well.
      
      I'm sure that both features could use more work so I guess it's back to the
      grindstone for me, I just wish I had more time. :(
      CCBUG: 94866
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=433499
      9d9cda29
  30. 16 May, 2005 2 commits
    • Michael Pyne's avatar
      Speed up import of old style covers by not moving them until it's really really · 43c951c0
      Michael Pyne authored
      necessary.  This could probably be improved further, stay tuned...
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=414475
      43c951c0
    • Michael Pyne's avatar
      Add a CoverManager class to JuK (with a shockingly minimal GUI). It will · b6de380b
      Michael Pyne authored
      import covers stored in the original format, so starting up JuK for the first
      time with this code will probably take awhile, after that the speed should be
      unaffected.
      
      The CoverManager is capable of associating a track with an arbitrary cover.
      Each cover in the CoverManager can have associated with it an Artist and
      Album to allow for automatically applying covers to newly added tracks.
      However now the cover for a track isn't internally limited based on its
      Artist and Album info.
      
      Note that this needs some fleshing out.  The GUI will definitely need some
      improvement, and some things may not work exactly like they used to, but at
      least we've got a good base under us now.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=414471
      b6de380b