1. 03 Feb, 2018 1 commit
    • Michael Pyne's avatar
      Bring back a visual indication of the playing item. · 0dd849ec
      Michael Pyne authored
      Turned out to be surprisingly more difficult than I thought, so
      hopefully no additional bugs.
      
      In particular some Phonon backends seem to insert a trip to a
      StoppedState when changing the MediaObject's current source, so I had to
      find a way around that to be able to call Playlist::stop() from
      PlaylistCollection (which is what actually clears the visual indication
      when playback stops).
      0dd849ec
  2. 01 Oct, 2017 1 commit
    • Michael Pyne's avatar
      Remove Kdelibs4Support. · 1e3b90b8
      Michael Pyne authored
      This required a wide assortment of fixes, including deleting
      needless #include <koldfoo.h> headers, some minor additional porting
      tasks, and adding in includes that were previously only implicitly
      included.
      1e3b90b8
  3. 30 Sep, 2017 1 commit
  4. 29 Sep, 2017 3 commits
  5. 30 Aug, 2017 1 commit
  6. 27 Aug, 2017 2 commits
    • Michael Pyne's avatar
      Cleanup AdvancedSearchPlaylist. · 647e8ce5
      Michael Pyne authored
      - Port away from K[HV]Box
      - Port away from KDialog
      - It's been 10 years since you could make a SearchPlaylist from the
      track search widget, remove the dead code.
      
      SearchPlaylist still doesn't work but at least there are fewer warnings
      and you can at least make it to the AdvancedSearchDialog again.
      647e8ce5
    • Michael Pyne's avatar
      More QAction streamlining. · 2889fd1f
      Michael Pyne authored
      - Use KActionCollection::setDefaultShortcut to reduce warnings
      - Use QKeySequence instead of deprecated KShortcut
      2889fd1f
  7. 26 Aug, 2017 5 commits
  8. 25 Aug, 2017 2 commits
  9. 27 Jul, 2017 1 commit
  10. 26 Jul, 2017 2 commits
  11. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  12. 29 Jun, 2013 1 commit
    • Michael Pyne's avatar
      play-queue: Remove an unneeded processEvents. · d2dcd686
      Michael Pyne authored
      The effect is simulated by using deleteLater(). I have been unable to
      reproduce any crash this way so hopefully whatever is mentioned in the
      old comment does not apply to this new code.
      d2dcd686
  13. 26 Jun, 2013 1 commit
    • Michael Pyne's avatar
      startup: Async-ify cached item loading on startup, add timers. · bf4df116
      Michael Pyne authored
      In an attempt to get rid of processEvents() (related to several existing
      crash bugs) I am trying to port the startup code towards more
      async-friendly schemes.
      
      There's no threading but we at least get back to the event loop much
      more frequently while loading files.
      
      Additionally I have added debug output with instrumentation to show how
      long it takes to advance through each step of the startup (I think this
      might be the first time anyone has understood JuK startup sequence in
      years).
      
      This leaves some essentially dead code with Cache (which no longer
      acts as a container), which I will try to cleanup in later commits.
      bf4df116
  14. 26 May, 2013 1 commit
    • Tom Li's avatar
      folder-scan: Support a list of folders to ignore when auto-scanning. · 2f18ba1e
      Tom Li authored
      Feature initially authored by Tom Li (see the Review Request and bug for
      more details).
      
      The idea is that the Manage Folders dialog now will have a list of
      folders that should not be automatically searched (which would override
      the list of folders to scan on startup). This way you can avoid having
      to completely change up your music layout on-disk just to keep JuK from
      automatically grabbing songs you don't want or need managed from within
      JuK.
      
      I ended up having to rework a bit to fix some corner cases (such as the
      directory watcher which might flag new files under an excluded directory
      after JuK startup), and avoid accidentally removing the ability to
      manually select files under these excluded directories for addition to
      the collection.
      
      If a user does want to remove files that are already in the collection
      list, they can enable the "File Name (Full Path)" column and then use
      the search bar to find the offending path name, and select and remove
      the files that are shown.
      
      Note for posterity that the "Fixed In" version specifies the next
      KDE-wide Software Compilation release, not the internal JuK version.
      
      Thanks again to Tom for drafting the initial patch and being
      extraordinarily patient while I tried to find time to review, re-review,
      and make the finishing touches.
      
      GUI:
      REVIEW:110273
      FEATURE:319106
      FIXED-IN:4.11
      2f18ba1e
  15. 06 Jan, 2013 1 commit
    • Michael Pyne's avatar
      tunepimp: Fix -Wundef warning with HAVE_TUNEPIMP. · aefb6fb7
      Michael Pyne authored
      Caused by using "feature presence defines config symbol" in some parts
      of the source and using "feature presence makes config symbol true" in
      others.
      
      We standardize on always defining the symbol and using its boolean value
      to indicate feature presence (needs cmakedefine01).
      aefb6fb7
  16. 24 Feb, 2012 1 commit
  17. 10 Aug, 2011 1 commit
    • Jan Gerrit Marker's avatar
      juk: Style fix and filter fix · 06ea5a2f
      Jan Gerrit Marker authored
      If artist was empty and you clicked on the album name
      of the now playing track you did get an empty list
      instead of a list of the album's songs.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1246186
      06ea5a2f
  18. 31 Jul, 2011 1 commit
  19. 24 May, 2011 1 commit
    • Giorgos Kylafas's avatar
      juk: fix showing the items of all the selected playlists. · aded1d93
      Giorgos Kylafas authored
      When two or more playlists are selected from the PlaylistBox to the
      left, a dynamic playlist is used which shows the union of their
      contents. However, the first time this dynamic playlist is created, it
      has to be set up properly, otherwise only the contents of the first
      selected playlist will be shown.
      
      More specifically, if it is not set up, i.e. not added to the stack of
      playlists, QStackedWidget::setCurrentWidget() fails complaining that
      "widget 0x... not contained in stack".
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1233429
      aded1d93
  20. 22 Sep, 2010 1 commit
  21. 11 Jun, 2010 1 commit
    • Michael Pyne's avatar
      Make the history playlist work again. · faf5e09f
      Michael Pyne authored
      In the great PlayerManager de-singletonizing of KDE 4.1 I managed to not port over the
      Qt signal for the playlist splitter that was emitted on track change, which meant the
      history playlist wouldn't receive it. I've reattached the signal to the history playlist
      which means it works[1] again.
      
      [1] It's still as broken as it was in KDE 4.0, which means that the "Date" column doesn't
      show up, and all the other columns are shifted over by one to compensate.
      
      BUG: 168998
      FIXED-IN: 4.5
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1136884
      faf5e09f
  22. 26 Nov, 2009 1 commit
    • Michael Pyne's avatar
      Decouple PlayerManager from JuK so that it isn't a singleton. · c0204770
      Michael Pyne authored
      The major reason for this change is to allow for a saner destruct sequence
      (instead of the unordered global static destruct sequence) which will hopefully
      help reduce crash-on-shutdown bugs.
      
      This will not be in the upcoming KDE 4.4 beta but will be in the 4.4 release (assuming no
      bugs are found in it ;)
      
      CCMAIL:nlecureuil@mandriva.com
      
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1054429
      c0204770
  23. 20 Sep, 2009 1 commit
  24. 17 Aug, 2009 1 commit
  25. 04 Jul, 2009 2 commits
  26. 20 Jan, 2009 1 commit
  27. 11 Jan, 2009 1 commit
    • Michael Pyne's avatar
      Bump copyright year. · 3ad4a895
      Michael Pyne authored
      Fix "file-import" icon used when libtunepimp is not available.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=909542
      3ad4a895
  28. 11 Nov, 2008 1 commit
  29. 20 Sep, 2008 1 commit
  30. 18 Sep, 2008 1 commit