1. 28 Feb, 2019 1 commit
  2. 19 Feb, 2019 2 commits
  3. 03 Feb, 2019 1 commit
  4. 20 Jan, 2019 1 commit
  5. 06 Jan, 2019 1 commit
  6. 03 Jan, 2019 2 commits
  7. 27 Dec, 2018 2 commits
  8. 26 Dec, 2018 2 commits
  9. 22 Dec, 2018 2 commits
    • Michael Pyne's avatar
      Port sort function for list of playlists to KF5. · 468a5169
      Michael Pyne authored
      Now that sorting is enabled, it turned out that the sort really was
      broken for everybody (sorry!). The old Qt 3 and 4 "sort by subclassing
      the list item" feature wasn't actually ported into the Qt 5
      compatibilility list view. So although we were defining the compare
      function, nothing was actually using it.
      
      Things seemed to work fine on my local system but I suspect that's
      because I had playlists from KDE 4 times that I copied over which would
      have already sorted the special playlists to the beginning.
      
      Since the old method doesn't work I've just added a hidden sort key
      column for now. The "proper solution" is probably to use a
      QSortFilterProxyModel but that will be some time away.
      
      CHANGELOG:Restore proper sorting of the list of playlists.
      BUG:402398
      FIXED-IN:18.12.1
      468a5169
    • Michael Pyne's avatar
      Force sorting on so that special playlist sort to top. · dc3124e4
      Michael Pyne authored
      That is, so that special playlists hopefully sort to the top. Although
      the sorting of special playlists (Collection List, Play Queue, etc.) has
      worked for me since the port to KF5, I have a good report that it
      doesn't for others.
      
      The code itself appears correct but reviewing the Qt documentation
      indicates that QTreeWidget (which is one of the base classes for the
      list of playlists) doesn't sort by default.
      
      If QTreeWidget doesn't sort, then the comparison function might not be
      getting called at all, which would make it accident that it seems to
      work for me.
      
      CCBUG:402398
      dc3124e4
  10. 21 Dec, 2018 1 commit
    • Michael Pyne's avatar
      Fix the "Show Columns" menu to show correct state on startup. · f9721878
      Michael Pyne authored
      The "Show Columns" menu would previously have a checkbox entered for
      every possible column for the playlist shown by default at JuK startup,
      even though most columns were not visible.
      
      This turned out to be because the class that reads the column
      configuration (Playlist::SharedSettings) was not being used to generate
      the Show Columns menu options. Instead the Playlist's own (defaulted)
      values were used.
      
      At this point in execution we can't force SharedSettings->apply() to run
      because the Playlist is not fully setup. Instead we expose the config
      values and use those to generate the menu.
      f9721878
  11. 20 Dec, 2018 1 commit
    • Michael Pyne's avatar
      Disable tag updating from inline editor. · c6afa4c5
      Michael Pyne authored
      This mitigates a potential data-loss situation that might happen when
      adding new music items:
      
        Juk starts processing the new items in addFiles,
        Results in a new CollectionListItem being created,
        The resultant PlaylistItem superclass calls setFlags,
        This causes Qt to send a *data* changed signal from the QTreeWidget
          holding all the playlist items, saying that a *different*
          QTreeWidgetItem / PlaylistItem has been changed.
        This signal is normally only possible because of user interaction with
          the inline editor. As a result JuK assumes the signal is a user
          request to edit the track's tag, and does so. I have seen this
          cause existing files to take on the same tag values as one of the
          incoming new tracks.
      
      Although in theory a user could immediately select the "Undo" command to
      fix this, that's not a very good workaround. Since we have a separate
      tag editor already, we'll just use that instead until we can figure out
      a way to ensure that dataChanged signals are sent only when the data
      itself has changed (not just flags caused by unrelated items being
      created).
      
      CHANGELOG: Prevent opening new items from inadvertently editing track metadata on existing items.
      FIXED-IN:18.12.1
      c6afa4c5
  12. 12 Dec, 2018 1 commit
  13. 04 Dec, 2018 1 commit
  14. 01 Dec, 2018 1 commit
  15. 26 Nov, 2018 1 commit
  16. 11 Nov, 2018 3 commits
    • Michael Pyne's avatar
      hidpi: Port remaining icon uses to use QIcon for HiDPI support. · 1862b0f6
      Michael Pyne authored
      GUI: This fixes things like the warning icons in the file deletion
      dialog, file renamer, menu icons (such as Create Playlist from Selected
      Items), and the "Jump to Playing Track" button on the status bar.
      
      The track position slider remains unfixed.
      1862b0f6
    • Michael Pyne's avatar
      hidpi: Mark cover art as being at native display resolution. · c31920fa
      Michael Pyne authored
      This lets Hi-DPI displays to show cover art (when clicking the cover in
      the "Now Playing" bar) at its native resolution even when using screen
      scaling.
      
      This is probably suboptimal for smaller covers but most embedded cover
      art I find in the recent few years is already more than large enough to
      show up fine this way.
      
      CHANGELOG: Show embedded music cover art at native display resolution.
      c31920fa
    • Michael Pyne's avatar
      Enable Qt support for High DPI icons. · 0ad0ee58
      Michael Pyne authored
      As submitted by Guo Yunhe <i@guoyunhe.me> on kde-multimedia.
      
      In my testing this only applies with QT_AUTO_SCREEN_SCALE_FACTOR
      environment variable enabled, but does indeed allow for many (not all)
      pixmaps to automatically load high-res versions (such as from
      KIconLoader).
      
      I consider this a bugfix and the support is non-invasive, so applying to
      18.12 and will merge to master separately.
      
      Note that the cover art and slider art is still suboptimal.
      0ad0ee58
  17. 09 Nov, 2018 1 commit
  18. 07 Nov, 2018 1 commit
  19. 20 Oct, 2018 2 commits
    • Michael Pyne's avatar
      Merge branch 'Applications/18.08' · b4cdf1c1
      Michael Pyne authored
      Conflicts:
      	playermanager.cpp
      b4cdf1c1
    • Michael Pyne's avatar
      systray: Make SHIFT+Mousewheel change the volume, not the song. · e2012e79
      Michael Pyne authored
      This fixes a bug that recently hit its 8 year anniversary. :(
      
      The big issue was that there was no easy way to tell which keyboard
      modifiers were set for the systray since Qt's event loop didn't actually
      receive the keyboard events.
      
      There's a separate function you can call, queryKeyboardModifiers, which
      makes a specific query to the desktop, and works even if Qt event loop
      didn't receive keyboard events. This fixes the bug here, and hopefully
      for everyone else.
      
      In fixing the bug I noticed that we can set out-of-bounds volumes due to
      lack of checking, so I fixed that too.
      
      BUG:250355
      FIXED-IN:18.08.3
      e2012e79
  20. 19 Oct, 2018 6 commits
  21. 10 Oct, 2018 2 commits
  22. 07 Oct, 2018 3 commits
  23. 03 Oct, 2018 1 commit
  24. 26 Sep, 2018 1 commit
    • Luigi Toscano's avatar
      LyricWiki: link to the actual lyrics page · eb1d9b62
      Luigi Toscano authored
      Summary:
      Instead of pointing to the homepage of the wiki,
      set the link to the actual page of the lyrics
      which are being shown.
      
      BUG: 332664
      FIXED-IN: 18.12.0
      
      Test Plan:
      The link to the LyricsWiki points to the actual page.
      Nothing changes when the lyrics are not found.
      
      Reviewers: mpyne
      
      Reviewed By: mpyne
      
      Differential Revision: https://phabricator.kde.org/D15303
      eb1d9b62