1. 06 Jul, 2019 1 commit
  2. 05 Jul, 2019 2 commits
  3. 23 Jun, 2019 3 commits
  4. 11 Jun, 2019 1 commit
  5. 31 May, 2019 1 commit
  6. 18 May, 2019 1 commit
    • Michael Pyne's avatar
      Add 'override' decl to fix compiler warnings, fix drag-and-drop. · dc2d9c8e
      Michael Pyne authored
      This should shave off some 1,000+ warnings over the course of a build
      with GCC 9.1.
      
      This only addresses class declarations native to JuK, but Taglib and to
      a lesser extent Qt5 moc still have (or generate) code that can result in
      compiler warnings about suggested override declarations.
      
      In the process I noticed that an existing drag-and-drop support function
      (Playlist::decode) is no longer overriding Qt virtual functions, so it
      has been turned into an auxiliary function to fix existing drag-and-drop
      bugs from the KF5 port (tested by dropping files from Dolphin into a
      playlist view).
      
      Drag-and-drop from a playlist to another playlist (by dropping on the
      playlist name) still remains broken for now.
      
      CCBUG:392705
      FIXED-IN:19.04.2
      dc2d9c8e
  7. 02 May, 2019 1 commit
  8. 30 Apr, 2019 1 commit
  9. 08 Apr, 2019 2 commits
  10. 31 Mar, 2019 1 commit
  11. 16 Mar, 2019 1 commit
  12. 04 Mar, 2019 1 commit
  13. 19 Feb, 2019 4 commits
  14. 18 Feb, 2019 1 commit
    • Michael Pyne's avatar
      Fix crash with threaded file loading. · 24b0edd1
      Michael Pyne authored
      Although Qt protects access to functions in the GUI thread (where I was
      seeing crashes in the new threaded file loading code in some
      situations), as long as you use signals/slots, Qt Concurrent doesn't do
      anything to keep your non-GUI threaded code from trampling on each
      other.
      
      Which is obvious enough, in retrospect, but that seems to have been the
      reason for the crashes I was sometimes seeing (TagLib and/or FileHandle
      not being thread-safe).
      
      The immediate bugfix is to serialize access into FileHandle/TagLib file
      reading code in DirectoryLoader, though I also did some cleanups in the
      process of debugging that I think are worth keeping.
      24b0edd1
  15. 03 Feb, 2019 1 commit
  16. 20 Jan, 2019 1 commit
  17. 06 Jan, 2019 4 commits
  18. 03 Jan, 2019 3 commits
  19. 28 Dec, 2018 1 commit
  20. 27 Dec, 2018 2 commits
  21. 26 Dec, 2018 4 commits
  22. 24 Dec, 2018 1 commit
  23. 22 Dec, 2018 2 commits
    • Michael Pyne's avatar
      Merge branch 'Applications/18.12' · 6a1d0ec4
      Michael Pyne authored
      6a1d0ec4
    • Michael Pyne's avatar
      Port sort function for list of playlists to KF5. · 468a5169
      Michael Pyne authored
      Now that sorting is enabled, it turned out that the sort really was
      broken for everybody (sorry!). The old Qt 3 and 4 "sort by subclassing
      the list item" feature wasn't actually ported into the Qt 5
      compatibilility list view. So although we were defining the compare
      function, nothing was actually using it.
      
      Things seemed to work fine on my local system but I suspect that's
      because I had playlists from KDE 4 times that I copied over which would
      have already sorted the special playlists to the beginning.
      
      Since the old method doesn't work I've just added a hidden sort key
      column for now. The "proper solution" is probably to use a
      QSortFilterProxyModel but that will be some time away.
      
      CHANGELOG:Restore proper sorting of the list of playlists.
      BUG:402398
      FIXED-IN:18.12.1
      468a5169