1. 18 May, 2019 2 commits
    • Michael Pyne's avatar
      Remove more compiler warnings for deprecated functions/uses. · 44d6bb2d
      Michael Pyne authored
      Still need to get rid of QSignalMapper using lambdas but that will need
      more thought.
      44d6bb2d
    • Michael Pyne's avatar
      Add 'override' decl to fix compiler warnings, fix drag-and-drop. · dc2d9c8e
      Michael Pyne authored
      This should shave off some 1,000+ warnings over the course of a build
      with GCC 9.1.
      
      This only addresses class declarations native to JuK, but Taglib and to
      a lesser extent Qt5 moc still have (or generate) code that can result in
      compiler warnings about suggested override declarations.
      
      In the process I noticed that an existing drag-and-drop support function
      (Playlist::decode) is no longer overriding Qt virtual functions, so it
      has been turned into an auxiliary function to fix existing drag-and-drop
      bugs from the KF5 port (tested by dropping files from Dolphin into a
      playlist view).
      
      Drag-and-drop from a playlist to another playlist (by dropping on the
      playlist name) still remains broken for now.
      
      CCBUG:392705
      FIXED-IN:19.04.2
      dc2d9c8e
  2. 31 Jan, 2018 1 commit
    • Michael Pyne's avatar
      Remove the 'emitChanged' hack in Playlist::createItem<> · 894e87d6
      Michael Pyne authored
      Whichever code is creating these items is in the best spot to know
      whether there will be one or many of these items and when the best time
      is to permit the playlist to sync up afterwards.  This permits the
      createItem functions to focus more on just that function.
      894e87d6
  3. 01 Oct, 2017 1 commit
    • Michael Pyne's avatar
      Remove Kdelibs4Support. · 1e3b90b8
      Michael Pyne authored
      This required a wide assortment of fixes, including deleting
      needless #include <koldfoo.h> headers, some minor additional porting
      tasks, and adding in includes that were previously only implicitly
      included.
      1e3b90b8
  4. 29 Sep, 2017 1 commit
  5. 30 Aug, 2017 5 commits
  6. 28 Aug, 2017 1 commit
  7. 27 Aug, 2017 1 commit
  8. 26 Aug, 2017 4 commits
  9. 25 Aug, 2017 1 commit
  10. 09 Aug, 2017 1 commit
  11. 27 Jul, 2017 3 commits
  12. 26 Jul, 2017 2 commits
  13. 24 Apr, 2016 1 commit
    • Michael Pyne's avatar
      Allow 'default playlists' to have duplicate entries. · cb42ead6
      Michael Pyne authored
      This is still disabled in search playlists, folder-based playlists, and
      the collection list (where the concept doesn't make sense), but at
      least you can add items over and over to the normal playlists.
      
      FIXED-IN:16.08
      cb42ead6
  14. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  15. 26 Jun, 2013 1 commit
    • Michael Pyne's avatar
      startup: Async-ify cached item loading on startup, add timers. · bf4df116
      Michael Pyne authored
      In an attempt to get rid of processEvents() (related to several existing
      crash bugs) I am trying to port the startup code towards more
      async-friendly schemes.
      
      There's no threading but we at least get back to the event loop much
      more frequently while loading files.
      
      Additionally I have added debug output with instrumentation to show how
      long it takes to advance through each step of the startup (I think this
      might be the first time anyone has understood JuK startup sequence in
      years).
      
      This leaves some essentially dead code with Cache (which no longer
      acts as a container), which I will try to cleanup in later commits.
      bf4df116
  16. 26 May, 2013 1 commit
  17. 24 Jun, 2012 1 commit
  18. 31 Jul, 2011 1 commit
  19. 05 May, 2011 1 commit
    • Michael Pyne's avatar
      Add very slight optimization to collection list creation. · 392e641b
      Michael Pyne authored
      In my efforts to figure out wth it takes so long for JuK to startup I've
      managed to shave a (unfortunately very small) amount of time off by not
      requiring tons of function calls to find the singleton CollectionList when the
      CollectionList can just pass itself to CollectionListItems that it creates.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1230441
      392e641b
  20. 17 Aug, 2009 1 commit
  21. 02 Mar, 2009 1 commit
  22. 16 Feb, 2009 1 commit
    • Michael Pyne's avatar
      Last crasher bug I fixed was due to not using Playlist::clearItem() to remove... · 2e865464
      Michael Pyne authored
      Last crasher bug I fixed was due to not using Playlist::clearItem() to remove a PlaylistItem.  I think it
      should always be possible to call delete on a PlaylistItem pointer and the Right Thing happens, so do a
      bit of refactoring to ensure that what happens in clearItem() is performed from the PlaylistItem dtor instead
      of running the PlaylistItem dtor from clearItem.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=926748
      2e865464
  23. 09 Feb, 2009 1 commit
    • Michael Pyne's avatar
      local8Bit encodings scare me, so save the QString in the shared... · c052b2d9
      Michael Pyne authored
      local8Bit encodings scare me, so save the QString in the shared PlaylistItem/CollectionListItem metadata
      instead of converting to QByteArray (I don't really think utf-8 would help much since QStrings can buy us
      localeAwareCompare as well).
      
      Also use a standard Qt collection for our StringShare instead of a constant sized hash table.  Probably a
      better way to do this would be a simple cache that tracks how much each string is put in, not sure how much
      that would help though.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=923583
      c052b2d9
  24. 12 Jan, 2009 1 commit
  25. 11 Nov, 2008 1 commit
  26. 24 Aug, 2008 1 commit
    • Michael Pyne's avatar
      JuK optimizapalooza! · c8f53250
      Michael Pyne authored
      * Add whatever X-DBUS-foo line KUniqueApplication says we need.
      * Restructure the startup sequence to postpone all the hard work until after the GUI is setup
        as much as possible to allow passing our reply over DBUS ASAP.
      * Don't call hasCover from PlaylistItem like, ever.  I made CoverInfo::hasCover() take longer
        when I added support for APIC frames but didn't catch all unnecessary instances of their use
        last time.  Luckily this is the big win and is backportable.
      * Also, don't force CoverInfo::coverId() to call hasCover() for no reason.
      
      Hopefully this should remove the egregrious Plasma freeze-ups while starting but even after
      returning from KUniqueApplication::newInstance() quickly it seems to take a while for the reply
      to go over the D-BUS...
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=851610
      c8f53250
  27. 12 Aug, 2008 1 commit
  28. 14 May, 2008 1 commit
  29. 21 Dec, 2007 1 commit
    • Laurent Montel's avatar
      Fix include · 7d774e73
      Laurent Montel authored
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=751215
      7d774e73