1. 18 May, 2019 1 commit
    • Michael Pyne's avatar
      Add 'override' decl to fix compiler warnings, fix drag-and-drop. · dc2d9c8e
      Michael Pyne authored
      This should shave off some 1,000+ warnings over the course of a build
      with GCC 9.1.
      
      This only addresses class declarations native to JuK, but Taglib and to
      a lesser extent Qt5 moc still have (or generate) code that can result in
      compiler warnings about suggested override declarations.
      
      In the process I noticed that an existing drag-and-drop support function
      (Playlist::decode) is no longer overriding Qt virtual functions, so it
      has been turned into an auxiliary function to fix existing drag-and-drop
      bugs from the KF5 port (tested by dropping files from Dolphin into a
      playlist view).
      
      Drag-and-drop from a playlist to another playlist (by dropping on the
      playlist name) still remains broken for now.
      
      CCBUG:392705
      FIXED-IN:19.04.2
      dc2d9c8e
  2. 27 Aug, 2017 1 commit
    • Michael Pyne's avatar
      Cleanup AdvancedSearchPlaylist. · 647e8ce5
      Michael Pyne authored
      - Port away from K[HV]Box
      - Port away from KDialog
      - It's been 10 years since you could make a SearchPlaylist from the
      track search widget, remove the dead code.
      
      SearchPlaylist still doesn't work but at least there are fewer warnings
      and you can at least make it to the AdvancedSearchDialog again.
      647e8ce5
  3. 23 Aug, 2017 1 commit
  4. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  5. 01 Sep, 2008 1 commit
    • Michael Pyne's avatar
      Fun thing to do with JuK: · 7ff5a548
      Michael Pyne authored
      Pause playback.
      Type in something into the search widget
      Press enter to play the first matched song.
      
      A song will play alright, but the playingFile will be thought to be null for some reason.  I've
      tracked down that this is probably due to there being no selected item in the visible results
      when enter is pressed, so I've made the search widget's returnPressed() signal manually play
      the first listed match instead of relying on Playlist's returnPressed() signal to work.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=855548
      7ff5a548
  6. 29 Sep, 2007 1 commit
  7. 24 May, 2007 1 commit
    • Michael Pyne's avatar
      Fairly large overhaul of the JuK codebase to beat out a lot of the Qt 3 stuff. · 2c297413
      Michael Pyne authored
      Still a lot of Qt 3 code to go but at this point Q3ValueList, Q3Vector, Q3PtrDict and
      Q3Dict should all be gone.
      
      In addition many loops have been foreach()'ed, which really does make it more readable.
      
      There is a crash fix as well, now the polish() function in Playlist has been replaced
      with an initialization slot which is singleShot'ed since the timing of the polish event
      is apparently different than it was in Qt 3, which was making new Playlists crash when
      they were first shown.
      
      Also I went through almost every header and pared it down to the minimum reasonably
      achievable, which required some additional headers in a few .cpp files but overall
      compilation time should be down and you won't have to rebuild all of JuK just because
      a header file got touched.
      
      I haven't seen any regressions yet but then again I still can't play music either.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=667815
      2c297413
  8. 18 May, 2007 1 commit
  9. 23 Jan, 2007 1 commit
  10. 22 Jun, 2006 1 commit
  11. 26 Feb, 2006 1 commit
  12. 06 Dec, 2005 1 commit
  13. 01 Sep, 2005 1 commit
  14. 17 May, 2005 1 commit
  15. 29 Oct, 2004 2 commits
  16. 31 Jul, 2004 1 commit
  17. 20 Jul, 2004 1 commit
  18. 03 Jun, 2004 1 commit
  19. 01 Jun, 2004 1 commit
    • Scott Wheeler's avatar
      Ok, big cleanups essentially implimenting the stuff that has been in the · 08f5d033
      Scott Wheeler authored
      TODO for a while:
      
      *) Ditch the PlaylistSplitter class mostly in favor of the PlaylistCollection
      *) Move to a more linear class interaction path rather than having PlaylistSplitter
         as an ugly thing trying to mediate between a bunch of unrelated classes
      *) Rely more heavily on the global action collection and try to instantiate actions
         in the classes that they're related to
      *) Remove a few dozen dirty hacks
      *) Got rid of about 250 lines of code in the process
      
      There are still a couple of outstanding issues but since my home internet connection
      has decided that it doesn't like me at the moment and people are waiting on these
      changes for further work I'm committing.  Stuff that still needs to be done (I'll
      likely finish this tonight and commit it at work tomorrow):
      
      *) Create the Artist / Album / Genre playlists in the Tree View Mode.  This is
         essentially easy, it just requires sticking a new constructor in and making sure
         that it works.
      *) Make it so that the HistoryPlaylist is properly instantiated and shown when its
         asked for
      *) Make sure that the status bar is updated with the current playlist information
      *) Create dynamic playlists on multiple select
      
      While that sounds like quite a bit that's really just a little bit of work, but
      managing such a huge patch set off-line is getting rather tedious and most stuff
      works now.  I should have a patch for the rest tomorrow.
      
      svn path=/trunk/kdemultimedia/juk/; revision=316735
      08f5d033
  20. 19 Apr, 2004 1 commit
  21. 31 Mar, 2004 1 commit
    • Scott Wheeler's avatar
      For pmax, with love. · b3efcae6
      Scott Wheeler authored
      Add a clear button to the search line a la KMail.
      
      svn path=/trunk/kdemultimedia/juk/; revision=300208
      b3efcae6
  22. 11 Nov, 2003 1 commit
    • Scott Wheeler's avatar
      More GUI cleaning to keep the crowds happy. Remove some of the clutter on · 9e84b967
      Scott Wheeler authored
      the search bar and replace it with an "Advanced Search" button (again, note
      that this string was already present).
      
      Also don't put the search bar in a splitter since, well, you can't resize it.
      
      Made the search bar a KToolBar -- this looks more visually concistant...
      
      svn path=/trunk/kdemultimedia/juk/; revision=266261
      9e84b967
  23. 09 Nov, 2003 1 commit
  24. 07 Sep, 2003 1 commit
  25. 04 Sep, 2003 1 commit
  26. 01 Aug, 2003 1 commit
    • Scott Wheeler's avatar
      Split the SearchWidget up into two parts, one of which remains the · 3922d9aa
      Scott Wheeler authored
      SearchWidget, but it also contains a SearchLine.
      
      SearchLine operates on a PlaylistSearch::Component in the same way that
      SearchWidget operates on PlaylistSearch, so this adheres to that method
      of splitting things up.
      
      I can also reuse the SearchLine in my implementation of the more advanced
      search widget which I comitted the first parts of last night.
      
      svn path=/trunk/kdemultimedia/juk/; revision=240319
      3922d9aa
  27. 03 Jun, 2003 1 commit
    • Scott Wheeler's avatar
      Make JuK remeber the search for a playlist (during that instance only). · 673e6d3c
      Scott Wheeler authored
      Now when you move to a different playlist the search on the previous one
      will be remembered.  Also if you hide the search bar, when you redisplay it
      your previous search will still be there.
      
      Doing this also gave me an excuse to clean up the way that the PlaylistSplitter
      and SearchWidget interact -- the SearchWidget now returns a real PlaylistSearch
      rather than more "raw" information about the search results.
      
      svn path=/trunk/kdemultimedia/juk/; revision=229414
      673e6d3c
  28. 02 Jun, 2003 1 commit
    • Scott Wheeler's avatar
      * Cleaned up some includes · 7cb5aaec
      Scott Wheeler authored
      * Added some functionality to PlaylistSearch to allow components to be
        saved and restored
      * Added a member variable and accessor methods to Playlist to store the
        current search
      * Cleaned up some of the code in Playlist to use PlaylistItemList instead
        of a QPtrList.
      
      The next commit will actually make use of the above stuff to save and
      restore searches when the user changes playlists.
      
      svn path=/trunk/kdemultimedia/juk/; revision=229404
      7cb5aaec
  29. 09 May, 2003 1 commit
  30. 08 Apr, 2003 1 commit
  31. 07 Apr, 2003 1 commit
  32. 18 Feb, 2003 1 commit
  33. 12 Dec, 2002 1 commit
  34. 13 Oct, 2002 1 commit
  35. 12 Oct, 2002 1 commit
  36. 13 Sep, 2002 1 commit
  37. 07 Sep, 2002 1 commit
  38. 30 May, 2002 1 commit
  39. 15 Apr, 2002 1 commit