1. 18 May, 2019 1 commit
    • Michael Pyne's avatar
      Add 'override' decl to fix compiler warnings, fix drag-and-drop. · dc2d9c8e
      Michael Pyne authored
      This should shave off some 1,000+ warnings over the course of a build
      with GCC 9.1.
      
      This only addresses class declarations native to JuK, but Taglib and to
      a lesser extent Qt5 moc still have (or generate) code that can result in
      compiler warnings about suggested override declarations.
      
      In the process I noticed that an existing drag-and-drop support function
      (Playlist::decode) is no longer overriding Qt virtual functions, so it
      has been turned into an auxiliary function to fix existing drag-and-drop
      bugs from the KF5 port (tested by dropping files from Dolphin into a
      playlist view).
      
      Drag-and-drop from a playlist to another playlist (by dropping on the
      playlist name) still remains broken for now.
      
      CCBUG:392705
      FIXED-IN:19.04.2
      dc2d9c8e
  2. 11 Nov, 2018 1 commit
  3. 01 Oct, 2017 1 commit
    • Michael Pyne's avatar
      Remove Kdelibs4Support. · 1e3b90b8
      Michael Pyne authored
      This required a wide assortment of fixes, including deleting
      needless #include <koldfoo.h> headers, some minor additional porting
      tasks, and adding in includes that were previously only implicitly
      included.
      1e3b90b8
  4. 30 Sep, 2017 1 commit
  5. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  6. 14 Jun, 2013 1 commit
  7. 10 Aug, 2011 1 commit
  8. 30 Jul, 2010 1 commit
  9. 26 Nov, 2009 1 commit
    • Michael Pyne's avatar
      Decouple PlayerManager from JuK so that it isn't a singleton. · c0204770
      Michael Pyne authored
      The major reason for this change is to allow for a saner destruct sequence
      (instead of the unordered global static destruct sequence) which will hopefully
      help reduce crash-on-shutdown bugs.
      
      This will not be in the upcoming KDE 4.4 beta but will be in the 4.4 release (assuming no
      bugs are found in it ;)
      
      CCMAIL:nlecureuil@mandriva.com
      
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1054429
      c0204770
  10. 30 Oct, 2009 1 commit
  11. 18 Sep, 2009 1 commit
  12. 28 Apr, 2009 1 commit
  13. 12 Jan, 2009 1 commit
  14. 03 Jun, 2008 1 commit
  15. 12 Jan, 2008 1 commit
    • Michael Pyne's avatar
      Fix formatting in systemtray.cpp · 2b3659b7
      Michael Pyne authored
      Move the track announcement popup to the right location (will be backported)
      Remove now-spurious compile warnings.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=760159
      2b3659b7
  16. 24 May, 2007 1 commit
    • Michael Pyne's avatar
      Fairly large overhaul of the JuK codebase to beat out a lot of the Qt 3 stuff. · 2c297413
      Michael Pyne authored
      Still a lot of Qt 3 code to go but at this point Q3ValueList, Q3Vector, Q3PtrDict and
      Q3Dict should all be gone.
      
      In addition many loops have been foreach()'ed, which really does make it more readable.
      
      There is a crash fix as well, now the polish() function in Playlist has been replaced
      with an initialization slot which is singleShot'ed since the timing of the polish event
      is apparently different than it was in Qt 3, which was making new Playlists crash when
      they were first shown.
      
      Also I went through almost every header and pared it down to the minimum reasonably
      achievable, which required some additional headers in a few .cpp files but overall
      compilation time should be down and you won't have to rebuild all of JuK just because
      a header file got touched.
      
      I haven't seen any regressions yet but then again I still can't play music either.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=667815
      2c297413
  17. 19 May, 2007 2 commits
  18. 16 Feb, 2007 1 commit
  19. 23 Jul, 2006 1 commit
  20. 14 Jul, 2006 1 commit
    • Stephan Kulow's avatar
      compile · ee6c7a87
      Stephan Kulow authored
      svn path=/branches/work/kde4-systray-rewrite/kdemultimedia/juk/; revision=562448
      ee6c7a87
  21. 09 May, 2006 1 commit
  22. 28 Feb, 2006 1 commit
  23. 26 Feb, 2006 2 commits
  24. 01 Sep, 2005 1 commit
  25. 11 Jul, 2005 1 commit
  26. 04 May, 2005 1 commit
    • Michael Pyne's avatar
      Track announcement popup changes/improvements. · 9ec2e76d
      Michael Pyne authored
      * Now when you click on the back/forward buttons in the popup, the popup text
        shows up instantly instead of fading in. (Improvement)
      * The text fades out now as well, assuming you don't interrupt it. (Dubious,
        but easy to remove thanks to...)
      * Code cleanups, hopefully everything that's happening is easier to understand.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=409222
      9ec2e76d
  27. 08 Nov, 2004 4 commits
  28. 22 Sep, 2004 1 commit
    • Michael Pyne's avatar
      Make the track announcement popup fade-in the text of the announcement. Note... · 85b94e5f
      Michael Pyne authored
      Make the track announcement popup fade-in the text of the announcement.  Note that this has absolutely nothing to do with COMPOSITE!
      
      I may revert this later, or change it, or something, depending on feedback, but I wanted to get this patch off of my hard drive before I forgot.
      
      svn path=/trunk/kdemultimedia/juk/; revision=348340
      85b94e5f
  29. 03 Jun, 2004 1 commit
  30. 30 May, 2004 1 commit
    • Scott Wheeler's avatar
      When going in to work on some other stuff I noticed a few bugs: · bbb778f4
      Scott Wheeler authored
      *) Don't use i18n() on strings that aren't created by the GUI (i.e. it doesn't
         make sense to use it on strings coming from tags)
      *) There was a case in here for buttons being created on the right, but then
         the line was created with a parent of 0, which would make it create a new
         window.  :-)
      *) Simplified the logic quite a bit -- about 40 LOC worth
      *) Removed the conditional for drawing buttons; they're always drawn.
      
      svn path=/trunk/kdemultimedia/juk/; revision=316190
      bbb778f4
  31. 23 May, 2004 1 commit
    • Michael Pyne's avatar
      * Move the buttons in the track announcement popup depending on what side of... · e1501c23
      Michael Pyne authored
      * Move the buttons in the track announcement popup depending on what side of the JuK icon the popup will appear.  This means that the buttons shouldn't move if you click Next or Previous now, no matter where the tray icon is.
      * I altered some of my earlier code to conform to the style guide while I was working on the file.
      
      svn path=/trunk/kdemultimedia/juk/; revision=313903
      e1501c23
  32. 19 May, 2004 1 commit
  33. 18 Apr, 2004 2 commits
  34. 27 Feb, 2004 1 commit