1. 18 May, 2019 1 commit
    • Michael Pyne's avatar
      Add 'override' decl to fix compiler warnings, fix drag-and-drop. · dc2d9c8e
      Michael Pyne authored
      This should shave off some 1,000+ warnings over the course of a build
      with GCC 9.1.
      
      This only addresses class declarations native to JuK, but Taglib and to
      a lesser extent Qt5 moc still have (or generate) code that can result in
      compiler warnings about suggested override declarations.
      
      In the process I noticed that an existing drag-and-drop support function
      (Playlist::decode) is no longer overriding Qt virtual functions, so it
      has been turned into an auxiliary function to fix existing drag-and-drop
      bugs from the KF5 port (tested by dropping files from Dolphin into a
      playlist view).
      
      Drag-and-drop from a playlist to another playlist (by dropping on the
      playlist name) still remains broken for now.
      
      CCBUG:392705
      FIXED-IN:19.04.2
      dc2d9c8e
  2. 02 Oct, 2017 4 commits
  3. 01 Oct, 2017 1 commit
    • Michael Pyne's avatar
      Remove Kdelibs4Support. · 1e3b90b8
      Michael Pyne authored
      This required a wide assortment of fixes, including deleting
      needless #include <koldfoo.h> headers, some minor additional porting
      tasks, and adding in includes that were previously only implicitly
      included.
      1e3b90b8
  4. 30 Sep, 2017 1 commit
    • Michael Pyne's avatar
      Fix miscellaneous remaining warnings. · 4e13f805
      Michael Pyne authored
      Most are just worked around in some fashion but better to weed out
      warnings from features that don't work right now so that actual issues
      that might be introduced are that much more apparent.
      4e13f805
  5. 29 Sep, 2017 1 commit
  6. 30 Aug, 2017 1 commit
  7. 27 Aug, 2017 2 commits
  8. 26 Aug, 2017 5 commits
  9. 25 Aug, 2017 2 commits
  10. 27 Jul, 2017 1 commit
  11. 26 Jul, 2017 2 commits
  12. 28 Feb, 2014 1 commit
  13. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  14. 10 Aug, 2011 1 commit
  15. 31 Jul, 2011 1 commit
  16. 15 May, 2011 5 commits
  17. 25 Apr, 2011 1 commit
    • Michael Pyne's avatar
      Refresh tag editor if collection is updated while visible. · d8b7228c
      Michael Pyne authored
      The indefatigable Giorgos Kylafas managed to troubleshoot the cause of a bug
      where the Tag Editor's artist, genre, and track name fields would be reset to
      the first item in the respective combo boxes after the collection was updated,
      although this behavior only occurred if the tag editor was visible when it
      happened.
      
      I would say this should have tipped me off, but I haven't had enough time for
      JuK recently so honestly I haven't looked at it. Giorgos has, however, and I
      can confirm he tracked down the issue correctly and fixed it.
      
      Going through the bugs seems to indicate this might be the cause of 271054
      (JuK tag guesser works improperly if tag editor is open), which I believe is
      caused the the tag editor being updated when the file renamer operates,
      immediately updating the relevant fields to the wrong values and (somehow?)
      then saving those changes.
      
      This commit is against trunk, I will backport to 4.6.3.
      
      CCBUG:271054
      CCMAIL:gekylafas@gmail.com
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1229044
      d8b7228c
  18. 27 Sep, 2010 1 commit
  19. 22 Sep, 2010 1 commit
  20. 10 May, 2010 1 commit
  21. 04 Jul, 2009 1 commit
  22. 22 Nov, 2008 1 commit
  23. 20 Nov, 2008 1 commit
  24. 11 Nov, 2008 1 commit
  25. 15 Sep, 2008 1 commit
  26. 16 Jun, 2008 1 commit