1. 18 May, 2019 1 commit
    • Michael Pyne's avatar
      Add 'override' decl to fix compiler warnings, fix drag-and-drop. · dc2d9c8e
      Michael Pyne authored
      This should shave off some 1,000+ warnings over the course of a build
      with GCC 9.1.
      
      This only addresses class declarations native to JuK, but Taglib and to
      a lesser extent Qt5 moc still have (or generate) code that can result in
      compiler warnings about suggested override declarations.
      
      In the process I noticed that an existing drag-and-drop support function
      (Playlist::decode) is no longer overriding Qt virtual functions, so it
      has been turned into an auxiliary function to fix existing drag-and-drop
      bugs from the KF5 port (tested by dropping files from Dolphin into a
      playlist view).
      
      Drag-and-drop from a playlist to another playlist (by dropping on the
      playlist name) still remains broken for now.
      
      CCBUG:392705
      FIXED-IN:19.04.2
      dc2d9c8e
  2. 11 Nov, 2018 1 commit
  3. 23 Sep, 2018 1 commit
  4. 30 Sep, 2017 1 commit
    • Michael Pyne's avatar
      Fix miscellaneous remaining warnings. · 4e13f805
      Michael Pyne authored
      Most are just worked around in some fashion but better to weed out
      warnings from features that don't work right now so that actual issues
      that might be introduced are that much more apparent.
      4e13f805
  5. 26 Jul, 2017 1 commit
  6. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  7. 04 Jun, 2007 1 commit
  8. 24 May, 2007 1 commit
    • Michael Pyne's avatar
      Fairly large overhaul of the JuK codebase to beat out a lot of the Qt 3 stuff. · 2c297413
      Michael Pyne authored
      Still a lot of Qt 3 code to go but at this point Q3ValueList, Q3Vector, Q3PtrDict and
      Q3Dict should all be gone.
      
      In addition many loops have been foreach()'ed, which really does make it more readable.
      
      There is a crash fix as well, now the polish() function in Playlist has been replaced
      with an initialization slot which is singleShot'ed since the timing of the polish event
      is apparently different than it was in Qt 3, which was making new Playlists crash when
      they were first shown.
      
      Also I went through almost every header and pared it down to the minimum reasonably
      achievable, which required some additional headers in a few .cpp files but overall
      compilation time should be down and you won't have to rebuild all of JuK just because
      a header file got touched.
      
      I haven't seen any regressions yet but then again I still can't play music either.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=667815
      2c297413
  9. 13 Mar, 2006 1 commit
  10. 26 Feb, 2006 3 commits
  11. 01 Sep, 2005 1 commit
  12. 15 Sep, 2004 1 commit
  13. 28 Aug, 2004 1 commit
    • Michael Pyne's avatar
      This commit changes the following: · b1933ed2
      Michael Pyne authored
      * Use KDirLister as suggested by dfaure to track changes to the folders we're watching.  This allows us to track deletion and refreshes in addition to additions.
      * Shave about 20% off of the time needed to initialize the tree view mode.
      * Correct my spacing errors in playlistbox.cpp
      * Change the map used to hold the tree view text tags to a hash table, which should be faster as well.
      
      It's all in one commit because I'm crappy at patch management. =D
      
      svn path=/trunk/kdemultimedia/juk/; revision=342054
      b1933ed2
  14. 24 Jul, 2004 1 commit
    • Michael Pyne's avatar
      Change the tree view mode in JuK to create and delete playlists as needed to · 0fdc1c20
      Michael Pyne authored
      keep in sync with your music collection.  What this means is that if you
      should remove a song, or edit a tag such that one of the tree view categories
      is empty, the category will automatically delete itself.  Also, adding tracks
      or editing a new tag will automatically create the appropriate entry, even if
      you've already expanded the tree view out.
      
      This fixes a couple of bugs, and although the patch is rather large, it has been
      reviewed by Scott <wheeler@kde.org>, with some of his suggestions implemented.
      Of course, I would appreciate testing, I've been running it here for quite a few days.
      
      No strings were harmed during the making of this patch. :-)
      
      CCMAIL:62303-done@bugs.kde.org
      CCMAIL:74598-done@bugs.kde.org
      
      svn path=/trunk/kdemultimedia/juk/; revision=332224
      0fdc1c20
  15. 20 Jun, 2004 1 commit
  16. 04 Jun, 2004 2 commits
  17. 03 Jun, 2004 2 commits
  18. 19 Apr, 2004 2 commits
  19. 29 Feb, 2004 1 commit
    • Scott Wheeler's avatar
      fixincludes · 1ed5929d
      Scott Wheeler authored
      svn path=/trunk/kdemultimedia/juk/; revision=292445
      1ed5929d
  20. 04 Dec, 2003 1 commit
  21. 25 Sep, 2003 1 commit
  22. 24 Sep, 2003 1 commit
  23. 11 Aug, 2003 1 commit
  24. 22 Jul, 2003 1 commit
  25. 21 Jul, 2003 1 commit
  26. 17 Jun, 2003 1 commit
  27. 14 Jun, 2003 1 commit
  28. 13 Jun, 2003 1 commit
  29. 09 Jun, 2003 1 commit
  30. 07 Jun, 2003 1 commit