1. 18 May, 2019 1 commit
    • Michael Pyne's avatar
      Add 'override' decl to fix compiler warnings, fix drag-and-drop. · dc2d9c8e
      Michael Pyne authored
      This should shave off some 1,000+ warnings over the course of a build
      with GCC 9.1.
      
      This only addresses class declarations native to JuK, but Taglib and to
      a lesser extent Qt5 moc still have (or generate) code that can result in
      compiler warnings about suggested override declarations.
      
      In the process I noticed that an existing drag-and-drop support function
      (Playlist::decode) is no longer overriding Qt virtual functions, so it
      has been turned into an auxiliary function to fix existing drag-and-drop
      bugs from the KF5 port (tested by dropping files from Dolphin into a
      playlist view).
      
      Drag-and-drop from a playlist to another playlist (by dropping on the
      playlist name) still remains broken for now.
      
      CCBUG:392705
      FIXED-IN:19.04.2
      dc2d9c8e
  2. 19 Jan, 2018 2 commits
    • Michael Pyne's avatar
      Refactor and extract SearchPlaylist's playlist item sync code. · 516a69f9
      Michael Pyne authored
      And use it for DynamicPlaylist now as well.
      516a69f9
    • Michael Pyne's avatar
      Immediately update dynamic/search playlist items upon a change. · e8c2dbbf
      Michael Pyne authored
      This is as opposed to recording the new list of PlaylistItems and then
      effecting the change after draining the event loop (an attempt at
      keeping GUI responsive if many updates are happening).
      
      Otherwise it is possible to
      - Generate a list of PlaylistItems to read from (when updating the
      playlist) and push to end of event loop
      - Delete some of those PlaylistItems due to already-queued events to
      delete playlist items
      - Finally try to use the list of PlaylistItems and run into a segfault
      from trying to access a deleted PlaylistItem.
      
      I think this should fix a crash when you delete multiple playlists.
      
      BUG:389176
      FIXED-IN:17.12.2
      e8c2dbbf
  3. 02 Oct, 2017 1 commit
  4. 25 Aug, 2017 1 commit
  5. 27 Jul, 2017 1 commit
  6. 26 Jul, 2017 1 commit
  7. 24 Apr, 2016 1 commit
    • Michael Pyne's avatar
      Allow 'default playlists' to have duplicate entries. · cb42ead6
      Michael Pyne authored
      This is still disabled in search playlists, folder-based playlists, and
      the collection list (where the concept doesn't make sense), but at
      least you can add items over and over to the normal playlists.
      
      FIXED-IN:16.08
      cb42ead6
  8. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  9. 11 Nov, 2008 1 commit
  10. 24 May, 2007 1 commit
    • Michael Pyne's avatar
      Fairly large overhaul of the JuK codebase to beat out a lot of the Qt 3 stuff. · 2c297413
      Michael Pyne authored
      Still a lot of Qt 3 code to go but at this point Q3ValueList, Q3Vector, Q3PtrDict and
      Q3Dict should all be gone.
      
      In addition many loops have been foreach()'ed, which really does make it more readable.
      
      There is a crash fix as well, now the polish() function in Playlist has been replaced
      with an initialization slot which is singleShot'ed since the timing of the polish event
      is apparently different than it was in Qt 3, which was making new Playlists crash when
      they were first shown.
      
      Also I went through almost every header and pared it down to the minimum reasonably
      achievable, which required some additional headers in a few .cpp files but overall
      compilation time should be down and you won't have to rebuild all of JuK just because
      a header file got touched.
      
      I haven't seen any regressions yet but then again I still can't play music either.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=667815
      2c297413
  11. 19 May, 2007 1 commit
  12. 26 Feb, 2006 2 commits
  13. 01 Sep, 2005 1 commit
  14. 14 Nov, 2004 1 commit
  15. 10 Nov, 2004 1 commit
  16. 22 Jun, 2004 2 commits
    • Michael Pyne's avatar
      * Implement drag-and-drop retagging of songs while using the tree view... · 52a5fbe0
      Michael Pyne authored
      * Implement drag-and-drop retagging of songs while using the tree view playlist mode, fixing bug 62307.
      * In the process, I've found many instances where updating a tag sometimes wouldn't update a search playlist, and so I've fixed all those bugs I could find.
      
      Drag-and-drop retagging only works dragging songs onto the Artist, Album, or Genre subitems, however I still find it pretty useful.
      
      CCMAIL:62307-done@bugs.kde.org
      
      svn path=/trunk/kdemultimedia/juk/; revision=322682
      52a5fbe0
    • Scott Wheeler's avatar
      this no longer applies · 117311b4
      Scott Wheeler authored
      svn path=/trunk/kdemultimedia/juk/; revision=322671
      117311b4
  17. 19 Jun, 2004 1 commit
  18. 08 Jun, 2004 2 commits
  19. 03 Jun, 2004 3 commits
  20. 01 Jun, 2004 1 commit
    • Scott Wheeler's avatar
      Ok, big cleanups essentially implimenting the stuff that has been in the · 08f5d033
      Scott Wheeler authored
      TODO for a while:
      
      *) Ditch the PlaylistSplitter class mostly in favor of the PlaylistCollection
      *) Move to a more linear class interaction path rather than having PlaylistSplitter
         as an ugly thing trying to mediate between a bunch of unrelated classes
      *) Rely more heavily on the global action collection and try to instantiate actions
         in the classes that they're related to
      *) Remove a few dozen dirty hacks
      *) Got rid of about 250 lines of code in the process
      
      There are still a couple of outstanding issues but since my home internet connection
      has decided that it doesn't like me at the moment and people are waiting on these
      changes for further work I'm committing.  Stuff that still needs to be done (I'll
      likely finish this tonight and commit it at work tomorrow):
      
      *) Create the Artist / Album / Genre playlists in the Tree View Mode.  This is
         essentially easy, it just requires sticking a new constructor in and making sure
         that it works.
      *) Make it so that the HistoryPlaylist is properly instantiated and shown when its
         asked for
      *) Make sure that the status bar is updated with the current playlist information
      *) Create dynamic playlists on multiple select
      
      While that sounds like quite a bit that's really just a little bit of work, but
      managing such a huge patch set off-line is getting rather tedious and most stuff
      works now.  I should have a patch for the rest tomorrow.
      
      svn path=/trunk/kdemultimedia/juk/; revision=316735
      08f5d033
  21. 15 Feb, 2004 1 commit
  22. 14 Sep, 2003 1 commit
  23. 11 Aug, 2003 1 commit
  24. 30 Jul, 2003 1 commit
  25. 23 Jul, 2003 1 commit
    • Scott Wheeler's avatar
      Make Playlist::items() virtual -- my code had assumed that it already was · 89beded5
      Scott Wheeler authored
      and there were some code paths that weren't being called because of this.
      
      Fixed the errors that this uncovered including returning proper values from
      DynamicPlaylist::items() and SearchPlaylist::items().  Previously it was
      returning the set of "matched" items from the component playlists rather
      than the actual displayed items in the playlist.
      
      This also makes it possible to have a DynamicPlaylist composed of search
      playlists, which was the problem that lead to the discovery of the issues
      above.
      
      svn path=/trunk/kdemultimedia/juk/; revision=238884
      89beded5
  26. 07 Jul, 2003 1 commit
  27. 06 May, 2003 1 commit
  28. 05 May, 2003 1 commit