1. 18 May, 2019 3 commits
    • Michael Pyne's avatar
      A few more FileRenamer cleanups since I was there. · 7264132f
      Michael Pyne authored
      Includes modernizing signal/slot usage, dead code elimination, some code
      readability improvement.
      7264132f
    • Michael Pyne's avatar
      Remove deprecated use of QSignalMapper. · 7d681172
      Michael Pyne authored
      7d681172
    • Michael Pyne's avatar
      Add 'override' decl to fix compiler warnings, fix drag-and-drop. · dc2d9c8e
      Michael Pyne authored
      This should shave off some 1,000+ warnings over the course of a build
      with GCC 9.1.
      
      This only addresses class declarations native to JuK, but Taglib and to
      a lesser extent Qt5 moc still have (or generate) code that can result in
      compiler warnings about suggested override declarations.
      
      In the process I noticed that an existing drag-and-drop support function
      (Playlist::decode) is no longer overriding Qt virtual functions, so it
      has been turned into an auxiliary function to fix existing drag-and-drop
      bugs from the KF5 port (tested by dropping files from Dolphin into a
      playlist view).
      
      Drag-and-drop from a playlist to another playlist (by dropping on the
      playlist name) still remains broken for now.
      
      CCBUG:392705
      FIXED-IN:19.04.2
      dc2d9c8e
  2. 20 Dec, 2018 1 commit
  3. 23 Sep, 2018 1 commit
  4. 30 Sep, 2017 2 commits
  5. 29 Sep, 2017 1 commit
  6. 26 Jul, 2017 1 commit
  7. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  8. 04 Aug, 2009 1 commit
  9. 01 Mar, 2009 1 commit
  10. 24 May, 2007 1 commit
    • Michael Pyne's avatar
      Fairly large overhaul of the JuK codebase to beat out a lot of the Qt 3 stuff. · 2c297413
      Michael Pyne authored
      Still a lot of Qt 3 code to go but at this point Q3ValueList, Q3Vector, Q3PtrDict and
      Q3Dict should all be gone.
      
      In addition many loops have been foreach()'ed, which really does make it more readable.
      
      There is a crash fix as well, now the polish() function in Playlist has been replaced
      with an initialization slot which is singleShot'ed since the timing of the polish event
      is apparently different than it was in Qt 3, which was making new Playlists crash when
      they were first shown.
      
      Also I went through almost every header and pared it down to the minimum reasonably
      achievable, which required some additional headers in a few .cpp files but overall
      compilation time should be down and you won't have to rebuild all of JuK just because
      a header file got touched.
      
      I haven't seen any regressions yet but then again I still can't play music either.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=667815
      2c297413
  11. 16 Feb, 2007 1 commit
  12. 19 Oct, 2006 1 commit
  13. 15 Oct, 2006 2 commits
  14. 09 May, 2006 1 commit
  15. 10 Apr, 2006 1 commit
  16. 27 Feb, 2006 1 commit
  17. 26 Feb, 2006 4 commits
  18. 28 Jan, 2006 1 commit
  19. 01 Sep, 2005 1 commit
  20. 17 May, 2005 1 commit
    • Michael Pyne's avatar
      Implement wish 88099 (Automatically set folder icon for album when using the · 72deb2db
      Michael Pyne authored
      File Renamer).
      
      This feature could probably use some more testing, and it doesn't really work
      too well when the Album name is the same as the Artist name if the Artist and
      Album directories are separate (e.g. /.../Artist/Album/ wouldn't work.)
      
      Now my JuK tree is finally identical to that in /trunk. :)
      
      BUG:88099
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=414826
      72deb2db
  21. 02 Nov, 2004 3 commits
  22. 01 Nov, 2004 5 commits
    • Scott Wheeler's avatar
      A couple of nitpicks: initialize the variables even though we'll just write · f0d7ce69
      Scott Wheeler authored
      over them shortly and use C++ style enum declarations.
      
      svn path=/trunk/kdemultimedia/juk/; revision=359717
      f0d7ce69
    • Scott Wheeler's avatar
      Readd the confirmation dialog. There's still some broken stuff in here, but · f8d0cecc
      Scott Wheeler authored
      it's easier to debug when it prompts you about renaming rather than trying to
      guess where the file went.
      
      svn path=/trunk/kdemultimedia/juk/; revision=359672
      f8d0cecc
    • Scott Wheeler's avatar
      CVS_SILENT indent the API docs as is standard KDE / doxygen style · 68c9716f
      Scott Wheeler authored
      svn path=/trunk/kdemultimedia/juk/; revision=359591
      68c9716f
    • Scott Wheeler's avatar
      s/directory/folder/g · 95b7998d
      Scott Wheeler authored
      svn path=/trunk/kdemultimedia/juk/; revision=359550
      95b7998d
    • Michael Pyne's avatar
      GUI: Overhaul the file renamer configuration dialog based on a design of... · d9223918
      Michael Pyne authored
      GUI: Overhaul the file renamer configuration dialog based on a design of Scott's.  This involved a lot more code than I thought at first, but it should be pretty neat.
      
      This also should fix wish 64849 (Add genre to file renamer) and wish 63912.
      In essence this creates a dialog that has a row with each possible category, and arrows allowing you to move that category up and down.
      * In the options for the category, you can control leading and trailing text, and what happens if the tag is empty.
      * You can set a minimum width for the track (bug 63912).
      * The dialog includes a sample result, and you can either edit the sample tag values manually, or load tags from a file to see what it would look like.
      * Right now the file renamer code automatically suppresses separators between tag values that use bracketing characters, since I feel that stuff like Artist - Title - [Track] looks dumb, but that may be changed/removed later.
      
      Suggestions are accepted: michael (dot) pyne (at) kdemail (dot) net.
      
      BUG:63912
      BUG:64849
      
      svn path=/trunk/kdemultimedia/juk/; revision=359516
      d9223918
  23. 09 Sep, 2003 1 commit
  24. 07 Sep, 2003 2 commits
  25. 06 Sep, 2003 2 commits