Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
kaidan
kaidan
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 38
    • Issues 38
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 12
    • Merge Requests 12
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • KDE
  • kaidankaidan
  • Merge Requests
  • !393

Open
Opened Oct 17, 2019 by Jonah Brüchert@jbbgameich🌳
  • Report abuse
Report abuse

Add way to extract icon list

This is a rather simple approach to make sure we'll not forget to add icons to the list again.

Every icon name is marked as such using the icn() function. (hope I didn't forget any)

The icon list can be extracted using ./utils/extract-icons.py, and added to the kirigami_package_breeze_icons()t call.

The only downside right now is that icons used on the c++ side are not extracted. This could be workarounded either by adding /*icn(*/ "im-user-online" /*)*/ or by simply mentioning the icon on the qml side in a comment.

Edited Oct 17, 2019 by Jonah Brüchert

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://invent.kde.org/jbbgameich/kaidan.git" "icons"
git checkout -b "jbbgameich/kaidan-icons" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "jbbgameich/kaidan-icons"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 0
  • Commits 3
  • Pipelines 8
  • Changes 16
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
1
Labels
build system & scripts
Assign labels
  • View project labels
Reference: kde/kaidan!393